Re: Report on MAINTAINERS coverage

[Markus Armbruster <armbru@redhat.com>]

Stefan Weil via <qemu-devel@nongnu.org> writes:

> Am 18.12.25 um 13:45 schrieb Markus Armbruster:
>> Back in 2014 (time flies), I posted
>> 
>>      Subject: MAINTAINERS leaves too many files uncovered
>>      Message-ID: <87mw8rumhb.fsf@blackfin.pond.sub.org>
>>      https://lore.kernel.org/qemu-devel/87mw8rumhb.fsf@blackfin.pond.sub.org/
>> 
>> I updated my findings in 2015, 2016 (at commit e00da552a0d), 2018 (at
>> v3.1.0-rc2), and 2023 (at commit 36e9aab3c56, close to v8.2.0).  This is
>> another update, at v10.2.0-rc4.
>
>
> These two files were contributed by me and most of my initial code is 
> still unmodified, so I could be added as their maintainer:
>
> hw/nvram/eeprom93xx.c
> include/hw/nvram/eeprom93xx.h

Thanks!

> I had two contributions to the eeprom93xx.c (one made by Thiemo in my 
> name). Other authors had also two or more contributions:
>
>        2 Author: Alex Williamson <alex@shazbot.org>
>        2 Author: Anthony Liguori <anthony@codemonkey.ws>
>        2 Author: Aurelien Jarno <aurelien@aurel32.net>
>        2 Author: Marc-André Lureau <marcandre.lureau@redhat.com>
>        3 Author: Blue Swirl <blauwirbel@gmail.com>
>        3 Author: Juan Quintela <quintela@trasno.org>
>        3 Author: Paolo Bonzini <pbonzini@redhat.com>
>        5 Author: Markus Armbruster <armbru@redhat.com>
>
> I am not sure about the desired order in MAINTAINERS. Therefore I don't 
> intend to send a patch but would be happy if someone else updates this file.

I can take care of it.

MAINTAINERS has the nvram device models either under a machine,
supposedly the one machine that uses it (e.g. ds1225y.c is under
"Jazz"), or in section of its own ("CHRP NVRAM" and "Firmware
configuration (fw_cfg)").

As far as I can tell at a glance, eeprom93xx is used by the eepro100
NICs (i82500, i82551, ...), the tulip NIC, and dc390 SCSI HBA.  These
are all PCI devices available with -device, so not tied to any
particular machine type.  I guess a section of its own makes sense.  Do
you agree?

If yes, the section goes under the Devices heading.  Section order
appears to be unsystematic.  Next to "CHRP NVRAM"?

> For the other files which are von covered by MAINTAINERS, the copyright 
> notice might help to find possible maintainers:
>
> grep --no-filename -r -o "Copyright.*" $(cat FILELIST)|sort -i|uniq -ci

Yes, but I don't have the time to tackle the long tail myself.