All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Keith Packard" <keithp@keithp.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Alex Deucher <alexander.deucher@amd.com>,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH 1/2] drm: vblank: use ktime_t instead of timeval
Date: Thu, 12 Oct 2017 11:20:02 -0700	[thread overview]
Message-ID: <87y3og5iul.fsf@keithp.com> (raw)
In-Reply-To: <20171011152059.2394516-1-arnd@arndb.de>


[-- Attachment #1.1: Type: text/plain, Size: 526 bytes --]

Arnd Bergmann <arnd@arndb.de> writes:

> Overall, this seems good enough, so my patch removes the use of
> 'timeval' from the vblank handling altogether and uses ktime_t
> consistently, except for the part where we copy the data to user
> space structures in the existing format.

This patch is better than the portion of my patch which does the same
thing as it uses the ktime APIs consistently and doesn't assume that
ktime_t is in ns. Thanks much!

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
-keith

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Keith Packard" <keithp@keithp.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Sean Paul <seanpaul@chromium.org>,
	David Airlie <airlied@linux.ie>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Thierry Reding" <treding@nvidia.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm: vblank: use ktime_t instead of timeval
Date: Thu, 12 Oct 2017 11:20:02 -0700	[thread overview]
Message-ID: <87y3og5iul.fsf@keithp.com> (raw)
In-Reply-To: <20171011152059.2394516-1-arnd@arndb.de>

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Arnd Bergmann <arnd@arndb.de> writes:

> Overall, this seems good enough, so my patch removes the use of
> 'timeval' from the vblank handling altogether and uses ktime_t
> consistently, except for the part where we copy the data to user
> space structures in the existing format.

This patch is better than the portion of my patch which does the same
thing as it uses the ktime APIs consistently and doesn't assume that
ktime_t is in ns. Thanks much!

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
-keith

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2017-10-12 18:20 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 15:20 [PATCH 1/2] drm: vblank: use ktime_t instead of timeval Arnd Bergmann
2017-10-11 15:20 ` Arnd Bergmann
2017-10-11 15:20 ` [PATCH 2/2] drm: vblank: remove drm_timestamp_monotonic parameter Arnd Bergmann
2017-10-11 15:40   ` Daniel Stone
2017-10-11 15:40     ` Daniel Stone
2017-10-11 17:36 ` [PATCH 1/2] drm: vblank: use ktime_t instead of timeval Sean Paul
2017-10-11 17:36   ` Sean Paul
2017-10-11 19:00   ` Arnd Bergmann
2017-10-11 19:00     ` Arnd Bergmann
2017-10-11 20:17     ` Keith Packard
2017-10-11 20:18   ` Keith Packard
2017-10-11 20:18     ` Keith Packard
2017-10-11 20:28     ` Sean Paul
2017-10-11 21:07       ` Keith Packard
2017-10-12 13:04       ` Sean Paul
2017-10-12 13:04         ` Sean Paul
2017-10-12 18:20 ` Keith Packard [this message]
2017-10-12 18:20   ` Keith Packard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3og5iul.fsf@keithp.com \
    --to=keithp@keithp.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=arnd@arndb.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.