All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Thomas Huth <thuth@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	qemu-devel@nongnu.org, qemu-arm@nongnu.org,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	qemu-ppc@nongnu.org, qemu-block@nongnu.org,
	qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,
	"Junjie Cao" <junjie.cao@intel.com>
Subject: Re: [PATCH v2 28/28] hw/usb: mark UHCI, OCHI & ECHI USB hosts as secure
Date: Mon, 16 Nov 2026 18:57:31 +0000	[thread overview]
Message-ID: <87zev8ioys.fsf@draig.linaro.org> (raw)
In-Reply-To: <1711cf10-2719-4d6a-93f2-b7a3a7554ecb@redhat.com> (Thomas Huth's message of "Fri, 6 Nov 2026 13:28:18 +0100")

Thomas Huth <thuth@redhat.com> writes:

> On 29/10/2026 14.12, Daniel P. Berrangé wrote:
>> Modern virtualized guests are expected to be deployed with the
>> XHCI controller which supports all of USB 1, 2 and 3. The UHCI
>> OCHI and ECHI hosts, however, have all been widely used in
>> virtualization scenarios historically, especially on x86. Indeed
>> the -usb flag will enable UCHI by default.
>> So while these are undesirable hosts in general, this marks them
>> as secure for virtualization use cases.
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>   hw/usb/hcd-ehci-pci.c    | 1 +
>>   hw/usb/hcd-ehci-sysbus.c | 7 +++++++
>>   hw/usb/hcd-ohci-pci.c    | 1 +
>>   hw/usb/hcd-ohci-sysbus.c | 1 +
>>   hw/usb/hcd-uhci.c        | 1 +
>>   5 files changed, 11 insertions(+)
> I'd also rather drop this patch until we've got a proper USB
> maintainer again. Otherwise we promise that these devices are secure,
> but nobody really takes care of security related issues in the end.
> (It's already exhausting enough to get XHCI into a proper shape again)
>

+1 - it's not like users can't use USB but the warning from failing with
secure will at least make them go in with eyes open/look for
alternatives.

>  Thomas

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro


      reply	other threads:[~2026-11-16 18:57 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 13:12 [PATCH v2 00/28] Mark user creatable devices for secure for virt use case Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 01/28] hw: mark all virtio PCI devices as secure Daniel P. Berrangé
2026-11-06 11:35   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 02/28] hw: mark all virtio CCW " Daniel P. Berrangé
2026-11-06 11:38   ` Thomas Huth
2026-11-06 12:51     ` Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 03/28] hw: mark all vhost devices a secure Daniel P. Berrangé
2026-11-06 11:39   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 04/28] hw: mark all remaining virtio object types as secure Daniel P. Berrangé
2026-11-06 11:52   ` Thomas Huth
2026-11-06 14:35     ` Marc-André Lureau
2026-11-06 14:40       ` Daniel P. Berrangé
2026-11-06 14:52         ` Marc-André Lureau
2026-11-06 17:33           ` Daniel P. Berrangé
2026-11-12 19:01             ` Daniel P. Berrangé
2026-11-13 11:16               ` Alex Bennée
2026-11-13 11:33                 ` Daniel P. Berrangé
2026-11-13 13:20                   ` Alex Bennée
2026-10-29 13:12 ` [PATCH v2 05/28] hw/vfio: mark all VFIO object classes " Daniel P. Berrangé
2026-11-06 11:54   ` Thomas Huth
2026-11-10 15:15   ` Cédric Le Goater
2026-10-29 13:12 ` [PATCH v2 06/28] hw/xen: mark all Xen related object types as being secure Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 07/28] hw/net: mark e1000, e1000e, IGB, rtl8139 & sPAPR VLAN as secure Daniel P. Berrangé
2026-11-06 11:57   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 08/28] hw/usb: mark commonly used USB devices/hosts " Daniel P. Berrangé
2026-11-06 12:05   ` Thomas Huth
2026-11-06 12:21     ` Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 09/28] hw/watchdog: mark some watchdog devices " Daniel P. Berrangé
2026-11-06 12:14   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 10/28] hw/scsi: mark spapr SCSI controller " Daniel P. Berrangé
2026-11-06 12:15   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 11/28] hw/scsi: mark SCSI disk endpoint devices " Daniel P. Berrangé
2026-11-06 12:15   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 12/28] hw/ide: mark ICH9 and ide-hd/ide-cd " Daniel P. Berrangé
2026-11-06 12:32   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 13/28] hw: define most common PCI types " Daniel P. Berrangé
2026-11-06 12:16   ` Thomas Huth
2026-11-06 12:19   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 14/28] hw/pci-host: mark common x86, ppc, arm and s390 PCI hosts " Daniel P. Berrangé
2026-11-06 12:38   ` Thomas Huth
2026-11-06 12:54     ` Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 15/28] hw/display: mark bochs, ramfb and VGA " Daniel P. Berrangé
2026-11-06 12:20   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 16/28] hw/tpm: mark all TPM implementations " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 17/28] hw/misc: mark pvpanic, vmcoreinfo " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 18/28] hw/audio: mark Intel HDA devices & codecs " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 19/28] hw/char: mark common serial / console devices " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 20/28] hw/mem: mark nvdimm, pc-dimm & spapr-nvdimm " Daniel P. Berrangé
2026-11-06 12:40   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 21/28] hw/uefi: mark the EFI vars service " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 22/28] hw/acpi: mark erst, vmclock and vmgenid devices " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 23/28] hw: mark KVM clock and RTC " Daniel P. Berrangé
2026-11-06 12:30   ` Thomas Huth
2026-10-29 13:12 ` [PATCH v2 24/28] hw: device AMD, Intel and ARM IOMMUs " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 25/28] hw/input: mark PS/2 and PC Keyboard devices " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 26/28] hw/i386: mark vmmouse / vmport " Daniel P. Berrangé
2026-10-29 13:12 ` [PATCH v2 27/28] hw/display: mark cirrus and QXL " Daniel P. Berrangé
2026-11-06 12:23   ` Thomas Huth
2026-11-06 14:32     ` Marc-André Lureau
2026-10-29 13:12 ` [PATCH v2 28/28] hw/usb: mark UHCI, OCHI & ECHI USB hosts " Daniel P. Berrangé
2026-11-06 12:28   ` Thomas Huth
2026-11-16 18:57     ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zev8ioys.fsf@draig.linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=junjie.cao@intel.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.