From: Kevin Hilman <khilman@deeprootsystems.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Charulatha V <charu@ti.com>, Paul Walmsley <paul@pwsan.com>,
Rajendra Nayak <rnayak@ti.com>, Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset
Date: Tue, 09 Nov 2010 09:31:41 -0800 [thread overview]
Message-ID: <87zktiqu82.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1289226250-11366-1-git-send-email-manjugk@ti.com> (Manjunath Kondaiah G.'s message of "Mon, 8 Nov 2010 19:54:10 +0530")
"G, Manjunath Kondaiah" <manjugk@ti.com> writes:
> The commit '311225e6' is missing '.module_offs' in prcm
> structure in omap3 hwmod data base which results in accessing
> wrong register for I2Cx IDLEST bit monitoring.
>
> Added module offsets for accessing register CM_IDLEST1_CORE.
>
> Patch tested on Zoom3 using omap2plus_defconfig
Thanks, will fold this into original series.
Kevin
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Signed-off-by: Charulatha V <charu@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index d0d8030..22831e9 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
> .main_clk = "i2c1_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C1_SHIFT,
> .idlest_reg_id = 1,
> @@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
> .main_clk = "i2c2_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C2_SHIFT,
> .idlest_reg_id = 1,
> @@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
> .main_clk = "i2c3_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C3_SHIFT,
> .idlest_reg_id = 1,
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset
Date: Tue, 09 Nov 2010 09:31:41 -0800 [thread overview]
Message-ID: <87zktiqu82.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1289226250-11366-1-git-send-email-manjugk@ti.com> (Manjunath Kondaiah G.'s message of "Mon, 8 Nov 2010 19:54:10 +0530")
"G, Manjunath Kondaiah" <manjugk@ti.com> writes:
> The commit '311225e6' is missing '.module_offs' in prcm
> structure in omap3 hwmod data base which results in accessing
> wrong register for I2Cx IDLEST bit monitoring.
>
> Added module offsets for accessing register CM_IDLEST1_CORE.
>
> Patch tested on Zoom3 using omap2plus_defconfig
Thanks, will fold this into original series.
Kevin
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Signed-off-by: Charulatha V <charu@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index d0d8030..22831e9 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
> .main_clk = "i2c1_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C1_SHIFT,
> .idlest_reg_id = 1,
> @@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
> .main_clk = "i2c2_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C2_SHIFT,
> .idlest_reg_id = 1,
> @@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
> .main_clk = "i2c3_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C3_SHIFT,
> .idlest_reg_id = 1,
next prev parent reply other threads:[~2010-11-09 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 14:24 [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset G, Manjunath Kondaiah
2010-11-09 17:31 ` Kevin Hilman [this message]
2010-11-09 17:31 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zktiqu82.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=charu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.