* [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset
@ 2010-11-08 14:24 G, Manjunath Kondaiah
2010-11-09 17:31 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: G, Manjunath Kondaiah @ 2010-11-08 14:24 UTC (permalink / raw)
To: linux-omap
Cc: linux-arm-kernel, Charulatha V, Kevin Hilman, Paul Walmsley,
Rajendra Nayak, Benoit Cousson
The commit '311225e6' is missing '.module_offs' in prcm
structure in omap3 hwmod data base which results in accessing
wrong register for I2Cx IDLEST bit monitoring.
Added module offsets for accessing register CM_IDLEST1_CORE.
Patch tested on Zoom3 using omap2plus_defconfig
Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
Signed-off-by: Charulatha V <charu@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Paul Walmsley <paul@pwsan.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Benoit Cousson <b-cousson@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
index d0d8030..22831e9 100644
--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
@@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
.main_clk = "i2c1_fck",
.prcm = {
.omap2 = {
+ .module_offs = CORE_MOD,
.prcm_reg_id = 1,
.module_bit = OMAP3430_EN_I2C1_SHIFT,
.idlest_reg_id = 1,
@@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
.main_clk = "i2c2_fck",
.prcm = {
.omap2 = {
+ .module_offs = CORE_MOD,
.prcm_reg_id = 1,
.module_bit = OMAP3430_EN_I2C2_SHIFT,
.idlest_reg_id = 1,
@@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
.main_clk = "i2c3_fck",
.prcm = {
.omap2 = {
+ .module_offs = CORE_MOD,
.prcm_reg_id = 1,
.module_bit = OMAP3430_EN_I2C3_SHIFT,
.idlest_reg_id = 1,
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset
2010-11-08 14:24 [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset G, Manjunath Kondaiah
@ 2010-11-09 17:31 ` Kevin Hilman
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2010-11-09 17:31 UTC (permalink / raw)
To: G, Manjunath Kondaiah
Cc: linux-omap, linux-arm-kernel, Charulatha V, Paul Walmsley,
Rajendra Nayak, Benoit Cousson
"G, Manjunath Kondaiah" <manjugk@ti.com> writes:
> The commit '311225e6' is missing '.module_offs' in prcm
> structure in omap3 hwmod data base which results in accessing
> wrong register for I2Cx IDLEST bit monitoring.
>
> Added module offsets for accessing register CM_IDLEST1_CORE.
>
> Patch tested on Zoom3 using omap2plus_defconfig
Thanks, will fold this into original series.
Kevin
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Signed-off-by: Charulatha V <charu@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index d0d8030..22831e9 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
> .main_clk = "i2c1_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C1_SHIFT,
> .idlest_reg_id = 1,
> @@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
> .main_clk = "i2c2_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C2_SHIFT,
> .idlest_reg_id = 1,
> @@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
> .main_clk = "i2c3_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C3_SHIFT,
> .idlest_reg_id = 1,
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset
@ 2010-11-09 17:31 ` Kevin Hilman
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Hilman @ 2010-11-09 17:31 UTC (permalink / raw)
To: linux-arm-kernel
"G, Manjunath Kondaiah" <manjugk@ti.com> writes:
> The commit '311225e6' is missing '.module_offs' in prcm
> structure in omap3 hwmod data base which results in accessing
> wrong register for I2Cx IDLEST bit monitoring.
>
> Added module offsets for accessing register CM_IDLEST1_CORE.
>
> Patch tested on Zoom3 using omap2plus_defconfig
Thanks, will fold this into original series.
Kevin
> Signed-off-by: G, Manjunath Kondaiah <manjugk@ti.com>
> Signed-off-by: Charulatha V <charu@ti.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index d0d8030..22831e9 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -642,6 +642,7 @@ static struct omap_hwmod omap3xxx_i2c1_hwmod = {
> .main_clk = "i2c1_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C1_SHIFT,
> .idlest_reg_id = 1,
> @@ -683,6 +684,7 @@ static struct omap_hwmod omap3xxx_i2c2_hwmod = {
> .main_clk = "i2c2_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C2_SHIFT,
> .idlest_reg_id = 1,
> @@ -724,6 +726,7 @@ static struct omap_hwmod omap3xxx_i2c3_hwmod = {
> .main_clk = "i2c3_fck",
> .prcm = {
> .omap2 = {
> + .module_offs = CORE_MOD,
> .prcm_reg_id = 1,
> .module_bit = OMAP3430_EN_I2C3_SHIFT,
> .idlest_reg_id = 1,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-09 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-08 14:24 [PATCH] OMAP3: I2C: hwmod: Fix PRCM module offset G, Manjunath Kondaiah
2010-11-09 17:31 ` Kevin Hilman
2010-11-09 17:31 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.