From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Johnny Park <pjohnny0508@gmail.com>, <horms@kernel.org>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <pmenzel@molgen.mpg.de>
Subject: Re: [Intel-wired-lan] [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c
Date: Thu, 24 Oct 2024 10:41:25 +0200 [thread overview]
Message-ID: <91005d18-37c7-483b-bda5-2fa57a884a17@intel.com> (raw)
In-Reply-To: <Zxne9hBl5E5VhKGm@Fantasy-Ubuntu>
On 10/24/24 07:45, Johnny Park wrote:
> Fix 2 spelling mistakes in comments in `igb_main.c`.
>
> Signed-off-by: Johnny Park <pjohnny0508@gmail.com>
you should collect Reviewed-by tags, as the one from Simon on v2.
for future Intel Ethernet drivers series, please target them to IWL
(net-next in the Subject becomes iwl-next)
> ---
> Changes in v3:
> - Adjust commit message
>
> Changes in v2:
> - Fix spelling mor -> more
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 1ef4cb871452..fc587304b3c0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -1204,7 +1204,7 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter,
> /* initialize pointer to rings */
> ring = q_vector->ring;
>
> - /* intialize ITR */
> + /* initialize ITR */
> if (rxr_count) {
> /* rx or rx/tx vector */
Would be great to have capitalization errors fixed too, Rx, Tx, VF, not
necessarily in this patch.
> if (!adapter->rx_itr_setting || adapter->rx_itr_setting > 3)
> @@ -3906,7 +3906,7 @@ static void igb_remove(struct pci_dev *pdev)
> *
> * This function initializes the vf specific data storage and then attempts to
> * allocate the VFs. The reason for ordering it this way is because it is much
> - * mor expensive time wise to disable SR-IOV than it is to allocate and free
> + * more expensive time wise to disable SR-IOV than it is to allocate and free
> * the memory for the VFs.
> **/
> static void igb_probe_vfs(struct igb_adapter *adapter)
to reduce traffic, I'm fine with this, to go via any tree:
Acked-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Johnny Park <pjohnny0508@gmail.com>, <horms@kernel.org>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <pmenzel@molgen.mpg.de>
Subject: Re: [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c
Date: Thu, 24 Oct 2024 10:41:25 +0200 [thread overview]
Message-ID: <91005d18-37c7-483b-bda5-2fa57a884a17@intel.com> (raw)
In-Reply-To: <Zxne9hBl5E5VhKGm@Fantasy-Ubuntu>
On 10/24/24 07:45, Johnny Park wrote:
> Fix 2 spelling mistakes in comments in `igb_main.c`.
>
> Signed-off-by: Johnny Park <pjohnny0508@gmail.com>
you should collect Reviewed-by tags, as the one from Simon on v2.
for future Intel Ethernet drivers series, please target them to IWL
(net-next in the Subject becomes iwl-next)
> ---
> Changes in v3:
> - Adjust commit message
>
> Changes in v2:
> - Fix spelling mor -> more
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 1ef4cb871452..fc587304b3c0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -1204,7 +1204,7 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter,
> /* initialize pointer to rings */
> ring = q_vector->ring;
>
> - /* intialize ITR */
> + /* initialize ITR */
> if (rxr_count) {
> /* rx or rx/tx vector */
Would be great to have capitalization errors fixed too, Rx, Tx, VF, not
necessarily in this patch.
> if (!adapter->rx_itr_setting || adapter->rx_itr_setting > 3)
> @@ -3906,7 +3906,7 @@ static void igb_remove(struct pci_dev *pdev)
> *
> * This function initializes the vf specific data storage and then attempts to
> * allocate the VFs. The reason for ordering it this way is because it is much
> - * mor expensive time wise to disable SR-IOV than it is to allocate and free
> + * more expensive time wise to disable SR-IOV than it is to allocate and free
> * the memory for the VFs.
> **/
> static void igb_probe_vfs(struct igb_adapter *adapter)
to reduce traffic, I'm fine with this, to go via any tree:
Acked-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
next prev parent reply other threads:[~2024-10-24 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 5:45 [Intel-wired-lan] [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c Johnny Park
2024-10-24 5:45 ` Johnny Park
2024-10-24 8:41 ` Przemek Kitszel [this message]
2024-10-24 8:41 ` Przemek Kitszel
2024-10-25 5:06 ` [Intel-wired-lan] " Johnny Park
2024-10-25 5:06 ` Johnny Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91005d18-37c7-483b-bda5-2fa57a884a17@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pjohnny0508@gmail.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.