From: Johnny Park <pjohnny0508@gmail.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: horms@kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, pmenzel@molgen.mpg.de
Subject: Re: [Intel-wired-lan] [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c
Date: Thu, 24 Oct 2024 23:06:15 -0600 [thread overview]
Message-ID: <ZxsnR_fJ5aGKWJTq@Fantasy-Ubuntu> (raw)
In-Reply-To: <91005d18-37c7-483b-bda5-2fa57a884a17@intel.com>
On Thu, Oct 24, 2024 at 10:41:25AM +0200, Przemek Kitszel wrote:
> On 10/24/24 07:45, Johnny Park wrote:
> you should collect Reviewed-by tags, as the one from Simon on v2.
Sorry, I wasn't aware of that rule. For future pathces I'll include reviewed/acked tags.
> for future Intel Ethernet drivers series, please target them to IWL
> (net-next in the Subject becomes iwl-next)
Sorry again, from the other patchworks https://patchwork.ozlabs.org/project/intel-wired-lan/list/ I should have noticed that pattern.
> > ring = q_vector->ring;
> > - /* intialize ITR */
> > + /* initialize ITR */
> > if (rxr_count) {
> > /* rx or rx/tx vector */
>
> Would be great to have capitalization errors fixed too, Rx, Tx, VF, not
> necessarily in this patch.
That sounds like a good idea, perhaps fixing those will be my next patch.
> to reduce traffic, I'm fine with this, to go via any tree:
> Acked-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Thank you for the review!
Regards,
Johnny
WARNING: multiple messages have this Message-ID (diff)
From: Johnny Park <pjohnny0508@gmail.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: horms@kernel.org, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, pmenzel@molgen.mpg.de
Subject: Re: [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c
Date: Thu, 24 Oct 2024 23:06:15 -0600 [thread overview]
Message-ID: <ZxsnR_fJ5aGKWJTq@Fantasy-Ubuntu> (raw)
In-Reply-To: <91005d18-37c7-483b-bda5-2fa57a884a17@intel.com>
On Thu, Oct 24, 2024 at 10:41:25AM +0200, Przemek Kitszel wrote:
> On 10/24/24 07:45, Johnny Park wrote:
> you should collect Reviewed-by tags, as the one from Simon on v2.
Sorry, I wasn't aware of that rule. For future pathces I'll include reviewed/acked tags.
> for future Intel Ethernet drivers series, please target them to IWL
> (net-next in the Subject becomes iwl-next)
Sorry again, from the other patchworks https://patchwork.ozlabs.org/project/intel-wired-lan/list/ I should have noticed that pattern.
> > ring = q_vector->ring;
> > - /* intialize ITR */
> > + /* initialize ITR */
> > if (rxr_count) {
> > /* rx or rx/tx vector */
>
> Would be great to have capitalization errors fixed too, Rx, Tx, VF, not
> necessarily in this patch.
That sounds like a good idea, perhaps fixing those will be my next patch.
> to reduce traffic, I'm fine with this, to go via any tree:
> Acked-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Thank you for the review!
Regards,
Johnny
next prev parent reply other threads:[~2024-10-25 5:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 5:45 [Intel-wired-lan] [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c Johnny Park
2024-10-24 5:45 ` Johnny Park
2024-10-24 8:41 ` [Intel-wired-lan] " Przemek Kitszel
2024-10-24 8:41 ` Przemek Kitszel
2024-10-25 5:06 ` Johnny Park [this message]
2024-10-25 5:06 ` Johnny Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxsnR_fJ5aGKWJTq@Fantasy-Ubuntu \
--to=pjohnny0508@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.