Re: [PATCH v2 2/6] xen/riscv: set A/D bits in Xen's page-table mappings under Svade

[Jan Beulich <jbeulich@suse.com>]

On 10.09.2026 11:34, Baptiste Le Duc wrote:
> The previous patch set A/D bits in case of the Svade extension for G-stage

As I think I have said before - no "the previous patch" or anything alike
please in descriptions.

> --- a/xen/arch/riscv/mm.c
> +++ b/xen/arch/riscv/mm.c
> @@ -140,7 +140,7 @@ static void __init setup_initial_mapping(struct mmu_desc *mmu_desc,
>          case 1: /* Level 0 */
>              {
>                  unsigned long paddr = (page_addr - map_start) + pa_start;
> -                unsigned int permissions = PTE_LEAF_DEFAULT;
> +                unsigned int permissions = PAGE_HYPERVISOR_RW;

The variable was already not named entirely adequately, as PTE_VALID is
only somewhat a "permission". Now it clearly holds more than just
permission bits, so want to be given a better name.

Jan