From: Fabio Estevam <festevam@denx.de>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: michael@walle.cc, takahiro.kuwano@infineon.com,
pratyush@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, bacem.daassi@infineon.com,
miquel.raynal@bootlin.com, richard@nod.at
Subject: Re: [PATCH v2 2/6] mtd: spi-nor: add erase die (chip) capability
Date: Thu, 02 Nov 2023 15:01:28 -0300 [thread overview]
Message-ID: <968ba4c249926e986b02440ad0421e98@denx.de> (raw)
In-Reply-To: <6f1aa670-b3f7-4ea3-bc80-773a57e46c36@linaro.org>
On 02/11/2023 14:59, Tudor Ambarus wrote:
> On 11/2/23 17:54, Tudor Ambarus wrote:
>> Does this help?
>>
>
> I guess not, because you used the full flash erase in the first place,
> but still a bug. Ok, I'll add some prints.
Yes, it did not help:
root@mcde3000a:~# time flash_erase /dev/mtd0 0 0
Erasing 131072 Kibyte @ 0 -- 0 [ 27.693305] ****** n_dice: 2
% complete [ 27.699053] ****** die_size: 67108864
[ 27.703650] ****** multi_die_erase: 1
[ 27.707342] ****** addr: 0
[ 27.710070] ****** len: 134217728
[ 27.713406] **** Logic addr & (die_size - 1): 0
[ 27.718017] **************** spi_nor_erase_dice 1
[ 27.722793] spi-nor spi0.0: **** Die size is 65536KiB
[ 27.727964] spi-nor spi0.0: ***** nor->params->die_erase_opcode: 0xc4
[ 27.734430] spi-nor spi0.0: ***** nor->addr_nbytes: 4
[ 27.739498] spi-nor spi0.0: ***** addr 0x0
[ 27.743614] spi-nor spi0.0: ***** multi_die: 1
[ 27.748094] spi-nor spi0.0: ***** SR before erase: 0x2
[ 27.753278] spi-nor spi0.0: ***** SR after erase: 0x2
[ 27.758387] spi-nor spi0.0: **** Die size is 65536KiB
[ 27.763559] spi-nor spi0.0: ***** nor->params->die_erase_opcode: 0xc4
[ 27.770017] spi-nor spi0.0: ***** nor->addr_nbytes: 4
[ 27.775085] spi-nor spi0.0: ***** addr 0x4000000
[ 27.779724] spi-nor spi0.0: ***** multi_die: 1
[ 27.784249] spi-nor spi0.0: ***** SR before erase: 0x2
[ 27.789496] spi-nor spi0.0: ***** SR after erase: 0x2
Erasing 131072 Kibyte @ 0 -- 100 % complete
real 0m0.110s
user 0m0.001s
sys 0m0.107s
root@mcde3000a:~# hexdump /dev/mtd0
0000000 a1d4 168c 4dad dfb2 2a3d c2af 0aae c18a
0000010 2d5f 177a c39f 46a4 f9cd b880 331e 2543
0000020 dd47 8981 1eaa aab4 9626 336c 4f74 2b22
....
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Fabio Estevam <festevam@denx.de>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: michael@walle.cc, takahiro.kuwano@infineon.com,
pratyush@kernel.org, linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, bacem.daassi@infineon.com,
miquel.raynal@bootlin.com, richard@nod.at
Subject: Re: [PATCH v2 2/6] mtd: spi-nor: add erase die (chip) capability
Date: Thu, 02 Nov 2023 15:01:28 -0300 [thread overview]
Message-ID: <968ba4c249926e986b02440ad0421e98@denx.de> (raw)
In-Reply-To: <6f1aa670-b3f7-4ea3-bc80-773a57e46c36@linaro.org>
On 02/11/2023 14:59, Tudor Ambarus wrote:
> On 11/2/23 17:54, Tudor Ambarus wrote:
>> Does this help?
>>
>
> I guess not, because you used the full flash erase in the first place,
> but still a bug. Ok, I'll add some prints.
Yes, it did not help:
root@mcde3000a:~# time flash_erase /dev/mtd0 0 0
Erasing 131072 Kibyte @ 0 -- 0 [ 27.693305] ****** n_dice: 2
% complete [ 27.699053] ****** die_size: 67108864
[ 27.703650] ****** multi_die_erase: 1
[ 27.707342] ****** addr: 0
[ 27.710070] ****** len: 134217728
[ 27.713406] **** Logic addr & (die_size - 1): 0
[ 27.718017] **************** spi_nor_erase_dice 1
[ 27.722793] spi-nor spi0.0: **** Die size is 65536KiB
[ 27.727964] spi-nor spi0.0: ***** nor->params->die_erase_opcode: 0xc4
[ 27.734430] spi-nor spi0.0: ***** nor->addr_nbytes: 4
[ 27.739498] spi-nor spi0.0: ***** addr 0x0
[ 27.743614] spi-nor spi0.0: ***** multi_die: 1
[ 27.748094] spi-nor spi0.0: ***** SR before erase: 0x2
[ 27.753278] spi-nor spi0.0: ***** SR after erase: 0x2
[ 27.758387] spi-nor spi0.0: **** Die size is 65536KiB
[ 27.763559] spi-nor spi0.0: ***** nor->params->die_erase_opcode: 0xc4
[ 27.770017] spi-nor spi0.0: ***** nor->addr_nbytes: 4
[ 27.775085] spi-nor spi0.0: ***** addr 0x4000000
[ 27.779724] spi-nor spi0.0: ***** multi_die: 1
[ 27.784249] spi-nor spi0.0: ***** SR before erase: 0x2
[ 27.789496] spi-nor spi0.0: ***** SR after erase: 0x2
Erasing 131072 Kibyte @ 0 -- 100 % complete
real 0m0.110s
user 0m0.001s
sys 0m0.107s
root@mcde3000a:~# hexdump /dev/mtd0
0000000 a1d4 168c 4dad dfb2 2a3d c2af 0aae c18a
0000010 2d5f 177a c39f 46a4 f9cd b880 331e 2543
0000020 dd47 8981 1eaa aab4 9626 336c 4f74 2b22
....
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-02 18:01 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 14:58 [PATCH v2 0/6] mtd: spi-nor: introduce die erase Tudor Ambarus
2023-11-01 14:58 ` Tudor Ambarus
2023-11-01 14:58 ` [PATCH v2 1/6] mtd: spi-nor: use kernel sized types instead of c99 types Tudor Ambarus
2023-11-01 14:58 ` Tudor Ambarus
2023-11-01 14:58 ` [PATCH v2 2/6] mtd: spi-nor: add erase die (chip) capability Tudor Ambarus
2023-11-01 14:58 ` Tudor Ambarus
2023-11-01 16:04 ` Tudor Ambarus
2023-11-01 16:04 ` Tudor Ambarus
2023-11-01 16:17 ` Fabio Estevam
2023-11-01 16:17 ` Fabio Estevam
2023-11-01 17:27 ` Tudor Ambarus
2023-11-01 17:27 ` Tudor Ambarus
2023-11-02 16:43 ` Fabio Estevam
2023-11-02 16:43 ` Fabio Estevam
2023-11-02 17:36 ` Tudor Ambarus
2023-11-02 17:36 ` Tudor Ambarus
2023-11-02 17:40 ` Fabio Estevam
2023-11-02 17:40 ` Fabio Estevam
2023-11-02 17:47 ` Tudor Ambarus
2023-11-02 17:47 ` Tudor Ambarus
2023-11-02 17:54 ` Tudor Ambarus
2023-11-02 17:54 ` Tudor Ambarus
2023-11-02 17:59 ` Tudor Ambarus
2023-11-02 17:59 ` Tudor Ambarus
2023-11-02 18:01 ` Fabio Estevam [this message]
2023-11-02 18:01 ` Fabio Estevam
2023-11-02 18:21 ` Tudor Ambarus
2023-11-02 18:21 ` Tudor Ambarus
2023-11-02 18:33 ` Fabio Estevam
2023-11-02 18:33 ` Fabio Estevam
2023-11-02 18:46 ` Tudor Ambarus
2023-11-02 18:46 ` Tudor Ambarus
2023-11-02 18:56 ` Tudor Ambarus
2023-11-02 18:56 ` Tudor Ambarus
2023-11-02 21:42 ` Fabio Estevam
2023-11-02 21:42 ` Fabio Estevam
2023-11-03 11:47 ` Tudor Ambarus
2023-11-03 11:47 ` Tudor Ambarus
2023-11-03 12:30 ` Fabio Estevam
2023-11-03 12:30 ` Fabio Estevam
2023-11-03 12:53 ` Fabio Estevam
2023-11-03 12:53 ` Fabio Estevam
2023-11-03 13:26 ` Tudor Ambarus
2023-11-03 13:26 ` Tudor Ambarus
2023-11-03 13:37 ` Fabio Estevam
2023-11-03 13:37 ` Fabio Estevam
2023-11-03 13:48 ` Tudor Ambarus
2023-11-03 13:48 ` Tudor Ambarus
2023-11-03 14:16 ` Fabio Estevam
2023-11-03 14:16 ` Fabio Estevam
2023-11-03 14:37 ` Tudor Ambarus
2023-11-03 14:37 ` Tudor Ambarus
2023-11-03 14:58 ` Fabio Estevam
2023-11-03 14:58 ` Fabio Estevam
2023-11-06 14:24 ` Tudor Ambarus
2023-11-06 14:24 ` Tudor Ambarus
2023-11-06 9:34 ` Michael Walle
2023-11-06 9:34 ` Michael Walle
2023-11-06 14:23 ` Tudor Ambarus
2023-11-06 14:23 ` Tudor Ambarus
2023-11-06 14:56 ` Tudor Ambarus
2023-11-06 14:56 ` Tudor Ambarus
2023-11-09 9:09 ` Michael Walle
2023-11-09 9:09 ` Michael Walle
2023-11-15 7:06 ` Tudor Ambarus
2023-11-15 7:06 ` Tudor Ambarus
2023-11-08 8:06 ` Takahiro Kuwano
2023-11-08 8:06 ` Takahiro Kuwano
2023-11-08 8:54 ` Tudor Ambarus
2023-11-08 8:54 ` Tudor Ambarus
2023-11-01 14:58 ` [PATCH v2 3/6] mtd: spi-nor: spansion: enable die erase for multi die flashes Tudor Ambarus
2023-11-01 14:58 ` Tudor Ambarus
2023-11-01 14:58 ` [PATCH v2 4/6] mtd: spi-nor: micron-st: " Tudor Ambarus
2023-11-01 14:58 ` Tudor Ambarus
2023-11-01 14:58 ` [PATCH v2 5/6] mtd: spi-nor: remove NO_CHIP_ERASE flag Tudor Ambarus
2023-11-01 14:58 ` Tudor Ambarus
2023-11-01 14:58 ` [PATCH v2 6/6] mtd: spi-nor: micron-st: Add support for mt25qu01g Tudor Ambarus
2023-11-01 14:58 ` Tudor Ambarus
2023-11-01 15:54 ` [PATCH v2 0/6] mtd: spi-nor: introduce die erase Fabio Estevam
2023-11-01 15:54 ` Fabio Estevam
2023-11-15 6:10 ` Re (subset): " Tudor Ambarus
2023-11-15 6:10 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=968ba4c249926e986b02440ad0421e98@denx.de \
--to=festevam@denx.de \
--cc=bacem.daassi@infineon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=takahiro.kuwano@infineon.com \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.