Re: [PATCH] Guest boot loader support

[aq <aquynh@gmail.com>]

On 4/26/05, Jeremy Katz <katzj@redhat.com> wrote:
> Attached is an updated version of the patch to add boot loader support
> for guest domains.
> 
> Changes from the initial set of patches:
> * Per Ian's request, adds an option to specify booting a specific kernel
> from the host domain (you can specify it either with the title of the
> boot loader config entry or with the grub 0-based index)
> * Reduces some of the code duplication for finding out what the virtual
> disk to boot off of is
> * Improved error handling to use the standard Xen logging and error
> facilities
> 
> At this point, I think that we handle the use cases where a user just
> wants to have everything specified from within the guest domain,
> creating a domain with xm create and wanting to be able to interactively
> select a kernel and asking for a specific entry from the grub.conf to be
> booted when creating a domain.
> 
> Future things (which I think are fine to do after the initial pass is
> committed) include
> * Reworking to use the planned new console infrastructure [1]
> * Handling whole disks
> * More filesystem support -- the code is generic and has all the hooks,
> I just haven't delved deep enough into any of the other fs libraries
> * Further improvements for the menu interface
> 
> Signed-off-by: Jeremy Katz <katzj@redhat.com>
> 
> Jeremy
> 
> [1] And I foolishly told Ian I'd start a discussion about this last week
> and still haven't.  Hopefully tonight.

Jeremy, I tried it out with the latest xen-unstable got from the
homepage and patch with xen-booloader.patch. There are few "hunk".
What xen-unstable version are you using?

By the way, did you forget __init__.py in pygrub/src/ ? pygrub is a
python package, and looks like we need it. At the moment compilation
spit out an error "... __init__.py not found...".

Quick fix:

    touch tools/pygrub/src/__init__.py

then no more complain.

regards,
aq