Re: [PATCH] Guest boot loader support

[aq <aquynh@gmail.com>]

On 4/27/05, Jeremy Katz <katzj@redhat.com> wrote:
> On Tue, 2005-04-26 at 18:32 +0900, aq wrote:
> > Jeremy, I tried it out with the latest xen-unstable got from the
> > homepage and patch with xen-booloader.patch. There are few "hunk".
> > What xen-unstable version are you using?
> 
> Bah, bitkeeper foils me again.  Rediffed to current -unstable attached.
> Thanks for catching that.
> 
> > By the way, did you forget __init__.py in pygrub/src/ ? pygrub is a
> > python package, and looks like we need it. At the moment compilation
> > spit out an error "... __init__.py not found...".
> 
> It was there at one point... added it as well for this diff.
> 
> As for your other comment, the r quoting of the strings is to make sure
> that the strings are interpreted as raw strings instead of trying to
> handle escaping which helps in cases where you have "odd" things in your
> grub.conf.

ok, i see the point.

other question: pygrub::get_config(fn) tries to read
"/boot/grub/grub.conf". Normally this should be "/boot/grub/menu.lst".
I wonder which distro are you working on?

I expect this code will be in -unstable soon, so we can work on the
same code base. sending patch would be easier.

thank you,
aq