Re: [PATCH] Guest boot loader support

[aq <aquynh@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]

On 4/26/05, aq <aquynh@gmail.com> wrote:
> On 4/26/05, Jeremy Katz <katzj@redhat.com> wrote:
> > Attached is an updated version of the patch to add boot loader support
> > for guest domains.
> >
> > Changes from the initial set of patches:
> > * Per Ian's request, adds an option to specify booting a specific kernel
> > from the host domain (you can specify it either with the title of the
> > boot loader config entry or with the grub 0-based index)
> > * Reduces some of the code duplication for finding out what the virtual
> > disk to boot off of is
> > * Improved error handling to use the standard Xen logging and error
> > facilities
> >

Jeremy, I looked at your code, and find few lines like this:

   exec("%s = r\"%s\"" %(self.commands[com], arg.strip()))

Looks like you dont need the above "r". Then the code should be:

   exec("%s = \"%s\"" %(self.commands[com], arg.strip()))

Here is a small patch (against your patch) to remove those typos.

$ diffstat booloader1.patch
 xen-bootloader2.patch |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>

[-- Attachment #2: booloader1.patch --]
[-- Type: application/octet-stream, Size: 1001 bytes --]

--- xen-bootloader.patch	2005-04-26 18:47:36.437028000 +0900
+++ xen-bootloader2.patch	2005-04-26 18:49:01.687028000 +0900
@@ -147,7 +147,7 @@ diff -Nru a/tools/pygrub/src/GrubConf.py
 +
 +            if self.commands.has_key(com):
 +                if self.commands[com] is not None:
-+                    exec("%s = r\"%s\"" %(self.commands[com], arg.strip()))
++                    exec("%s = \"%s\"" %(self.commands[com], arg.strip()))
 +                else:
 +                    logging.info("Ignored image directive %s" %(com,))
 +            else:
@@ -246,7 +246,7 @@ diff -Nru a/tools/pygrub/src/GrubConf.py
 +
 +            if self.commands.has_key(com):
 +                if self.commands[com] is not None:
-+                    exec("%s = r\"%s\"" %(self.commands[com], arg.strip()))
++                    exec("%s = \"%s\"" %(self.commands[com], arg.strip()))
 +                else:
 +                    logging.info("Ignored directive %s" %(com,))
 +            else:

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel