Re: [PATCH] Guest boot loader support

[aq <aquynh@gmail.com>]

On 4/27/05, Jeremy Katz <katzj@redhat.com> wrote:
> On Tue, 2005-04-26 at 18:32 +0900, aq wrote:
> > Jeremy, I tried it out with the latest xen-unstable got from the
> > homepage and patch with xen-booloader.patch. There are few "hunk".
> > What xen-unstable version are you using?
> 
> Bah, bitkeeper foils me again.  Rediffed to current -unstable attached.
> Thanks for catching that.
> 
> > By the way, did you forget __init__.py in pygrub/src/ ? pygrub is a
> > python package, and looks like we need it. At the moment compilation
> > spit out an error "... __init__.py not found...".
> 
> It was there at one point... added it as well for this diff.
> 
> As for your other comment, the r quoting of the strings is to make sure
> that the strings are interpreted as raw strings instead of trying to
> handle escaping which helps in cases where you have "odd" things in your
> grub.conf.
> 
> Jeremy
> 

I checked the new patch. src/__init__.py is not in yet?

$ diffstat xen-bootloader-2.patch 
 Makefile                          |    1 
 pygrub/Makefile                   |   18 ++
 pygrub/setup.py                   |   25 ++
 pygrub/src/GrubConf.py            |  229 ++++++++++++++++++++++++++
 pygrub/src/fsys/__init__.py       |   61 ++++++
 pygrub/src/fsys/ext2/__init__.py  |   38 ++++
 pygrub/src/fsys/ext2/ext2module.c |  332 ++++++++++++++++++++++++++++++++++++++
 pygrub/src/fsys/ext2/test.py      |   15 +
 pygrub/src/pygrub                 |  270 ++++++++++++++++++++++++++++++
 python/xen/xend/XendBootloader.py |   95 ++++++++++
 python/xen/xend/XendDomainInfo.py |   42 ++++
 python/xen/xend/server/blkif.py   |    9 +
 python/xen/xm/create.py           |   34 +++
 13 files changed, 1165 insertions(+), 4 deletions(-)

when i use diff to produce the patch, if the src/__init__.py is empty,
diff would ignore that file, too. so the trick is to create
__init__.py with a space inside ;-)

regards,
aq