From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Kouya Shimura <kouya@jp.fujitsu.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] x86, hvm: Allow delivery of timer interrupts to VCPUs != 0.
Date: Fri, 03 Jul 2009 07:41:46 +0100 [thread overview]
Message-ID: <C67366BA.EBE4%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <7k4otuo0g8.fsf@pingu.sky.yk.fujitsu.co.jp>
This doesn't look too bad, given the current vpt interface we have. My main
comment is regarding vpit_vcpu(), vrtc_vcpu() and vhpet.vcpu. Seems all of
these could unconditionally use i8259_target. I suggest also introducing
vhpet_vcpu(), and then pointing all three *_vcpu() macros at
pt_i8259_target() only. And get rid of the vhpet.vcpu field.
Would that work okay?
-- Keir
On 03/07/2009 05:27, "Kouya Shimura" <kouya@jp.fujitsu.com> wrote:
> This patch is needed for kexec/kdump since kdump may halt VCPU#0.
>
> Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>
>
next prev parent reply other threads:[~2009-07-03 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 4:27 [PATCH] x86, hvm: Allow delivery of timer interrupts to VCPUs != 0 Kouya Shimura
2009-07-03 6:41 ` Keir Fraser [this message]
2009-07-03 7:57 ` Kouya Shimura
2009-07-03 9:33 ` Keir Fraser
2009-07-06 7:05 ` Kouya Shimura
2009-07-06 7:07 ` [PATCH 1/2] x86, hvm: cleanup hpet.c as well as i8254.c or rtc.c Kouya Shimura
2009-07-06 7:09 ` [PATCH 2/2] x86, hvm: Allow delivery of timer interrupts to VCPUs != 0 Kouya Shimura
2009-07-07 13:21 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C67366BA.EBE4%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=kouya@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.