All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4]Diskdump Update
@ 2004-06-11 11:34 Takao Indoh
  2004-06-11 11:40 ` [PATCH 1/4]Diskdump Update Takao Indoh
                   ` (4 more replies)
  0 siblings, 5 replies; 21+ messages in thread
From: Takao Indoh @ 2004-06-11 11:34 UTC (permalink / raw)
  To: linux-kernel

Hi,

I update the Diskdump patch for kernel 2.6.6. I fixed some codes 
according to comments from Christoph Hellwig.
http://marc.theaimsgroup.com/?l=linux-kernel&m=108566610109915&w=2

Source code can be downloaded from
	http://sourceforge.net/projects/lkdump

Please feel free to comment.

Next week, I'll try the following and release new patch.

1) Change codes around add_timer()/del_timer()/etc.
2) Replace dev_t with block_device
3) Clean code more



On Thu, 27 May 2004 14:51:34 +0100, Christoph Hellwig wrote:

>> +/******************************** Disk dump ****************************
>> *******/
>> +#if defined(CONFIG_DISKDUMP) || defined(CONFIG_DISKDUMP_MODULE)
>> +#undef  add_timer
>> +#define add_timer       diskdump_add_timer
>> +#undef  del_timer_sync
>> +#define del_timer_sync  diskdump_del_timer
>> +#undef  del_timer
>> +#define del_timer       diskdump_del_timer
>> +#undef  mod_timer
>> +#define mod_timer       diskdump_mod_timer
>> +
>> +#define tasklet_schedule        diskdump_tasklet_schedule
>> +#endif
>
>Yikes.  No way in hell we'll place code like this in drivers. This needs
>to be handled in common code.

Another approach is insering some codes into the core timer and tasklet
routines.

For example, 

static inline void add_timer(struct timer_list * timer)
{
	if(crashdump_mode())
		__diskdump_add_timer(timer);
	else
		__mod_timer(timer, timer->expires);
}

But I do not want to make common codes dirty...
Please let me know more good idea!

Best Regards,
Takao Indoh

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2004-06-23  1:46 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-11 11:34 [PATCH 0/4]Diskdump Update Takao Indoh
2004-06-11 11:40 ` [PATCH 1/4]Diskdump Update Takao Indoh
2004-06-11 11:50   ` Arjan van de Ven
2004-06-11 13:40     ` Takao Indoh
2004-06-11 15:17       ` Martin J. Bligh
2004-06-14  1:38         ` Takao Indoh
2004-06-14  2:08           ` Martin J. Bligh
2004-06-21  7:59     ` Takao Indoh
2004-06-21  8:01       ` Arjan van de Ven
2004-06-22 10:57         ` Takao Indoh
2004-06-21  8:02       ` Christoph Hellwig
2004-06-11 11:41 ` [PATCH 2/4]Diskdump Update Takao Indoh
2004-06-17 12:49   ` Christoph Hellwig
2004-06-17 13:21     ` Takao Indoh
2004-06-17 13:39       ` Christoph Hellwig
2004-06-22 12:01         ` Takao Indoh
2004-06-22 12:12           ` Christoph Hellwig
2004-06-23  1:47             ` Takao Indoh
2004-06-11 11:42 ` [PATCH 3/4]Diskdump Update Takao Indoh
2004-06-11 11:43 ` [PATCH 4/4]Diskdump Update Takao Indoh
2004-06-14 14:20 ` [PATCH 0/4]Diskdump Update Takao Indoh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.