From: Sean Christopherson <seanjc@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: kvm@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Will Deacon <will@kernel.org>,
kvmarm@lists.linux.dev, Ben Gardon <bgardon@google.com>,
David Matlack <dmatlack@google.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 15/15] KVM: arm64: Handle stage-2 faults in parallel
Date: Wed, 19 Oct 2022 23:32:36 +0000 [thread overview]
Message-ID: <Y1CJFLVnnbX4Ck85@google.com> (raw)
In-Reply-To: <20221007233253.460257-1-oliver.upton@linux.dev>
On Fri, Oct 07, 2022, Oliver Upton wrote:
> @@ -1534,7 +1517,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
> */
> kvm_pgtable_stage2_map(kvm->arch.mmu.pgt, range->start << PAGE_SHIFT,
> PAGE_SIZE, __pfn_to_phys(pfn),
> - KVM_PGTABLE_PROT_R, NULL);
> + KVM_PGTABLE_PROT_R, NULL, KVM_PGTABLE_WALK_SHARED);
All MMU notifier events acquire mmu_lock for write when invoking arch code, i.e.
this isn't a shared walk.
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Reiji Watanabe <reijiw@google.com>,
Ricardo Koller <ricarkol@google.com>,
David Matlack <dmatlack@google.com>,
Quentin Perret <qperret@google.com>,
Ben Gardon <bgardon@google.com>, Gavin Shan <gshan@redhat.com>,
Peter Xu <peterx@redhat.com>, Will Deacon <will@kernel.org>,
kvmarm@lists.linux.dev
Subject: Re: [PATCH v2 15/15] KVM: arm64: Handle stage-2 faults in parallel
Date: Wed, 19 Oct 2022 23:32:36 +0000 [thread overview]
Message-ID: <Y1CJFLVnnbX4Ck85@google.com> (raw)
Message-ID: <20221019233236.ojpmSPkXFCxsYzQm5U_1sfjhtk7xps7Jy1WZKOoh2r0@z> (raw)
In-Reply-To: <20221007233253.460257-1-oliver.upton@linux.dev>
On Fri, Oct 07, 2022, Oliver Upton wrote:
> @@ -1534,7 +1517,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
> */
> kvm_pgtable_stage2_map(kvm->arch.mmu.pgt, range->start << PAGE_SHIFT,
> PAGE_SIZE, __pfn_to_phys(pfn),
> - KVM_PGTABLE_PROT_R, NULL);
> + KVM_PGTABLE_PROT_R, NULL, KVM_PGTABLE_WALK_SHARED);
All MMU notifier events acquire mmu_lock for write when invoking arch code, i.e.
this isn't a shared walk.
WARNING: multiple messages have this Message-ID (diff)
From: Sean Christopherson <seanjc@google.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: Marc Zyngier <maz@kernel.org>, James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
Reiji Watanabe <reijiw@google.com>,
Ricardo Koller <ricarkol@google.com>,
David Matlack <dmatlack@google.com>,
Quentin Perret <qperret@google.com>,
Ben Gardon <bgardon@google.com>, Gavin Shan <gshan@redhat.com>,
Peter Xu <peterx@redhat.com>, Will Deacon <will@kernel.org>,
kvmarm@lists.linux.dev
Subject: Re: [PATCH v2 15/15] KVM: arm64: Handle stage-2 faults in parallel
Date: Wed, 19 Oct 2022 23:32:36 +0000 [thread overview]
Message-ID: <Y1CJFLVnnbX4Ck85@google.com> (raw)
In-Reply-To: <20221007233253.460257-1-oliver.upton@linux.dev>
On Fri, Oct 07, 2022, Oliver Upton wrote:
> @@ -1534,7 +1517,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range)
> */
> kvm_pgtable_stage2_map(kvm->arch.mmu.pgt, range->start << PAGE_SHIFT,
> PAGE_SIZE, __pfn_to_phys(pfn),
> - KVM_PGTABLE_PROT_R, NULL);
> + KVM_PGTABLE_PROT_R, NULL, KVM_PGTABLE_WALK_SHARED);
All MMU notifier events acquire mmu_lock for write when invoking arch code, i.e.
this isn't a shared walk.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-19 23:32 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 23:28 [PATCH v2 00/15] KVM: arm64: Parallel stage-2 fault handling Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 01/15] KVM: arm64: Combine visitor arguments into a context structure Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 02/15] KVM: arm64: Stash observed pte value in visitor context Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 03/15] KVM: arm64: Pass mm_ops through the " Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 04/15] KVM: arm64: Don't pass kvm_pgtable through kvm_pgtable_walk_data Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 05/15] KVM: arm64: Add a helper to tear down unlinked stage-2 subtrees Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 06/15] KVM: arm64: Tear down unlinked stage-2 subtree after break-before-make Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-28 18:41 ` Ricardo Koller
2022-10-28 18:41 ` Ricardo Koller
2022-10-28 18:41 ` Ricardo Koller
2022-10-28 18:43 ` Ricardo Koller
2022-10-28 18:43 ` Ricardo Koller
2022-10-28 18:43 ` Ricardo Koller
2022-10-28 18:53 ` Ricardo Koller
2022-10-28 18:53 ` Ricardo Koller
2022-10-28 18:53 ` Ricardo Koller
2022-10-07 23:28 ` [PATCH v2 07/15] KVM: arm64: Use an opaque type for pteps Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-19 23:17 ` Sean Christopherson
2022-10-19 23:17 ` Sean Christopherson
2022-10-19 23:17 ` Sean Christopherson
2022-10-20 8:32 ` Oliver Upton
2022-10-20 8:32 ` Oliver Upton
2022-10-20 8:32 ` Oliver Upton
2022-10-27 22:31 ` Oliver Upton
2022-10-27 22:31 ` Oliver Upton
2022-10-27 22:31 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 08/15] KVM: arm64: Protect stage-2 traversal with RCU Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-19 23:29 ` Sean Christopherson
2022-10-19 23:29 ` Sean Christopherson
2022-10-19 23:29 ` Sean Christopherson
2022-10-20 8:34 ` Oliver Upton
2022-10-20 8:34 ` Oliver Upton
2022-10-20 8:34 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 09/15] KVM: arm64: Free removed stage-2 tables in RCU callback Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` [PATCH v2 10/15] KVM: arm64: Atomically update stage 2 leaf attributes in parallel walks Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:28 ` Oliver Upton
2022-10-07 23:30 ` [PATCH v2 11/15] KVM: arm64: Split init and set for table PTE Oliver Upton
2022-10-07 23:30 ` Oliver Upton
2022-10-07 23:30 ` Oliver Upton
2022-10-07 23:31 ` [PATCH v2 12/15] KVM: arm64: Make block->table PTE changes parallel-aware Oliver Upton
2022-10-07 23:31 ` Oliver Upton
2022-10-07 23:31 ` Oliver Upton
2022-10-07 23:32 ` [PATCH v2 13/15] KVM: arm64: Make leaf->leaf " Oliver Upton
2022-10-07 23:32 ` Oliver Upton
2022-10-07 23:32 ` Oliver Upton
2022-10-07 23:32 ` [PATCH v2 14/15] KVM: arm64: Make table->block " Oliver Upton
2022-10-07 23:32 ` Oliver Upton
2022-10-07 23:32 ` Oliver Upton
2022-10-07 23:32 ` [PATCH v2 15/15] KVM: arm64: Handle stage-2 faults in parallel Oliver Upton
2022-10-07 23:32 ` Oliver Upton
2022-10-07 23:32 ` Oliver Upton
2022-10-08 3:01 ` kernel test robot
2022-10-08 3:01 ` kernel test robot
2022-10-08 3:14 ` Oliver Upton
2022-10-08 3:14 ` Oliver Upton
2022-10-08 3:14 ` Oliver Upton
2022-10-08 3:14 ` Oliver Upton
2022-10-19 23:32 ` Sean Christopherson [this message]
2022-10-19 23:32 ` Sean Christopherson
2022-10-19 23:32 ` Sean Christopherson
2022-10-20 8:35 ` Oliver Upton
2022-10-20 8:35 ` Oliver Upton
2022-10-20 8:35 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1CJFLVnnbX4Ck85@google.com \
--to=seanjc@google.com \
--cc=bgardon@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.