From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: alsa-devel@alsa-project.org, Nicolas Chauvet <kwizart@gmail.com>,
linux-kernel@vger.kernel.org, Sameer Pujar <spujar@nvidia.com>,
Takashi Iwai <tiwai@suse.com>, Peter Geis <pgwipeout@gmail.com>,
linux-tegra@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v1 3/5] ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive()
Date: Fri, 15 Jan 2021 16:37:59 +0100 [thread overview]
Message-ID: <YAG211gFXExjp7Zh@ulmo> (raw)
In-Reply-To: <20210112125834.21545-4-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Tue, Jan 12, 2021 at 03:58:32PM +0300, Dmitry Osipenko wrote:
> Some of resets are erroneously missed in the configlink_mods[], like APBIF
> for example. Use of_reset_control_array_get_exclusive() which requests all
> the resets. The problem was hidden by the clk driver which implicitly
> de-asserts the missing resets.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> sound/soc/tegra/tegra30_ahub.c | 66 +++++-----------------------------
> sound/soc/tegra/tegra30_ahub.h | 1 -
> 2 files changed, 9 insertions(+), 58 deletions(-)
Doing it this way is slightly suboptimal because now we don't actually
have a way of checking that the DT has all the necessary resets listed.
Can we not just make the list complete instead to keep the checks in
place? That should be a much smaller patch, too.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Sameer Pujar <spujar@nvidia.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/5] ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive()
Date: Fri, 15 Jan 2021 16:37:59 +0100 [thread overview]
Message-ID: <YAG211gFXExjp7Zh@ulmo> (raw)
In-Reply-To: <20210112125834.21545-4-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Tue, Jan 12, 2021 at 03:58:32PM +0300, Dmitry Osipenko wrote:
> Some of resets are erroneously missed in the configlink_mods[], like APBIF
> for example. Use of_reset_control_array_get_exclusive() which requests all
> the resets. The problem was hidden by the clk driver which implicitly
> de-asserts the missing resets.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> sound/soc/tegra/tegra30_ahub.c | 66 +++++-----------------------------
> sound/soc/tegra/tegra30_ahub.h | 1 -
> 2 files changed, 9 insertions(+), 58 deletions(-)
Doing it this way is slightly suboptimal because now we don't actually
have a way of checking that the DT has all the necessary resets listed.
Can we not just make the list complete instead to keep the checks in
place? That should be a much smaller patch, too.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-15 15:39 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 12:58 [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-12 12:58 ` [PATCH v1 1/5] ALSA: hda/tegra: Use clk_bulk helpers Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:22 ` Thierry Reding
2021-01-15 15:22 ` Thierry Reding
2021-01-17 23:31 ` Dmitry Osipenko
2021-01-17 23:31 ` Dmitry Osipenko
2021-01-19 17:31 ` Thierry Reding
2021-01-19 17:31 ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 2/5] ALSA: hda/tegra: Reset hardware Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:35 ` Thierry Reding
2021-01-15 15:35 ` Thierry Reding
2021-01-17 23:39 ` Dmitry Osipenko
2021-01-17 23:39 ` Dmitry Osipenko
2021-01-19 17:30 ` Thierry Reding
2021-01-19 17:30 ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 3/5] ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive() Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:37 ` Thierry Reding [this message]
2021-01-15 15:37 ` Thierry Reding
2021-01-17 23:57 ` Dmitry Osipenko
2021-01-17 23:57 ` Dmitry Osipenko
2021-01-12 12:58 ` [PATCH v1 4/5] ASoC: tegra: ahub: Use clk_bulk helpers Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:38 ` Thierry Reding
2021-01-15 15:38 ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 5/5] ASoC: tegra: ahub: Reset hardware properly Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 13:02 ` Dmitry Osipenko
2021-01-15 13:02 ` Dmitry Osipenko
2021-01-15 15:44 ` Thierry Reding
2021-01-15 15:44 ` Thierry Reding
2021-01-18 0:02 ` Dmitry Osipenko
2021-01-18 0:02 ` Dmitry Osipenko
2021-01-19 17:34 ` Thierry Reding
2021-01-19 17:34 ` Thierry Reding
2021-01-15 10:18 ` [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers Takashi Iwai
2021-01-15 10:18 ` Takashi Iwai
2021-01-15 10:52 ` Ben Dooks
2021-01-15 10:52 ` Ben Dooks
2021-01-15 12:59 ` Dmitry Osipenko
2021-01-15 12:59 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YAG211gFXExjp7Zh@ulmo \
--to=thierry.reding@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pgwipeout@gmail.com \
--cc=spujar@nvidia.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.