All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: alsa-devel@alsa-project.org, Nicolas Chauvet <kwizart@gmail.com>,
	linux-kernel@vger.kernel.org, Sameer Pujar <spujar@nvidia.com>,
	Takashi Iwai <tiwai@suse.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Peter Geis <pgwipeout@gmail.com>,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers
Date: Fri, 15 Jan 2021 11:18:45 +0100	[thread overview]
Message-ID: <s5heeimmrju.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210112125834.21545-1-digetx@gmail.com>

On Tue, 12 Jan 2021 13:58:29 +0100,
Dmitry Osipenko wrote:
> 
> This series improves the handling of clock and reset controls of
> NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling
> resets properly, which needs to be fixed in order to unblock other patches
> related to fixes on the reset controller driver since HDA/AHUB are bound
> to fail once reset controller driver will be corrected. In particular ALSA
> drivers are relying on implicit de-assertion of resets which is done by the
> tegra-clk driver. It's not the business of the clk driver to touch resets
> and we need to fix this because it breaks reset/clk programming sequences
> of other Tegra drivers.
> 
> Dmitry Osipenko (5):
>   ALSA: hda/tegra: Use clk_bulk helpers
>   ALSA: hda/tegra: Reset hardware
>   ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive()
>   ASoC: tegra: ahub: Use clk_bulk helpers
>   ASoC: tegra: ahub: Reset hardware properly

Thierry, Jonathan, Sameer, could you guys check those please?


thanks,

Takashi

> 
>  sound/pci/hda/hda_tegra.c      |  86 +++++++++------------------
>  sound/soc/tegra/tegra30_ahub.c | 103 ++++++---------------------------
>  sound/soc/tegra/tegra30_ahub.h |   6 +-
>  3 files changed, 49 insertions(+), 146 deletions(-)
> 
> -- 
> 2.29.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Sameer Pujar <spujar@nvidia.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Nicolas Chauvet <kwizart@gmail.com>,
	Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers
Date: Fri, 15 Jan 2021 11:18:45 +0100	[thread overview]
Message-ID: <s5heeimmrju.wl-tiwai@suse.de> (raw)
In-Reply-To: <20210112125834.21545-1-digetx@gmail.com>

On Tue, 12 Jan 2021 13:58:29 +0100,
Dmitry Osipenko wrote:
> 
> This series improves the handling of clock and reset controls of
> NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling
> resets properly, which needs to be fixed in order to unblock other patches
> related to fixes on the reset controller driver since HDA/AHUB are bound
> to fail once reset controller driver will be corrected. In particular ALSA
> drivers are relying on implicit de-assertion of resets which is done by the
> tegra-clk driver. It's not the business of the clk driver to touch resets
> and we need to fix this because it breaks reset/clk programming sequences
> of other Tegra drivers.
> 
> Dmitry Osipenko (5):
>   ALSA: hda/tegra: Use clk_bulk helpers
>   ALSA: hda/tegra: Reset hardware
>   ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive()
>   ASoC: tegra: ahub: Use clk_bulk helpers
>   ASoC: tegra: ahub: Reset hardware properly

Thierry, Jonathan, Sameer, could you guys check those please?


thanks,

Takashi

> 
>  sound/pci/hda/hda_tegra.c      |  86 +++++++++------------------
>  sound/soc/tegra/tegra30_ahub.c | 103 ++++++---------------------------
>  sound/soc/tegra/tegra30_ahub.h |   6 +-
>  3 files changed, 49 insertions(+), 146 deletions(-)
> 
> -- 
> 2.29.2
> 

  parent reply	other threads:[~2021-01-15 10:19 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12 12:58 [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-12 12:58 ` [PATCH v1 1/5] ALSA: hda/tegra: Use clk_bulk helpers Dmitry Osipenko
2021-01-12 12:58   ` Dmitry Osipenko
2021-01-15 15:22   ` Thierry Reding
2021-01-15 15:22     ` Thierry Reding
2021-01-17 23:31     ` Dmitry Osipenko
2021-01-17 23:31       ` Dmitry Osipenko
2021-01-19 17:31       ` Thierry Reding
2021-01-19 17:31         ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 2/5] ALSA: hda/tegra: Reset hardware Dmitry Osipenko
2021-01-12 12:58   ` Dmitry Osipenko
2021-01-15 15:35   ` Thierry Reding
2021-01-15 15:35     ` Thierry Reding
2021-01-17 23:39     ` Dmitry Osipenko
2021-01-17 23:39       ` Dmitry Osipenko
2021-01-19 17:30       ` Thierry Reding
2021-01-19 17:30         ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 3/5] ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive() Dmitry Osipenko
2021-01-12 12:58   ` Dmitry Osipenko
2021-01-15 15:37   ` Thierry Reding
2021-01-15 15:37     ` Thierry Reding
2021-01-17 23:57     ` Dmitry Osipenko
2021-01-17 23:57       ` Dmitry Osipenko
2021-01-12 12:58 ` [PATCH v1 4/5] ASoC: tegra: ahub: Use clk_bulk helpers Dmitry Osipenko
2021-01-12 12:58   ` Dmitry Osipenko
2021-01-15 15:38   ` Thierry Reding
2021-01-15 15:38     ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 5/5] ASoC: tegra: ahub: Reset hardware properly Dmitry Osipenko
2021-01-12 12:58   ` Dmitry Osipenko
2021-01-15 13:02   ` Dmitry Osipenko
2021-01-15 13:02     ` Dmitry Osipenko
2021-01-15 15:44   ` Thierry Reding
2021-01-15 15:44     ` Thierry Reding
2021-01-18  0:02     ` Dmitry Osipenko
2021-01-18  0:02       ` Dmitry Osipenko
2021-01-19 17:34       ` Thierry Reding
2021-01-19 17:34         ` Thierry Reding
2021-01-15 10:18 ` Takashi Iwai [this message]
2021-01-15 10:18   ` [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers Takashi Iwai
2021-01-15 10:52 ` Ben Dooks
2021-01-15 10:52   ` Ben Dooks
2021-01-15 12:59   ` Dmitry Osipenko
2021-01-15 12:59     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5heeimmrju.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kwizart@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pgwipeout@gmail.com \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.