From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: alsa-devel@alsa-project.org, Nicolas Chauvet <kwizart@gmail.com>,
linux-kernel@vger.kernel.org, Sameer Pujar <spujar@nvidia.com>,
Takashi Iwai <tiwai@suse.com>, Peter Geis <pgwipeout@gmail.com>,
linux-tegra@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v1 1/5] ALSA: hda/tegra: Use clk_bulk helpers
Date: Mon, 18 Jan 2021 02:31:35 +0300 [thread overview]
Message-ID: <b84c6d9f-e113-e249-cd76-248e2cd646ff@gmail.com> (raw)
In-Reply-To: <YAGzJM7BJqLV0xxY@ulmo>
15.01.2021 18:22, Thierry Reding пишет:
...
>> static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
>> {
>> struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip);
>> @@ -495,7 +441,11 @@ static int hda_tegra_probe(struct platform_device *pdev)
>> return err;
>> }
>>
>> - err = hda_tegra_init_clk(hda);
>> + hda->clocks[hda->nclocks++].id = "hda";
>> + hda->clocks[hda->nclocks++].id = "hda2hdmi";
>> + hda->clocks[hda->nclocks++].id = "hda2codec_2x";
>
> Originally the code did this in this order: "hda", "hda2codec_2x" and
> "hda2hdmi". I don't expect the exact order to be very relevant, but was
> there any particular reason to change it?
The reason was "to make code look nicer". This was a conscious decision
since indeed the clocks order shouldn't matter for this driver.
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Sameer Pujar <spujar@nvidia.com>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/5] ALSA: hda/tegra: Use clk_bulk helpers
Date: Mon, 18 Jan 2021 02:31:35 +0300 [thread overview]
Message-ID: <b84c6d9f-e113-e249-cd76-248e2cd646ff@gmail.com> (raw)
In-Reply-To: <YAGzJM7BJqLV0xxY@ulmo>
15.01.2021 18:22, Thierry Reding пишет:
...
>> static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
>> {
>> struct hda_tegra *hda = container_of(chip, struct hda_tegra, chip);
>> @@ -495,7 +441,11 @@ static int hda_tegra_probe(struct platform_device *pdev)
>> return err;
>> }
>>
>> - err = hda_tegra_init_clk(hda);
>> + hda->clocks[hda->nclocks++].id = "hda";
>> + hda->clocks[hda->nclocks++].id = "hda2hdmi";
>> + hda->clocks[hda->nclocks++].id = "hda2codec_2x";
>
> Originally the code did this in this order: "hda", "hda2codec_2x" and
> "hda2hdmi". I don't expect the exact order to be very relevant, but was
> there any particular reason to change it?
The reason was "to make code look nicer". This was a conscious decision
since indeed the clocks order shouldn't matter for this driver.
next prev parent reply other threads:[~2021-01-17 23:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 12:58 [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-12 12:58 ` [PATCH v1 1/5] ALSA: hda/tegra: Use clk_bulk helpers Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:22 ` Thierry Reding
2021-01-15 15:22 ` Thierry Reding
2021-01-17 23:31 ` Dmitry Osipenko [this message]
2021-01-17 23:31 ` Dmitry Osipenko
2021-01-19 17:31 ` Thierry Reding
2021-01-19 17:31 ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 2/5] ALSA: hda/tegra: Reset hardware Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:35 ` Thierry Reding
2021-01-15 15:35 ` Thierry Reding
2021-01-17 23:39 ` Dmitry Osipenko
2021-01-17 23:39 ` Dmitry Osipenko
2021-01-19 17:30 ` Thierry Reding
2021-01-19 17:30 ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 3/5] ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive() Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:37 ` Thierry Reding
2021-01-15 15:37 ` Thierry Reding
2021-01-17 23:57 ` Dmitry Osipenko
2021-01-17 23:57 ` Dmitry Osipenko
2021-01-12 12:58 ` [PATCH v1 4/5] ASoC: tegra: ahub: Use clk_bulk helpers Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 15:38 ` Thierry Reding
2021-01-15 15:38 ` Thierry Reding
2021-01-12 12:58 ` [PATCH v1 5/5] ASoC: tegra: ahub: Reset hardware properly Dmitry Osipenko
2021-01-12 12:58 ` Dmitry Osipenko
2021-01-15 13:02 ` Dmitry Osipenko
2021-01-15 13:02 ` Dmitry Osipenko
2021-01-15 15:44 ` Thierry Reding
2021-01-15 15:44 ` Thierry Reding
2021-01-18 0:02 ` Dmitry Osipenko
2021-01-18 0:02 ` Dmitry Osipenko
2021-01-19 17:34 ` Thierry Reding
2021-01-19 17:34 ` Thierry Reding
2021-01-15 10:18 ` [PATCH v1 0/5] Clock and reset improvements for Tegra ALSA drivers Takashi Iwai
2021-01-15 10:18 ` Takashi Iwai
2021-01-15 10:52 ` Ben Dooks
2021-01-15 10:52 ` Ben Dooks
2021-01-15 12:59 ` Dmitry Osipenko
2021-01-15 12:59 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b84c6d9f-e113-e249-cd76-248e2cd646ff@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pgwipeout@gmail.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.