[PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

[PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

[ua1422]

From: Usman Ansari <ua1422@gmail.com>

Signed-off-by: Usman Ansari <ua1422@gmail.com>
Description: Address the following checkpatch warning:

WARNING: Commit log lines starting with '#' are dropped by git as comments
---
 drivers/staging/wlan-ng/cfg80211.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 7951bd63816f..f03dc1e59db1 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
 /* cfg80211 Interface for prism2_usb module */
-#include "hfa384x.h"
-#include "prism2mgmt.h"
+ #include "hfa384x.h"
+ #include "prism2mgmt.h"
 
 /* Prism2 channel/frequency/bitrate declarations */
 static const struct ieee80211_channel prism2_channels[] = {
@@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
 	{ .bitrate = 110 }
 };
 
-#define PRISM2_NUM_CIPHER_SUITES 2
+ #define PRISM2_NUM_CIPHER_SUITES 2
 static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
 	WLAN_CIPHER_SUITE_WEP40,
 	WLAN_CIPHER_SUITE_WEP104
-- 
2.25.1

Re: [PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

[Greg KH]

On Fri, Sep 17, 2021 at 11:25:42AM -0700, ua1422@gmail.com wrote:
> From: Usman Ansari <ua1422@gmail.com>
> 
> Signed-off-by: Usman Ansari <ua1422@gmail.com>
> Description: Address the following checkpatch warning:
> 
> WARNING: Commit log lines starting with '#' are dropped by git as comments
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index 7951bd63816f..f03dc1e59db1 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -1,7 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /* cfg80211 Interface for prism2_usb module */
> -#include "hfa384x.h"
> -#include "prism2mgmt.h"
> + #include "hfa384x.h"
> + #include "prism2mgmt.h"
>  
>  /* Prism2 channel/frequency/bitrate declarations */
>  static const struct ieee80211_channel prism2_channels[] = {
> @@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
>  	{ .bitrate = 110 }
>  };
>  
> -#define PRISM2_NUM_CIPHER_SUITES 2
> + #define PRISM2_NUM_CIPHER_SUITES 2
>  static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
>  	WLAN_CIPHER_SUITE_WEP40,
>  	WLAN_CIPHER_SUITE_WEP104
> -- 
> 2.25.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

[Greg KH]

On Sat, Sep 18, 2021 at 11:29:42AM -0700, Usman S. Ansari wrote:
> On Fri, Sep 17, 2021 at 11:53 PM Greg KH <greg@kroah.com> wrote:
> 
> > On Fri, Sep 17, 2021 at 11:25:42AM -0700, ua1422@gmail.com wrote:
> > > From: Usman Ansari <ua1422@gmail.com>
> > >
> > > Signed-off-by: Usman Ansari <ua1422@gmail.com>
> > > Description: Address the following checkpatch warning:
> > >
> > > WARNING: Commit log lines starting with '#' are dropped by git as
> > comments
> > > ---
> > >  drivers/staging/wlan-ng/cfg80211.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/staging/wlan-ng/cfg80211.c
> > b/drivers/staging/wlan-ng/cfg80211.c
> > > index 7951bd63816f..f03dc1e59db1 100644
> > > --- a/drivers/staging/wlan-ng/cfg80211.c
> > > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > > @@ -1,7 +1,7 @@
> > >  // SPDX-License-Identifier: GPL-2.0
> > >  /* cfg80211 Interface for prism2_usb module */
> > > -#include "hfa384x.h"
> > > -#include "prism2mgmt.h"
> > > + #include "hfa384x.h"
> > > + #include "prism2mgmt.h"
> > >
> > >  /* Prism2 channel/frequency/bitrate declarations */
> > >  static const struct ieee80211_channel prism2_channels[] = {
> > > @@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
> > >       { .bitrate = 110 }
> > >  };
> > >
> > > -#define PRISM2_NUM_CIPHER_SUITES 2
> > > + #define PRISM2_NUM_CIPHER_SUITES 2
> > >  static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
> > >       WLAN_CIPHER_SUITE_WEP40,
> > >       WLAN_CIPHER_SUITE_WEP104
> > > --
> > > 2.25.1
> > >
> >
> > Hi,
> >
> > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > a patch that has triggered this response.  He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created.  Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> >
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> >
> > - Your patch does not have a Signed-off-by: line.  Please read the
> >   kernel file, Documentation/SubmittingPatches and resend it after
> >   adding that line.  Note, the line needs to be in the body of the
> >   email, before the patch, not at the bottom of the patch or in the
> >   email signature.
> >
> > - You did not specify a description of why the patch is needed, or
> >   possibly, any description at all, in the email body.  Please read the
> >   section entitled "The canonical patch format" in the kernel file,
> >   Documentation/SubmittingPatches for what is needed in order to
> >   properly describe the change.
> >
> > - You did not write a descriptive Subject: for the patch, allowing Greg,
> >   and everyone else, to know what this patch is all about.  Please read
> >   the section entitled "The canonical patch format" in the kernel file,
> >   Documentation/SubmittingPatches for what a proper Subject: line should
> >   look like.
> >
> > If you wish to discuss this problem further, or you have questions about
> > how to resolve this issue, please feel free to respond to this email and
> > Greg will reply once he has dug out from the pending patches received
> > from other developers.
> >
> > thanks,
> >
> > greg k-h's patch email bot
> >
> 
> Hi Greg,
> 
> I think I have covered all the items listed in your email bot reply. Please
> let me know if the patch is not meeting the expectations.

It is not, sorry.  Please read the documentation.

Also look at your patch itself, it is not correct.

good luck!

greg k-h

Re: [PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

[Usman S. Ansari]

On Sat, Sep 18, 2021 at 11:38 PM Greg KH <greg@kroah.com> wrote:
>
> On Sat, Sep 18, 2021 at 11:29:42AM -0700, Usman S. Ansari wrote:
> > On Fri, Sep 17, 2021 at 11:53 PM Greg KH <greg@kroah.com> wrote:
> >
> > > On Fri, Sep 17, 2021 at 11:25:42AM -0700, ua1422@gmail.com wrote:
> > > > From: Usman Ansari <ua1422@gmail.com>
> > > >
> > > > Signed-off-by: Usman Ansari <ua1422@gmail.com>
> > > > Description: Address the following checkpatch warning:
> > > >
> > > > WARNING: Commit log lines starting with '#' are dropped by git as
> > > comments
> > > > ---
> > > >  drivers/staging/wlan-ng/cfg80211.c | 6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/wlan-ng/cfg80211.c
> > > b/drivers/staging/wlan-ng/cfg80211.c
> > > > index 7951bd63816f..f03dc1e59db1 100644
> > > > --- a/drivers/staging/wlan-ng/cfg80211.c
> > > > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > > > @@ -1,7 +1,7 @@
> > > >  // SPDX-License-Identifier: GPL-2.0
> > > >  /* cfg80211 Interface for prism2_usb module */
> > > > -#include "hfa384x.h"
> > > > -#include "prism2mgmt.h"
> > > > + #include "hfa384x.h"
> > > > + #include "prism2mgmt.h"
> > > >
> > > >  /* Prism2 channel/frequency/bitrate declarations */
> > > >  static const struct ieee80211_channel prism2_channels[] = {
> > > > @@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
> > > >       { .bitrate = 110 }
> > > >  };
> > > >
> > > > -#define PRISM2_NUM_CIPHER_SUITES 2
> > > > + #define PRISM2_NUM_CIPHER_SUITES 2
> > > >  static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
> > > >       WLAN_CIPHER_SUITE_WEP40,
> > > >       WLAN_CIPHER_SUITE_WEP104
> > > > --
> > > > 2.25.1
> > > >
> > >
> > > Hi,
> > >
> > > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > > a patch that has triggered this response.  He used to manually respond
> > > to these common problems, but in order to save his sanity (he kept
> > > writing the same thing over and over, yet to different people), I was
> > > created.  Hopefully you will not take offence and will fix the problem
> > > in your patch and resubmit it so that it can be accepted into the Linux
> > > kernel tree.
> > >
> > > You are receiving this message because of the following common error(s)
> > > as indicated below:
> > >
> > > - Your patch does not have a Signed-off-by: line.  Please read the
> > >   kernel file, Documentation/SubmittingPatches and resend it after
> > >   adding that line.  Note, the line needs to be in the body of the
> > >   email, before the patch, not at the bottom of the patch or in the
> > >   email signature.
> > >
> > > - You did not specify a description of why the patch is needed, or
> > >   possibly, any description at all, in the email body.  Please read the
> > >   section entitled "The canonical patch format" in the kernel file,
> > >   Documentation/SubmittingPatches for what is needed in order to
> > >   properly describe the change.
> > >
> > > - You did not write a descriptive Subject: for the patch, allowing Greg,
> > >   and everyone else, to know what this patch is all about.  Please read
> > >   the section entitled "The canonical patch format" in the kernel file,
> > >   Documentation/SubmittingPatches for what a proper Subject: line should
> > >   look like.
> > >
> > > If you wish to discuss this problem further, or you have questions about
> > > how to resolve this issue, please feel free to respond to this email and
> > > Greg will reply once he has dug out from the pending patches received
> > > from other developers.
> > >
> > > thanks,
> > >
> > > greg k-h's patch email bot
> > >
> >
> > Hi Greg,
> >
> > I think I have covered all the items listed in your email bot reply. Please
> > let me know if the patch is not meeting the expectations.
>
> It is not, sorry.  Please read the documentation.

This is more for learning and not arguing:
- I do have signed-off in my patch
- I do have a Description of the patch
- I do have a subject describing the patch

Anyone, please let me know, what are the expectations not fulfilled?

> Also look at your patch itself, it is not correct.

Please let me know what is not correct, I tried to follow the patch guidance.

> good luck!

Thanks for your guidance in advance.

> greg k-h

Re: [PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl

[Greg KH]

On Tue, Sep 21, 2021 at 07:56:10PM -0700, Usman S. Ansari wrote:
> On Sat, Sep 18, 2021 at 11:38 PM Greg KH <greg@kroah.com> wrote:
> >
> > On Sat, Sep 18, 2021 at 11:29:42AM -0700, Usman S. Ansari wrote:
> > > On Fri, Sep 17, 2021 at 11:53 PM Greg KH <greg@kroah.com> wrote:
> > >
> > > > On Fri, Sep 17, 2021 at 11:25:42AM -0700, ua1422@gmail.com wrote:
> > > > > From: Usman Ansari <ua1422@gmail.com>
> > > > >
> > > > > Signed-off-by: Usman Ansari <ua1422@gmail.com>
> > > > > Description: Address the following checkpatch warning:
> > > > >
> > > > > WARNING: Commit log lines starting with '#' are dropped by git as
> > > > comments
> > > > > ---
> > > > >  drivers/staging/wlan-ng/cfg80211.c | 6 +++---
> > > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > >
> > > > > diff --git a/drivers/staging/wlan-ng/cfg80211.c
> > > > b/drivers/staging/wlan-ng/cfg80211.c
> > > > > index 7951bd63816f..f03dc1e59db1 100644
> > > > > --- a/drivers/staging/wlan-ng/cfg80211.c
> > > > > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > > > > @@ -1,7 +1,7 @@
> > > > >  // SPDX-License-Identifier: GPL-2.0
> > > > >  /* cfg80211 Interface for prism2_usb module */
> > > > > -#include "hfa384x.h"
> > > > > -#include "prism2mgmt.h"
> > > > > + #include "hfa384x.h"
> > > > > + #include "prism2mgmt.h"
> > > > >
> > > > >  /* Prism2 channel/frequency/bitrate declarations */
> > > > >  static const struct ieee80211_channel prism2_channels[] = {
> > > > > @@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = {
> > > > >       { .bitrate = 110 }
> > > > >  };
> > > > >
> > > > > -#define PRISM2_NUM_CIPHER_SUITES 2
> > > > > + #define PRISM2_NUM_CIPHER_SUITES 2
> > > > >  static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = {
> > > > >       WLAN_CIPHER_SUITE_WEP40,
> > > > >       WLAN_CIPHER_SUITE_WEP104
> > > > > --
> > > > > 2.25.1
> > > > >
> > > >
> > > > Hi,
> > > >
> > > > This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> > > > a patch that has triggered this response.  He used to manually respond
> > > > to these common problems, but in order to save his sanity (he kept
> > > > writing the same thing over and over, yet to different people), I was
> > > > created.  Hopefully you will not take offence and will fix the problem
> > > > in your patch and resubmit it so that it can be accepted into the Linux
> > > > kernel tree.
> > > >
> > > > You are receiving this message because of the following common error(s)
> > > > as indicated below:
> > > >
> > > > - Your patch does not have a Signed-off-by: line.  Please read the
> > > >   kernel file, Documentation/SubmittingPatches and resend it after
> > > >   adding that line.  Note, the line needs to be in the body of the
> > > >   email, before the patch, not at the bottom of the patch or in the
> > > >   email signature.
> > > >
> > > > - You did not specify a description of why the patch is needed, or
> > > >   possibly, any description at all, in the email body.  Please read the
> > > >   section entitled "The canonical patch format" in the kernel file,
> > > >   Documentation/SubmittingPatches for what is needed in order to
> > > >   properly describe the change.
> > > >
> > > > - You did not write a descriptive Subject: for the patch, allowing Greg,
> > > >   and everyone else, to know what this patch is all about.  Please read
> > > >   the section entitled "The canonical patch format" in the kernel file,
> > > >   Documentation/SubmittingPatches for what a proper Subject: line should
> > > >   look like.
> > > >
> > > > If you wish to discuss this problem further, or you have questions about
> > > > how to resolve this issue, please feel free to respond to this email and
> > > > Greg will reply once he has dug out from the pending patches received
> > > > from other developers.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h's patch email bot
> > > >
> > >
> > > Hi Greg,
> > >
> > > I think I have covered all the items listed in your email bot reply. Please
> > > let me know if the patch is not meeting the expectations.
> >
> > It is not, sorry.  Please read the documentation.
> 
> This is more for learning and not arguing:
> - I do have signed-off in my patch
> - I do have a Description of the patch
> - I do have a subject describing the patch
> 
> Anyone, please let me know, what are the expectations not fulfilled?

Here is what you have in your changelog, from above:

	From: Usman Ansari <ua1422@gmail.com>

	Signed-off-by: Usman Ansari <ua1422@gmail.com>
	Description: Address the following checkpatch warning:

	WARNING: Commit log lines starting with '#' are dropped by git as
	comments


Now look at any of the thousands of commits in the kernel tree, are they
also in this format?  Or are they in a different format?

Look at the documentation that my bot pointed you at for what the
structure of a changelog comment should be.  Notably look _where_ the
information should be in the changelog commit (top?  middle?  bottom?)
and compare it to what you did here.

Try to rewrite it to match what has been accepted in the past.

hope this helps,

greg k-h