From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
"Andrew Morton"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"Johannes Weiner"
<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
"Michal Hocko" <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
"Peter Zijlstra" <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Vladimir Davydov"
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Waiman Long" <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 3/4] mm/memcg: Add a local_lock_t for IRQ and TASK object.
Date: Tue, 8 Feb 2022 18:17:35 +0100 [thread overview]
Message-ID: <YgKlr+sHZPayWKUP@linutronix.de> (raw)
In-Reply-To: <e068646f-c7f2-5876-8577-6ddf93df07d0-AlSwsSmVLrQ@public.gmane.org>
On 2022-02-03 17:01:41 [+0100], Vlastimil Babka wrote:
> > Let me know if a revert is preferred or you want to keep that so that I
>
> I see that's discussed in the subthread with Michal Hocko, so I would be
> also leaning towards revert unless convincing numbers are provided.
>
> > can prepare the patches accordingly before posting.
>
> An acceptable form of this would have to basically replace the bool
> stock_lock_acquried with two variants of the code paths that rely on it,
> feel free to read though the previous occurence :)
> https://lore.kernel.org/all/CAHk-=wiJLqL2cUhJbvpyPQpkbVOu1rVSzgO2=S2jC55hneLtfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/
I did that locally already. I was referring to the revert.
So repost with bool fixed and the revert will be discussed later or
include the revert at the begin of the series and then rebase these
patches on top of it? I probably don't get to it before FRI so I don't
try to rush anyone here ;)
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vladimir Davydov" <vdavydov.dev@gmail.com>,
"Waiman Long" <longman@redhat.com>
Subject: Re: [PATCH 3/4] mm/memcg: Add a local_lock_t for IRQ and TASK object.
Date: Tue, 8 Feb 2022 18:17:35 +0100 [thread overview]
Message-ID: <YgKlr+sHZPayWKUP@linutronix.de> (raw)
In-Reply-To: <e068646f-c7f2-5876-8577-6ddf93df07d0@suse.cz>
On 2022-02-03 17:01:41 [+0100], Vlastimil Babka wrote:
> > Let me know if a revert is preferred or you want to keep that so that I
>
> I see that's discussed in the subthread with Michal Hocko, so I would be
> also leaning towards revert unless convincing numbers are provided.
>
> > can prepare the patches accordingly before posting.
>
> An acceptable form of this would have to basically replace the bool
> stock_lock_acquried with two variants of the code paths that rely on it,
> feel free to read though the previous occurence :)
> https://lore.kernel.org/all/CAHk-=wiJLqL2cUhJbvpyPQpkbVOu1rVSzgO2=S2jC55hneLtfQ@mail.gmail.com/
I did that locally already. I was referring to the revert.
So repost with bool fixed and the revert will be discussed later or
include the revert at the begin of the series and then rebase these
patches on top of it? I probably don't get to it before FRI so I don't
try to rush anyone here ;)
Sebastian
next prev parent reply other threads:[~2022-02-08 17:17 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 16:43 [PATCH 0/4] mm/memcg: Address PREEMPT_RT problems instead of disabling it Sebastian Andrzej Siewior
2022-01-25 16:43 ` Sebastian Andrzej Siewior
[not found] ` <20220125164337.2071854-1-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-01-25 16:43 ` [PATCH 1/4] mm/memcg: Disable threshold event handlers on PREEMPT_RT Sebastian Andrzej Siewior
2022-01-25 16:43 ` Sebastian Andrzej Siewior
[not found] ` <20220125164337.2071854-2-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-01-26 14:40 ` Michal Hocko
2022-01-26 14:40 ` Michal Hocko
[not found] ` <YfFddqkAhd1YKqX9-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-01-26 14:45 ` Sebastian Andrzej Siewior
2022-01-26 14:45 ` Sebastian Andrzej Siewior
[not found] ` <YfFegDwQSm9v2Qcu-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-01-26 15:04 ` Michal Koutný
2022-01-26 15:04 ` Michal Koutný
[not found] ` <20220126150455.GC2516-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-01-27 13:36 ` Sebastian Andrzej Siewior
2022-01-27 13:36 ` Sebastian Andrzej Siewior
2022-01-26 15:21 ` Michal Hocko
2022-01-26 15:21 ` Michal Hocko
2022-01-25 16:43 ` [PATCH 2/4] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed Sebastian Andrzej Siewior
2022-01-25 16:43 ` Sebastian Andrzej Siewior
[not found] ` <20220125164337.2071854-3-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-01-26 10:06 ` Vlastimil Babka
2022-01-26 10:06 ` Vlastimil Babka
[not found] ` <86eeed07-b7dc-b387-ea4d-1a4a41334fe3-AlSwsSmVLrQ@public.gmane.org>
2022-01-26 11:24 ` Sebastian Andrzej Siewior
2022-01-26 11:24 ` Sebastian Andrzej Siewior
2022-01-26 14:56 ` Michal Hocko
2022-01-26 14:56 ` Michal Hocko
2022-01-25 16:43 ` [PATCH 3/4] mm/memcg: Add a local_lock_t for IRQ and TASK object Sebastian Andrzej Siewior
2022-01-25 16:43 ` Sebastian Andrzej Siewior
[not found] ` <20220125164337.2071854-4-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-01-26 15:20 ` Michal Hocko
2022-01-26 15:20 ` Michal Hocko
[not found] ` <YfFmxH1IXeegNOa9-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-01-27 11:53 ` Sebastian Andrzej Siewior
2022-01-27 11:53 ` Sebastian Andrzej Siewior
[not found] ` <YfKHxKda7bGJmrLJ-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-01 12:04 ` Michal Hocko
2022-02-01 12:04 ` Michal Hocko
[not found] ` <YfkhsiWHzsyQSBfl-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-02-01 12:11 ` Sebastian Andrzej Siewior
2022-02-01 12:11 ` Sebastian Andrzej Siewior
[not found] ` <Yfkjjamj09lZn4sA-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-01 15:29 ` Michal Hocko
2022-02-01 15:29 ` Michal Hocko
[not found] ` <YflR3/RuGjYuQZPH-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-02-03 9:54 ` Sebastian Andrzej Siewior
2022-02-03 9:54 ` Sebastian Andrzej Siewior
[not found] ` <YfumP3u1VCjKHE3b-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-03 10:09 ` Michal Hocko
2022-02-03 10:09 ` Michal Hocko
[not found] ` <Yfup9THPcSIPDSoH-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-02-03 11:09 ` Sebastian Andrzej Siewior
2022-02-03 11:09 ` Sebastian Andrzej Siewior
2022-02-08 17:58 ` Shakeel Butt
2022-02-08 17:58 ` Shakeel Butt
[not found] ` <CALvZod7yovQ5OTWr=k_eiEBVb1LTRvPkbsY8joAtyigQnvBUww-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-02-09 9:17 ` Michal Hocko
2022-02-09 9:17 ` Michal Hocko
2022-01-26 16:57 ` Vlastimil Babka
2022-01-26 16:57 ` Vlastimil Babka
[not found] ` <7f4928b8-16e2-88b3-2688-1519a19653a9-AlSwsSmVLrQ@public.gmane.org>
2022-01-31 15:06 ` Sebastian Andrzej Siewior
2022-01-31 15:06 ` Sebastian Andrzej Siewior
[not found] ` <Yff69slA4UTz5Q1Y-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-03 16:01 ` Vlastimil Babka
2022-02-03 16:01 ` Vlastimil Babka
[not found] ` <e068646f-c7f2-5876-8577-6ddf93df07d0-AlSwsSmVLrQ@public.gmane.org>
2022-02-08 17:17 ` Sebastian Andrzej Siewior [this message]
2022-02-08 17:17 ` Sebastian Andrzej Siewior
[not found] ` <YgKlr+sHZPayWKUP-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-08 17:28 ` Michal Hocko
2022-02-08 17:28 ` Michal Hocko
2022-02-09 1:48 ` [mm/memcg] 86895e1e85: WARNING:possible_circular_locking_dependency_detected kernel test robot
2022-02-09 1:48 ` kernel test robot
2022-01-25 16:43 ` [PATCH 4/4] mm/memcg: Allow the task_obj optimization only on non-PREEMPTIBLE kernels Sebastian Andrzej Siewior
2022-01-25 16:43 ` Sebastian Andrzej Siewior
2022-01-25 23:21 ` [PATCH 0/4] mm/memcg: Address PREEMPT_RT problems instead of disabling it Andrew Morton
2022-01-25 23:21 ` Andrew Morton
[not found] ` <20220125152146.d7e25afe3b8a6807df6fee3f-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2022-01-26 7:30 ` Sebastian Andrzej Siewior
2022-01-26 7:30 ` Sebastian Andrzej Siewior
-- strict thread matches above, loose matches on Subject: below --
2022-07-12 11:22 [PATCH 0/4] Backport MEMCG changes from v5.17 David Oberhollenzer
2022-07-12 11:22 ` [PATCH 3/4] mm/memcg: Add a local_lock_t for IRQ and TASK object David Oberhollenzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgKlr+sHZPayWKUP@linutronix.de \
--to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mkoutny-IBi9RG/b67k@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=vbabka-AlSwsSmVLrQ@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.