All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings
@ 2022-02-08 20:51 ` Julia Lawall
  0 siblings, 0 replies; 23+ messages in thread
From: Julia Lawall @ 2022-02-08 20:51 UTC (permalink / raw)
  To: Amit Kumar Mahapatra, Michal Simek, Sai Krishna Potthuri,
	Tejas Prajapati Rameshchandra, Naga Sureshkumar Relli,
	Shubhrajyoti Datta, Ricardo Ribalda Delgado, Mark Brown
  Cc: linux-spi, linux-arm-kernel, linux-kernel, kbuild-all,
	linux-arm-kernel

From: kernel test robot <lkp@intel.com>

After for_each_available_child_of_node, of_node_put is needed before break
and return.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: 3973536c4560 ("spi: spi-xilinx: Updated axi-qspi controller driver")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/872] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago

 spi-xilinx.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -693,13 +693,16 @@ static int xilinx_spi_probe(struct platf
 		if (startup_block) {
 			ret = of_property_read_u32(nc, "reg",
 						   &cs_num);
-			if (ret < 0)
+			if (ret < 0) {
+				of_node_put(nc);
 				return -EINVAL;
+			}
 		}
 		ret = of_property_read_u32(nc, "spi-rx-bus-width",
 					   &rx_bus_width);
 		if (!ret) {
 			xspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}

^ permalink raw reply	[flat|nested] 23+ messages in thread
* [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings
@ 2022-06-26 14:18 ` Julia Lawall
  0 siblings, 0 replies; 23+ messages in thread
From: Julia Lawall @ 2022-06-26 14:18 UTC (permalink / raw)
  To: Amit Kumar Mahapatra
  Cc: kbuild-all, lkp, linux-arm-kernel, Michal Simek,
	Sai Krishna Potthuri, Tejas Prajapati Rameshchandra,
	Naga Sureshkumar Relli, Shubhrajyoti Datta,
	Ricardo Ribalda Delgado, Mark Brown, linux-spi, linux-arm-kernel,
	linux-kernel

From: kernel test robot <lkp@intel.com>

for_each_available_child_of_node should have of_node_put() before return around line 697.
for_each_available_child_of_node should have of_node_put() before break around line 703.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: 3973536c4560 ("spi: spi-xilinx: Updated axi-qspi controller driver")
CC: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head:   59523b5c4aca0174f1f8cba2a07d3b3328b7c80e
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/1181] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/spi/spi-xilinx.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- a/drivers/spi/spi-xilinx.c
+++ b/drivers/spi/spi-xilinx.c
@@ -693,13 +693,16 @@ static int xilinx_spi_probe(struct platf
 		if (startup_block) {
 			ret = of_property_read_u32(nc, "reg",
 						   &cs_num);
-			if (ret < 0)
+			if (ret < 0) {
+				of_node_put(nc);
 				return -EINVAL;
+			}
 		}
 		ret = of_property_read_u32(nc, "spi-rx-bus-width",
 					   &rx_bus_width);
 		if (!ret) {
 			xspi->rx_bus_width = rx_bus_width;
+			of_node_put(nc);
 			break;
 		}
 	}

^ permalink raw reply	[flat|nested] 23+ messages in thread
* [xilinx-xlnx:xlnx_rebase_v5.15_LTS 861/1181] drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.
@ 2022-06-20 17:25 kernel test robot
  2022-06-20 17:19 ` [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings kernel test robot
  0 siblings, 1 reply; 23+ messages in thread
From: kernel test robot @ 2022-06-20 17:25 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
CC: Tejas Prajapati Rameshchandra <tejaspra@xilinx.com>
CC: Naga Sureshkumar Relli <nagasure@xilinx.com>
CC: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
CC: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head:   59523b5c4aca0174f1f8cba2a07d3b3328b7c80e
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/1181] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 5 days ago
:::::: commit date: 5 months ago
config: i386-randconfig-c001 (https://download.01.org/0day-ci/archive/20220621/202206210106.TM0vtap0-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.
>> drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 703.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 23+ messages in thread
* [xilinx-xlnx:xlnx_rebase_v5.15 861/872] drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.
@ 2022-02-08 11:28 kernel test robot
  2022-02-08 11:23 ` [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings kernel test robot
  0 siblings, 1 reply; 23+ messages in thread
From: kernel test robot @ 2022-02-08 11:28 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Amit Kumar Mahapatra <amit.kumar-mahapatra@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
CC: Tejas Prajapati Rameshchandra <tejaspra@xilinx.com>
CC: Naga Sureshkumar Relli <nagasure@xilinx.com>
CC: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
CC: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   1183ce490adb103e5e569b8ebd74c50c885ddc05
commit: 3973536c456079bf3d09e9a97bf33d29422b183f [861/872] spi: spi-xilinx: Updated axi-qspi controller driver
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago
config: x86_64-randconfig-c002-20220207 (https://download.01.org/0day-ci/archive/20220208/202202081907.UgCHaFan-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697.
>> drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 703.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 23+ messages in thread
end of thread, other threads:[~2022-06-27 12:24 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-08 20:51 [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings Julia Lawall
2022-02-08 20:51 ` Julia Lawall
2022-02-08 20:51 ` Julia Lawall
2022-02-09 10:33 ` Ricardo Ribalda Delgado
2022-02-09 10:33   ` Ricardo Ribalda Delgado
2022-02-09 10:33   ` Ricardo Ribalda Delgado
2022-02-09 13:12   ` Mark Brown
2022-02-09 13:12     ` Mark Brown
2022-02-09 13:12     ` Mark Brown
2022-02-09 13:52     ` Ricardo Ribalda Delgado
2022-02-09 13:52       ` Ricardo Ribalda Delgado
2022-02-09 13:52       ` Ricardo Ribalda Delgado
2022-02-09 13:25 ` Mark Brown
2022-02-09 13:25   ` Mark Brown
2022-02-09 13:25   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2022-06-26 14:18 Julia Lawall
2022-06-26 14:18 ` Julia Lawall
2022-06-26 14:18 ` Julia Lawall
2022-06-27 12:23 ` Mark Brown
2022-06-27 12:23   ` Mark Brown
2022-06-27 12:23   ` Mark Brown
2022-06-20 17:25 [xilinx-xlnx:xlnx_rebase_v5.15_LTS 861/1181] drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697 kernel test robot
2022-06-20 17:19 ` [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings kernel test robot
2022-02-08 11:28 [xilinx-xlnx:xlnx_rebase_v5.15 861/872] drivers/spi/spi-xilinx.c:692:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before return around line 697 kernel test robot
2022-02-08 11:23 ` [PATCH] spi: spi-xilinx: fix for_each_child.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.