From: Joe Damato <jdamato@fastly.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH 0/3] igb: XDP/ZC follow up
Date: Mon, 10 Feb 2025 11:49:25 -0800 [thread overview]
Message-ID: <Z6pYRXGiVmLDMe4S@LQ3V64L9R2> (raw)
In-Reply-To: <20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de>
On Mon, Feb 10, 2025 at 10:19:34AM +0100, Kurt Kanzenbach wrote:
> This is a follow up for the igb XDP/ZC implementation. The first two
> patches link the IRQs and queues to NAPI instances. This is required to
> bring back the XDP/ZC busy polling support. The last patch removes
> undesired IRQs (injected via igb watchdog) while busy polling with
> napi_defer_hard_irqs and gro_flush_timeout set.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
> Kurt Kanzenbach (3):
> igb: Link IRQs to NAPI instances
> igb: Link queues to NAPI instances
> igb: Get rid of spurious interrupts
>
> drivers/net/ethernet/intel/igb/igb.h | 5 ++-
> drivers/net/ethernet/intel/igb/igb_main.c | 67 ++++++++++++++++++++++++++-----
> drivers/net/ethernet/intel/igb/igb_xsk.c | 3 ++
> 3 files changed, 65 insertions(+), 10 deletions(-)
> ---
> base-commit: acdefab0dcbc3833b5a734ab80d792bb778517a0
> change-id: 20250206-igb_irq-f5a4d4deb207
Overall wanted to note that Stanislav is working on some locking
changes to remove the RTNL dependency [1].
My previous attempt at adding this API to virtio_net is on hold
until the locking stuff Stanislav is doing is done. I am not sure if
the maintainers will also ask to hold your series back, as well.
[1]: https://lore.kernel.org/netdev/20250204230057.1270362-1-sdf@fomichev.me/
WARNING: multiple messages have this Message-ID (diff)
From: Joe Damato <jdamato@fastly.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH 0/3] igb: XDP/ZC follow up
Date: Mon, 10 Feb 2025 11:49:25 -0800 [thread overview]
Message-ID: <Z6pYRXGiVmLDMe4S@LQ3V64L9R2> (raw)
In-Reply-To: <20250210-igb_irq-v1-0-bde078cdb9df@linutronix.de>
On Mon, Feb 10, 2025 at 10:19:34AM +0100, Kurt Kanzenbach wrote:
> This is a follow up for the igb XDP/ZC implementation. The first two
> patches link the IRQs and queues to NAPI instances. This is required to
> bring back the XDP/ZC busy polling support. The last patch removes
> undesired IRQs (injected via igb watchdog) while busy polling with
> napi_defer_hard_irqs and gro_flush_timeout set.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
> Kurt Kanzenbach (3):
> igb: Link IRQs to NAPI instances
> igb: Link queues to NAPI instances
> igb: Get rid of spurious interrupts
>
> drivers/net/ethernet/intel/igb/igb.h | 5 ++-
> drivers/net/ethernet/intel/igb/igb_main.c | 67 ++++++++++++++++++++++++++-----
> drivers/net/ethernet/intel/igb/igb_xsk.c | 3 ++
> 3 files changed, 65 insertions(+), 10 deletions(-)
> ---
> base-commit: acdefab0dcbc3833b5a734ab80d792bb778517a0
> change-id: 20250206-igb_irq-f5a4d4deb207
Overall wanted to note that Stanislav is working on some locking
changes to remove the RTNL dependency [1].
My previous attempt at adding this API to virtio_net is on hold
until the locking stuff Stanislav is doing is done. I am not sure if
the maintainers will also ask to hold your series back, as well.
[1]: https://lore.kernel.org/netdev/20250204230057.1270362-1-sdf@fomichev.me/
next prev parent reply other threads:[~2025-02-10 19:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 9:19 [Intel-wired-lan] [PATCH 0/3] igb: XDP/ZC follow up Kurt Kanzenbach
2025-02-10 9:19 ` Kurt Kanzenbach
2025-02-10 9:19 ` [Intel-wired-lan] [PATCH 1/3] igb: Link IRQs to NAPI instances Kurt Kanzenbach
2025-02-10 9:19 ` Kurt Kanzenbach
2025-02-10 18:25 ` [Intel-wired-lan] " Joe Damato
2025-02-10 18:25 ` Joe Damato
2025-02-10 22:22 ` [Intel-wired-lan] " Joe Damato
2025-02-10 22:22 ` Joe Damato
2025-02-10 9:19 ` [Intel-wired-lan] [PATCH 2/3] igb: Link queues " Kurt Kanzenbach
2025-02-10 9:19 ` Kurt Kanzenbach
2025-02-10 18:47 ` [Intel-wired-lan] " Joe Damato
2025-02-10 18:47 ` Joe Damato
2025-02-11 7:51 ` [Intel-wired-lan] " Kurt Kanzenbach
2025-02-11 7:51 ` Kurt Kanzenbach
2025-02-10 9:19 ` [Intel-wired-lan] [PATCH 3/3] igb: Get rid of spurious interrupts Kurt Kanzenbach
2025-02-10 9:19 ` Kurt Kanzenbach
2025-02-10 18:58 ` [Intel-wired-lan] " Joe Damato
2025-02-10 18:58 ` Joe Damato
2025-02-10 20:14 ` [Intel-wired-lan] " Gerhard Engleder
2025-02-10 20:14 ` Gerhard Engleder
2025-02-11 7:51 ` [Intel-wired-lan] " Kurt Kanzenbach
2025-02-11 7:51 ` Kurt Kanzenbach
2025-02-10 19:49 ` Joe Damato [this message]
2025-02-10 19:49 ` [PATCH 0/3] igb: XDP/ZC follow up Joe Damato
2025-02-11 3:15 ` [Intel-wired-lan] " Joe Damato
2025-02-11 3:15 ` Joe Damato
2025-02-11 14:44 ` [Intel-wired-lan] " Kurt Kanzenbach
2025-02-11 14:44 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6pYRXGiVmLDMe4S@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.