From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default
Date: Fri, 7 Mar 2025 18:10:54 +0000 [thread overview]
Message-ID: <Z8s2rmqauwCGJb9v@google.com> (raw)
In-Reply-To: <20250307031838.19164-1-chao@kernel.org>
I meant let's support it conservatively if someone needs to enable
in other platform.
On 03/07, Chao Yu wrote:
> Let's disable nat_bits by default.
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/node.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 56873c41436e..3148d9e44e7f 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
> if (!nm_i->nat_bitmap)
> return -ENOMEM;
>
> + /* disable nat_bits feature by default */
> + disable_nat_bits(sbi, true);
> +
> err = __get_nat_bitmaps(sbi);
> if (err)
> return err;
> --
> 2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: disalbe nat_bits by default
Date: Fri, 7 Mar 2025 18:10:54 +0000 [thread overview]
Message-ID: <Z8s2rmqauwCGJb9v@google.com> (raw)
In-Reply-To: <20250307031838.19164-1-chao@kernel.org>
I meant let's support it conservatively if someone needs to enable
in other platform.
On 03/07, Chao Yu wrote:
> Let's disable nat_bits by default.
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/node.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 56873c41436e..3148d9e44e7f 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
> if (!nm_i->nat_bitmap)
> return -ENOMEM;
>
> + /* disable nat_bits feature by default */
> + disable_nat_bits(sbi, true);
> +
> err = __get_nat_bitmaps(sbi);
> if (err)
> return err;
> --
> 2.40.1
next prev parent reply other threads:[~2025-03-07 18:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 3:18 [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default Chao Yu via Linux-f2fs-devel
2025-03-07 3:18 ` Chao Yu
2025-03-07 18:10 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-03-07 18:10 ` Jaegeuk Kim
2025-03-08 9:56 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-08 9:56 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8s2rmqauwCGJb9v@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.