* [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default
@ 2025-03-07 3:18 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2025-03-07 3:18 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-kernel, linux-f2fs-devel
Let's disable nat_bits by default.
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/node.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 56873c41436e..3148d9e44e7f 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
if (!nm_i->nat_bitmap)
return -ENOMEM;
+ /* disable nat_bits feature by default */
+ disable_nat_bits(sbi, true);
+
err = __get_nat_bitmaps(sbi);
if (err)
return err;
--
2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] f2fs: disalbe nat_bits by default
@ 2025-03-07 3:18 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2025-03-07 3:18 UTC (permalink / raw)
To: jaegeuk; +Cc: linux-f2fs-devel, linux-kernel, Chao Yu
Let's disable nat_bits by default.
Signed-off-by: Chao Yu <chao@kernel.org>
---
fs/f2fs/node.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 56873c41436e..3148d9e44e7f 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
if (!nm_i->nat_bitmap)
return -ENOMEM;
+ /* disable nat_bits feature by default */
+ disable_nat_bits(sbi, true);
+
err = __get_nat_bitmaps(sbi);
if (err)
return err;
--
2.40.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default
2025-03-07 3:18 ` Chao Yu
@ 2025-03-07 18:10 ` Jaegeuk Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Jaegeuk Kim via Linux-f2fs-devel @ 2025-03-07 18:10 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-kernel, linux-f2fs-devel
I meant let's support it conservatively if someone needs to enable
in other platform.
On 03/07, Chao Yu wrote:
> Let's disable nat_bits by default.
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/node.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 56873c41436e..3148d9e44e7f 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
> if (!nm_i->nat_bitmap)
> return -ENOMEM;
>
> + /* disable nat_bits feature by default */
> + disable_nat_bits(sbi, true);
> +
> err = __get_nat_bitmaps(sbi);
> if (err)
> return err;
> --
> 2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs: disalbe nat_bits by default
@ 2025-03-07 18:10 ` Jaegeuk Kim
0 siblings, 0 replies; 6+ messages in thread
From: Jaegeuk Kim @ 2025-03-07 18:10 UTC (permalink / raw)
To: Chao Yu; +Cc: linux-f2fs-devel, linux-kernel
I meant let's support it conservatively if someone needs to enable
in other platform.
On 03/07, Chao Yu wrote:
> Let's disable nat_bits by default.
>
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
> fs/f2fs/node.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 56873c41436e..3148d9e44e7f 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
> if (!nm_i->nat_bitmap)
> return -ENOMEM;
>
> + /* disable nat_bits feature by default */
> + disable_nat_bits(sbi, true);
> +
> err = __get_nat_bitmaps(sbi);
> if (err)
> return err;
> --
> 2.40.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default
2025-03-07 18:10 ` Jaegeuk Kim
@ 2025-03-08 9:56 ` Chao Yu
-1 siblings, 0 replies; 6+ messages in thread
From: Chao Yu via Linux-f2fs-devel @ 2025-03-08 9:56 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-kernel, linux-f2fs-devel
On 2025/3/8 2:10, Jaegeuk Kim wrote:
> I meant let's support it conservatively if someone needs to enable
> in other platform.
Oh, I've updated it, we can control it via mount option now.
Thanks,
>
> On 03/07, Chao Yu wrote:
>> Let's disable nat_bits by default.
>>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>> fs/f2fs/node.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
>> index 56873c41436e..3148d9e44e7f 100644
>> --- a/fs/f2fs/node.c
>> +++ b/fs/f2fs/node.c
>> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
>> if (!nm_i->nat_bitmap)
>> return -ENOMEM;
>>
>> + /* disable nat_bits feature by default */
>> + disable_nat_bits(sbi, true);
>> +
>> err = __get_nat_bitmaps(sbi);
>> if (err)
>> return err;
>> --
>> 2.40.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] f2fs: disalbe nat_bits by default
@ 2025-03-08 9:56 ` Chao Yu
0 siblings, 0 replies; 6+ messages in thread
From: Chao Yu @ 2025-03-08 9:56 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: chao, linux-f2fs-devel, linux-kernel
On 2025/3/8 2:10, Jaegeuk Kim wrote:
> I meant let's support it conservatively if someone needs to enable
> in other platform.
Oh, I've updated it, we can control it via mount option now.
Thanks,
>
> On 03/07, Chao Yu wrote:
>> Let's disable nat_bits by default.
>>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>> fs/f2fs/node.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
>> index 56873c41436e..3148d9e44e7f 100644
>> --- a/fs/f2fs/node.c
>> +++ b/fs/f2fs/node.c
>> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
>> if (!nm_i->nat_bitmap)
>> return -ENOMEM;
>>
>> + /* disable nat_bits feature by default */
>> + disable_nat_bits(sbi, true);
>> +
>> err = __get_nat_bitmaps(sbi);
>> if (err)
>> return err;
>> --
>> 2.40.1
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-08 9:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-07 3:18 [f2fs-dev] [PATCH] f2fs: disalbe nat_bits by default Chao Yu via Linux-f2fs-devel
2025-03-07 3:18 ` Chao Yu
2025-03-07 18:10 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-03-07 18:10 ` Jaegeuk Kim
2025-03-08 9:56 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-08 9:56 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.