From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Jai Luthra <jai.luthra@ideasonboard.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v4 5/7] i2c: core: Do not dereference fwnode in struct device
Date: Wed, 16 Apr 2025 10:26:34 +0300 [thread overview]
Message-ID: <Z_9bqmOp7-bvHCwu@smile.fi.intel.com> (raw)
In-Reply-To: <Z_9aVAYrorIyO8sg@shikoro>
On Wed, Apr 16, 2025 at 09:20:52AM +0200, Wolfram Sang wrote:
> On Wed, Apr 16, 2025 at 10:02:15AM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 16, 2025 at 08:55:27AM +0200, Wolfram Sang wrote:
> > > On Mon, Apr 14, 2025 at 01:01:55PM +0300, Andy Shevchenko wrote:
> > > > In order to make the underneath API easier to change in the future,
> > > > prevent users from dereferencing fwnode from struct device.
> > > > Instead, use the specific device_set_node() API for that.
> > > >
> > > > Tested-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> > > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > > Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > I'll check this patch later today. Rest of the series looks good to me
> > > already.
> >
> > Note, I'm planning to send a v5 shortly with the style fixes and commit
> > messages as you suggested.
>
> Please wait with that like half an hour.
Too late, I have sent it already...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-16 7:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 10:01 [PATCH v4 0/7] i2c: core: Move client towards fwnode Andy Shevchenko
2025-04-14 10:01 ` [PATCH v4 1/7] i2c: core: Drop duplicate check before calling OF APIs Andy Shevchenko
2025-04-14 10:01 ` [PATCH v4 2/7] i2c: core: Unify the firmware node type check Andy Shevchenko
2025-04-16 6:51 ` Andy Shevchenko
2025-04-16 6:52 ` Andy Shevchenko
2025-04-14 10:01 ` [PATCH v4 3/7] i2c: core: Switch to fwnode APIs to get IRQ Andy Shevchenko
2025-04-15 20:06 ` Wolfram Sang
2025-04-16 6:23 ` Andy Shevchenko
2025-04-14 10:01 ` [PATCH v4 4/7] i2c: core: Reuse fwnode variable where it makes sense Andy Shevchenko
2025-04-14 10:01 ` [PATCH v4 5/7] i2c: core: Do not dereference fwnode in struct device Andy Shevchenko
2025-04-16 6:55 ` Wolfram Sang
2025-04-16 7:02 ` Andy Shevchenko
2025-04-16 7:20 ` Wolfram Sang
2025-04-16 7:26 ` Andy Shevchenko [this message]
2025-04-14 10:01 ` [PATCH v4 6/7] i2c: core: Deprecate of_node in struct i2c_board_info Andy Shevchenko
2025-04-15 20:10 ` Wolfram Sang
2025-04-16 6:24 ` Andy Shevchenko
2025-04-16 6:54 ` Wolfram Sang
2025-04-16 7:05 ` Andy Shevchenko
2025-04-16 13:00 ` Wolfram Sang
2025-04-16 15:29 ` Andy Shevchenko
2025-04-14 10:01 ` [PATCH v4 7/7] media: i2c: ds90ub960: Remove of_node assignment Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_9bqmOp7-bvHCwu@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jai.luthra@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.