Re: [PATCH v4 00/22] usb/xhci and usb/msd improvements and tests

[Kevin Wolf <kwolf@redhat.com>]

Am 05.05.2025 um 04:03 hat Nicholas Piggin geschrieben:
> On Fri May 2, 2025 at 1:30 PM AEST, Nicholas Piggin wrote:
> > This is merged from two series now because code especially the test
> > cases have started to depend on one another.
> 
> Question for the list, hw/usb/* is marked orphan. I don't have the
> bandwidth to take it on. There's one or two other little things that
> need to be taken, e.g.,
> 
> https://lore.kernel.org/qemu-devel/20250405140002.3537411-1-linux@roeck-us.net/
> 
> Bernhard and Phil Dennis-Jordan have been doing some good work and
> reviews on host controllers and Kevin on usb-storage. Any interest
> to maintain it or do odd fixes? I suppose most are in the same boat
> as me.

The changes I made (or merged) were mostly for the external interfaces
of the device. Initialising the qdev device, setting properties, passing
them to the SCSI device etc. It's been a while since I last looked at
some actual USB stuff (and not in the context of QEMU), so I'm not
necessarily the natural reviewer/maintainer for this part of it. (On the
other hand, who is if Gerd doesn't have the time for it any more?)

> I would like to get this series merged, but I realize the mass storage
> change to relax packet ordering of a command particularly is quite
> complicated and under-reviewed.

I can try to find the time to have a look at the series, but given that
I'll have to familiarise myself with the specs again, it might take a
while.

> Would there be objection if I made a pull request for Guenter's
> patches, the hcd stuff, the qtests, and some of the easier / reviewed
> bits of msd?

That makes sense to me. I suppose I can also give a quick review for the
initial part of the msd patches, at lot of which seems to be more or
less just refactoring.

Kevin