Re: [PATCH v5 03/15] emul/ns16x50: implement emulator stub

[dmukhin@xen.org]

On Tue, Sep 02, 2025 at 11:36:19AM +0200, Jan Beulich wrote:
> On 29.08.2025 21:57, Stefano Stabellini wrote:
> > On Thu, 28 Aug 2025, dmukhin@xen.org wrote:
> >> +static void cf_check ns16x50_free(void *arg)
> >> +{
> >> +    struct vuart_ns16x50 *vdev = arg;
> >> +
> >> +    if ( vdev )
> >> +        ns16x50_deinit(vdev);
> >> +
> >> +    XVFREE(vdev);
> > 
> > XVFREE should only be called if ( vdev )
> 
> Why would this be? Like free(), both xfree() and xvfree() are fine to be
> called with a NULL pointer. What's odd here is that the uppercase form (the
> wrapper macro) is used - clearing the local variable is pointless when it
> is about to go out of scope anyway.

Thank you for remark!
I switched the code to xvfree() in v6