Re: [PATCH 1/9] drm/i915/psr: s/intel_psr_min_vblank_delay/intel_psr_min_set_context_latency

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Sun, Sep 21, 2025 at 10:05:27AM +0530, Ankit Nautiyal wrote:
> Rename intel_psr_min_vblank_delay to intel_psr_min_set_context_latency
> to reflect that it provides the minimum value for 'Set context
> latency'(SCL or Window W2) for PSR/Panel Replay to work correctly across
> different platforms.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_psr.c     | 6 +++---
>  drivers/gpu/drm/i915/display/intel_psr.h     | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 18b9baa96241..679c2a9baaee 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -2369,7 +2369,7 @@ static int intel_crtc_vblank_delay(const struct intel_crtc_state *crtc_state)
>  	if (!HAS_DSB(display))
>  		return 0;
>  
> -	vblank_delay = max(vblank_delay, intel_psr_min_vblank_delay(crtc_state));
> +	vblank_delay = max(vblank_delay, intel_psr_min_set_context_latency(crtc_state));
>  
>  	return vblank_delay;
>  }
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 01bf304c705f..49ccd0864c55 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -2360,12 +2360,12 @@ void intel_psr_trigger_frame_change_event(struct intel_dsb *dsb,
>  }
>  
>  /**
> - * intel_psr_min_vblank_delay - Minimum vblank delay needed by PSR
> + * intel_psr_min_set_context_latency - Minimum 'set context latency' lines needed by PSR
>   * @crtc_state: the crtc state
>   *
> - * Return minimum vblank delay needed by PSR.
> + * Return minimum SCL lines/delay needed by PSR.
>   */
> -int intel_psr_min_vblank_delay(const struct intel_crtc_state *crtc_state)
> +int intel_psr_min_set_context_latency(const struct intel_crtc_state *crtc_state)
>  {
>  	struct intel_display *display = to_intel_display(crtc_state);
>  
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h
> index 077751aa599f..9147996d6c9e 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr.h
> @@ -77,7 +77,7 @@ void intel_psr_unlock(const struct intel_crtc_state *crtc_state);
>  void intel_psr_trigger_frame_change_event(struct intel_dsb *dsb,
>  					  struct intel_atomic_state *state,
>  					  struct intel_crtc *crtc);
> -int intel_psr_min_vblank_delay(const struct intel_crtc_state *crtc_state);
> +int intel_psr_min_set_context_latency(const struct intel_crtc_state *crtc_state);
>  void intel_psr_connector_debugfs_add(struct intel_connector *connector);
>  void intel_psr_debugfs_register(struct intel_display *display);
>  bool intel_psr_needs_alpm(struct intel_dp *intel_dp, const struct intel_crtc_state *crtc_state);
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel