Re: [PATCH 2/3] migration: Remove zero-blocks capability

[Peter Xu <peterx@redhat.com>]

On Thu, Jan 15, 2026 at 07:00:45AM +0100, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
> > It was declared deprecated since 9.2.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >  docs/about/deprecated.rst       |  6 ------
> >  docs/about/removed-features.rst |  6 ++++++
> >  qapi/migration.json             | 11 +----------
> >  migration/options.c             |  5 -----
> >  4 files changed, 7 insertions(+), 21 deletions(-)
> >
> > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> > index b499b2acb0..6e4e2e4833 100644
> > --- a/docs/about/deprecated.rst
> > +++ b/docs/about/deprecated.rst
> > @@ -575,12 +575,6 @@ deprecated in favor of explicitly using the ``file:`` URI with the
> >  file descriptor being passed as an ``fdset``. Refer to the ``add-fd``
> >  command documentation for details on the ``fdset`` usage.
> >  
> > -``zero-blocks`` capability (since 9.2)
> > -''''''''''''''''''''''''''''''''''''''
> > -
> > -The ``zero-blocks`` capability was part of the block migration which
> > -doesn't exist anymore since it was removed in QEMU v9.1.
> > -
> >  COLO migration framework (since 11.0)
> >  '''''''''''''''''''''''''''''''''''''
> >  
> > diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
> > index e81d79da47..8a9d21068a 100644
> > --- a/docs/about/removed-features.rst
> > +++ b/docs/about/removed-features.rst
> > @@ -717,6 +717,12 @@ Block migration has been removed. For a replacement, see "QMP
> >  invocation for live storage migration with ``blockdev-mirror`` + NBD"
> >  in docs/interop/live-block-operations.rst.
> >  
> > +``migrate-set-capabilities`` ``zero-blocks`` option (removed in 11.0)
> > +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> > +
> > +The ``zero-blocks`` capability was part of the block migration capability
> > +that got removed.  Removed with no replacement.
> > +
> 
> Suggest something like
> 
>    The ``zero-blocks`` capability was accidentally left behind when
>    block migration capability got removed in 9.1.  Removed with no
>    replacement.

Will do.

> 
> >  ``migrate-set-parameter`` ``compress-level`` option (removed in 9.1)
> >  ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> >  
> 
> [...]
> 

-- 
Peter Xu