Re: [PATCH 3/3] migration: Remove fd: support on files

[Peter Xu <peterx@redhat.com>]

On Thu, Jan 15, 2026 at 05:45:57PM +0530, Prasad Pandit wrote:
> > @@ -92,8 +94,9 @@ void fd_start_incoming_migration(const char *fdname, Error **errp)
> >      }
> >
> >      if (!migration_fd_valid(fd)) {
> > -        warn_report("fd: migration to a file is deprecated."
> > -                    " Use file: instead.");
> > +        error_setg(errp, "fd: migration to a file is not supported."
> > +                   " Use file: instead.");
> > +        return;
> >      }
> 
> * If we are sure that an invalid 'fd' is always the file one,  then
> maybe (if possible) 'migrate_fd_valid' could be renamed to
> 'is_fd_file()'. Above snippet reads that 'fd' is invalid and the error
> message says migration to file is deprecated.

We're not sure about it, so the current function name is IMHO more suitable
with only whitelist of socket and pipes.  The error message provides a best
guess in this case.

> 
> Otherwise change looks okay.
> Reviewed-by: Prasad Pandit <pjp@fedoraproject.org>

Thanks.

-- 
Peter Xu