From: Florian Westphal <fw@strlen.de>
To: Hyunwoo Kim <imv4bel@gmail.com>
Cc: pablo@netfilter.org, phil@nwl.cc, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] netfilter: nf_flow_table_offload: fix heap overflow in flow_action_entry_next()
Date: Mon, 16 Mar 2026 12:48:33 +0100 [thread overview]
Message-ID: <abfuEe_PpDCyA64B@strlen.de> (raw)
In-Reply-To: <abfoTBGLhav-iPQb@v4bel>
Hyunwoo Kim <imv4bel@gmail.com> wrote:
> > Ping. I'm not even sure if there is a bug to begin with, see Pablos
>
> Sorry for the late reply.
>
> To clarify, I triggered the overflow using a dummy device that accepts
> TC_SETUP_FT, as I don't have real offload-capable hardware. The 17 entry
> scenario requires double VLAN (QinQ) + IPv6 + SNAT + DNAT simultaneously,
> which is unlikely in real-world deployments, so it is hypothetical.
If you triggered it, its not hyptothetical and needs to be fixed.
> > Normally there should be a check that prevents such a configuration.
> > If thats missing, please add one instead of increasing this define.
>
> So, should I send a v2 with a bounds check, or drop this patch?
Yes, please send a v2 that prevents the overflow at configuration time.
next prev parent reply other threads:[~2026-03-16 11:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 17:23 [PATCH net] netfilter: nf_flow_table_offload: fix heap overflow in flow_action_entry_next() Hyunwoo Kim
2026-03-07 19:04 ` Florian Westphal
2026-03-16 10:53 ` Florian Westphal
2026-03-16 11:23 ` Hyunwoo Kim
2026-03-16 11:31 ` Hyunwoo Kim
2026-03-16 11:48 ` Florian Westphal [this message]
2026-03-16 11:56 ` Pablo Neira Ayuso
2026-03-16 14:17 ` Hyunwoo Kim
2026-03-16 14:58 ` Florian Westphal
2026-03-25 14:27 ` Florian Westphal
2026-03-25 15:18 ` Pablo Neira Ayuso
2026-03-08 10:41 ` Pablo Neira Ayuso
2026-03-26 21:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abfuEe_PpDCyA64B@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=imv4bel@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.