From: Vladimir Zapolskiy <vz@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org,
MSM <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 2/3] clk: qcom: Add SM8350 camera clock controller driver
Date: Sat, 7 Nov 2026 17:29:37 +0200 [thread overview]
Message-ID: <ad7b886c-d3fc-419e-b155-3fd39fec900b@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-199410@kernel.org>
On 11/5/26 18:06, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [Medium] clk: qcom: Lucid 5LPE PLLs in camcc-sm8350 use clk_trion_pll_configure()
That's a valid issue, and it requires to make a formal introduction of Lucid 5LPE PLLs.
> - [Medium] clk: qcom: camcc-sm8350: duplicate cam_cc_pll2 parent in cam_cc_parent_data_1
This is also a valid review comment, fortunately this one is easy to fix.
Will prepare v2.
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2026-11-07 15:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 0:17 [PATCH 0/3] clk: qcom: Add SM8350 camera clock controller Vladimir Zapolskiy
2026-11-04 0:17 ` [PATCH 1/3] dt-bindings: clock: " Vladimir Zapolskiy
2026-11-04 0:17 ` [PATCH 2/3] clk: qcom: Add SM8350 camera clock controller driver Vladimir Zapolskiy
2026-11-05 16:06 ` sashiko-bot
2026-11-07 15:29 ` Vladimir Zapolskiy [this message]
2026-11-06 16:59 ` Uwe Kleine-König
2026-11-04 0:17 ` [PATCH 3/3] arm64: dts: qcom: sm8350: Add camera clock controller Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad7b886c-d3fc-419e-b155-3fd39fec900b@kernel.org \
--to=vz@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.