From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Vladimir Zapolskiy <vz@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Abel Vesa <abelvesa@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] clk: qcom: Add SM8350 camera clock controller driver
Date: Fri, 6 Nov 2026 17:59:25 +0100 [thread overview]
Message-ID: <au4HToRcyRPtlOrG@monoceros> (raw)
In-Reply-To: <20261104001704.2744766-3-vz@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 360 bytes --]
On Wed, Nov 04, 2026 at 02:17:03AM +0200, Vladimir Zapolskiy wrote:
> +#include <linux/mod_devicetable.h>
> [...]
> +#include <linux/platform_device.h>
Please don't use <linux/mod_devicetable.h>. <linux/platform_device.h> is
good enough to provide of_device_id already. If you insist on full iwyu,
please use <linux/device-id/of.h> instead.
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-06 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 0:17 [PATCH 0/3] clk: qcom: Add SM8350 camera clock controller Vladimir Zapolskiy
2026-11-04 0:17 ` [PATCH 1/3] dt-bindings: clock: " Vladimir Zapolskiy
2026-11-04 0:17 ` [PATCH 2/3] clk: qcom: Add SM8350 camera clock controller driver Vladimir Zapolskiy
2026-11-05 16:06 ` sashiko-bot
2026-11-07 15:29 ` Vladimir Zapolskiy
2026-11-06 16:59 ` Uwe Kleine-König [this message]
2026-11-04 0:17 ` [PATCH 3/3] arm64: dts: qcom: sm8350: Add camera clock controller Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=au4HToRcyRPtlOrG@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney+clk@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet+clk@baylibre.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.