* [PATCH v1] checkpatch: Allow spaces after all coroutine annotations
@ 2026-04-20 19:13 Fabiano Rosas
2026-04-21 6:03 ` Markus Armbruster
2026-04-23 8:29 ` Kevin Wolf
0 siblings, 2 replies; 3+ messages in thread
From: Fabiano Rosas @ 2026-04-20 19:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf
The coroutine annotations may be used in the declaration of function
pointers, which triggers checkpatch due to the space before the
parentheses. E.g:
int coroutine_fn (*run)(Job *job, Error **errp);
^
The coroutine_fn annotation is already included in the list of terms
where spaces are allowed. Add the other coroutine annotations:
coroutine_mixed_fn and no_coroutine_fn.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
the next migration PR will trigger this
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b77bd69328..e1cf2ff23b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2441,6 +2441,7 @@ sub process {
if ($name =~ /^(?:
if|for|while|switch|return|case|
volatile|__volatile__|coroutine_fn|
+ coroutine_mixed_fn|no_coroutine_fn|
__attribute__|format|__extension__|
asm|__asm__)$/x)
{
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] checkpatch: Allow spaces after all coroutine annotations
2026-04-20 19:13 [PATCH v1] checkpatch: Allow spaces after all coroutine annotations Fabiano Rosas
@ 2026-04-21 6:03 ` Markus Armbruster
2026-04-23 8:29 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2026-04-21 6:03 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: qemu-devel, Kevin Wolf
Fabiano Rosas <farosas@suse.de> writes:
> The coroutine annotations may be used in the declaration of function
> pointers, which triggers checkpatch due to the space before the
> parentheses. E.g:
>
> int coroutine_fn (*run)(Job *job, Error **errp);
> ^
> The coroutine_fn annotation is already included in the list of terms
> where spaces are allowed. Add the other coroutine annotations:
> coroutine_mixed_fn and no_coroutine_fn.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> the next migration PR will trigger this
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b77bd69328..e1cf2ff23b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2441,6 +2441,7 @@ sub process {
> if ($name =~ /^(?:
> if|for|while|switch|return|case|
> volatile|__volatile__|coroutine_fn|
> + coroutine_mixed_fn|no_coroutine_fn|
> __attribute__|format|__extension__|
> asm|__asm__)$/x)
> {
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] checkpatch: Allow spaces after all coroutine annotations
2026-04-20 19:13 [PATCH v1] checkpatch: Allow spaces after all coroutine annotations Fabiano Rosas
2026-04-21 6:03 ` Markus Armbruster
@ 2026-04-23 8:29 ` Kevin Wolf
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2026-04-23 8:29 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: qemu-devel
Am 20.04.2026 um 21:13 hat Fabiano Rosas geschrieben:
> The coroutine annotations may be used in the declaration of function
> pointers, which triggers checkpatch due to the space before the
> parentheses. E.g:
>
> int coroutine_fn (*run)(Job *job, Error **errp);
> ^
> The coroutine_fn annotation is already included in the list of terms
> where spaces are allowed. Add the other coroutine annotations:
> coroutine_mixed_fn and no_coroutine_fn.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-23 8:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-20 19:13 [PATCH v1] checkpatch: Allow spaces after all coroutine annotations Fabiano Rosas
2026-04-21 6:03 ` Markus Armbruster
2026-04-23 8:29 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.