Re: [PATCH v1 5/9] KVM: x86: Refactor APIC state get/set to accept variable-sized buffers

[Naveen N Rao <naveen@kernel.org>]

On Wed, Feb 04, 2026 at 07:44:48AM +0000, Manali Shukla wrote:
> Refactor kvm_apic_get_state() and kvm_apic_set_state() to accept a void
> pointer and explicit size parameter instead of struct kvm_lapic_state.
> This removes the hard-coded assumption about 1KB APIC register space and
> allows functions to work with both 1KB and 4KB APIC register space.
> 
> Existing callers of kvm_apic_get_state() and kvm_apic_set_state() pass
> `s->regs` and `sizeof(*s)` to maintain the current behavior with the 1KB
> kvm_lapic_state structure.  Subsequent patches will add KVM_GET_LAPIC2
> and KVM_SET_LAPIC2 IOCTLs that will also use these functions in order to
> save/restore 4KB APIC register space.
> 
> No functional change intended; existing KVM_GET_LAPIC and KVM_SET_LAPIC
> IOCTLs work exactly as before.
> 
> Signed-off-by: Manali Shukla <manali.shukla@amd.com>
> ---
>  arch/x86/kvm/lapic.c | 32 ++++++++++++++++----------------
>  arch/x86/kvm/lapic.h |  4 ++--
>  arch/x86/kvm/x86.c   |  4 ++--
>  3 files changed, 20 insertions(+), 20 deletions(-)

How about having these functions instead always work with 
kvm_lapic_state2?

See my response to the next patch.

- Naveen