All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: palash.kambar@oss.qualcomm.com
Cc: neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, mani@kernel.org, alim.akhtar@samsung.com,
	bvanassche@acm.org, andersson@kernel.org,
	dmitry.baryshkov@oss.qualcomm.com, abel.vesa@oss.qualcomm.com,
	luca.weiss@fairphone.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	nitin.rawat@oss.qualcomm.com
Subject: Re: [PATCH v3 3/3] phy: qcom-qmp-ufs: Add UFS PHY support on Hawi
Date: Thu, 11 Jun 2026 20:59:51 +0530	[thread overview]
Message-ID: <airUb6wT-I-7cOXK@vaman> (raw)
In-Reply-To: <20260526090956.2340262-4-palash.kambar@oss.qualcomm.com>

On 26-05-26, 14:39, palash.kambar@oss.qualcomm.com wrote:
> From: Palash Kambar <palash.kambar@oss.qualcomm.com>
> 
> Add the init sequence tables and config for the UFS QMP phy found in
> the Hawi SoC.

This fails to build for me on phy/next

In file included from drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:24:
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:1878:26: error: ‘QSERDES_V8_COM_PLL_IVCO_MODE1’ undeclared here (not in a function); did you mean ‘QSERDES_V6_COM_PLL_IVCO_MODE1’?
 1878 |         QMP_PHY_INIT_CFG(QSERDES_V8_COM_PLL_IVCO_MODE1, 0x1f),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-common.h:22:27: note: in definition of macro ‘QMP_PHY_INIT_CFG’
   22 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:1879:26: error: ‘QSERDES_V8_COM_CMN_IETRIM’ undeclared here (not in a function); did you mean ‘QSERDES_V6_COM_CMN_IETRIM’?
 1879 |         QMP_PHY_INIT_CFG(QSERDES_V8_COM_CMN_IETRIM, 0x07),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-common.h:22:27: note: in definition of macro ‘QMP_PHY_INIT_CFG’
   22 |                 .offset = o,            \

And so on. Looks like QSERDES_V8_COM_PLL_IVCO_MODE1 etc are not define.
Please rebase test and send again

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: palash.kambar@oss.qualcomm.com
Cc: neil.armstrong@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, mani@kernel.org, alim.akhtar@samsung.com,
	bvanassche@acm.org, andersson@kernel.org,
	dmitry.baryshkov@oss.qualcomm.com, abel.vesa@oss.qualcomm.com,
	luca.weiss@fairphone.com, linux-arm-msm@vger.kernel.org,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	nitin.rawat@oss.qualcomm.com
Subject: Re: [PATCH v3 3/3] phy: qcom-qmp-ufs: Add UFS PHY support on Hawi
Date: Thu, 11 Jun 2026 20:59:51 +0530	[thread overview]
Message-ID: <airUb6wT-I-7cOXK@vaman> (raw)
In-Reply-To: <20260526090956.2340262-4-palash.kambar@oss.qualcomm.com>

On 26-05-26, 14:39, palash.kambar@oss.qualcomm.com wrote:
> From: Palash Kambar <palash.kambar@oss.qualcomm.com>
> 
> Add the init sequence tables and config for the UFS QMP phy found in
> the Hawi SoC.

This fails to build for me on phy/next

In file included from drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:24:
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:1878:26: error: ‘QSERDES_V8_COM_PLL_IVCO_MODE1’ undeclared here (not in a function); did you mean ‘QSERDES_V6_COM_PLL_IVCO_MODE1’?
 1878 |         QMP_PHY_INIT_CFG(QSERDES_V8_COM_PLL_IVCO_MODE1, 0x1f),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-common.h:22:27: note: in definition of macro ‘QMP_PHY_INIT_CFG’
   22 |                 .offset = o,            \
      |                           ^
drivers/phy/qualcomm/phy-qcom-qmp-ufs.c:1879:26: error: ‘QSERDES_V8_COM_CMN_IETRIM’ undeclared here (not in a function); did you mean ‘QSERDES_V6_COM_CMN_IETRIM’?
 1879 |         QMP_PHY_INIT_CFG(QSERDES_V8_COM_CMN_IETRIM, 0x07),
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-common.h:22:27: note: in definition of macro ‘QMP_PHY_INIT_CFG’
   22 |                 .offset = o,            \

And so on. Looks like QSERDES_V8_COM_PLL_IVCO_MODE1 etc are not define.
Please rebase test and send again

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2026-06-11 15:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26  9:09 [PATCH v3 0/3] Add Hawi UFS PHY and Controller support palash.kambar
2026-05-26  9:09 ` palash.kambar
2026-05-26  9:09 ` [PATCH v3 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-ufs-phy: Add Hawi UFS PHY compatible palash.kambar
2026-05-26  9:09   ` palash.kambar
2026-05-31 12:33   ` Krzysztof Kozlowski
2026-05-31 12:33     ` Krzysztof Kozlowski
2026-06-04 16:21     ` Palash Kambar
2026-06-04 16:21       ` Palash Kambar
2026-06-04 16:54   ` Krzysztof Kozlowski
2026-06-04 16:54     ` Krzysztof Kozlowski
2026-05-26  9:09 ` [PATCH v3 2/3] scsi: ufs: qcom: dt-bindings: Document the Hawi UFS controller palash.kambar
2026-05-26  9:09   ` palash.kambar
2026-05-26  9:37   ` sashiko-bot
2026-05-26  9:37     ` sashiko-bot
2026-05-31 12:34   ` Krzysztof Kozlowski
2026-05-31 12:34     ` Krzysztof Kozlowski
2026-05-26  9:09 ` [PATCH v3 3/3] phy: qcom-qmp-ufs: Add UFS PHY support on Hawi palash.kambar
2026-05-26  9:09   ` palash.kambar
2026-05-26 10:02   ` sashiko-bot
2026-05-26 10:02     ` sashiko-bot
2026-06-08 15:15   ` Palash Kambar
2026-06-08 15:15     ` Palash Kambar
2026-06-08 18:37   ` Dmitry Baryshkov
2026-06-08 18:37     ` Dmitry Baryshkov
2026-06-11 15:29   ` Vinod Koul [this message]
2026-06-11 15:29     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=airUb6wT-I-7cOXK@vaman \
    --to=vkoul@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=alim.akhtar@samsung.com \
    --cc=andersson@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=mani@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=nitin.rawat@oss.qualcomm.com \
    --cc=palash.kambar@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.