From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Algea Cao" <algea.cao@rock-chips.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
kernel@collabora.com, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
"Thomas Niederprüm" <dubito@online.de>,
"Simon Wright" <simon@symple.nz>
Subject: Re: [PATCH v4 8/8] phy: rockchip: samsung-hdptx: Consistently use bitfield macros
Date: Mon, 20 Jul 2026 17:31:49 +0300 [thread overview]
Message-ID: <al4xVeMXTmjQeMlp@umbar.lan> (raw)
In-Reply-To: <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com>
On Fri, Jun 12, 2026 at 02:45:27AM +0300, Cristian Ciocaltea wrote:
> Make the code more robust and improve readability by using the available
> bitfield macros (e.g. FIELD_PREP, FIELD_GET) whenever possible, instead
> of open coding the related bit operations.
>
> Tested-by: Thomas Niederprüm <dubito@online.de>
> Tested-by: Simon Wright <simon@symple.nz>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 30 +++++++++++++++--------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Algea Cao" <algea.cao@rock-chips.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
kernel@collabora.com, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
"Thomas Niederprüm" <dubito@online.de>,
"Simon Wright" <simon@symple.nz>
Subject: Re: [PATCH v4 8/8] phy: rockchip: samsung-hdptx: Consistently use bitfield macros
Date: Mon, 20 Jul 2026 17:31:49 +0300 [thread overview]
Message-ID: <al4xVeMXTmjQeMlp@umbar.lan> (raw)
In-Reply-To: <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com>
On Fri, Jun 12, 2026 at 02:45:27AM +0300, Cristian Ciocaltea wrote:
> Make the code more robust and improve readability by using the available
> bitfield macros (e.g. FIELD_PREP, FIELD_GET) whenever possible, instead
> of open coding the related bit operations.
>
> Tested-by: Thomas Niederprüm <dubito@online.de>
> Tested-by: Simon Wright <simon@symple.nz>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 30 +++++++++++++++--------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Algea Cao" <algea.cao@rock-chips.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
kernel@collabora.com, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
"Thomas Niederprüm" <dubito@online.de>,
"Simon Wright" <simon@symple.nz>
Subject: Re: [PATCH v4 8/8] phy: rockchip: samsung-hdptx: Consistently use bitfield macros
Date: Mon, 20 Jul 2026 17:31:49 +0300 [thread overview]
Message-ID: <al4xVeMXTmjQeMlp@umbar.lan> (raw)
In-Reply-To: <20260612-hdptx-clk-fixes-v4-8-ce5e1d456cda@collabora.com>
On Fri, Jun 12, 2026 at 02:45:27AM +0300, Cristian Ciocaltea wrote:
> Make the code more robust and improve readability by using the available
> bitfield macros (e.g. FIELD_PREP, FIELD_GET) whenever possible, instead
> of open coding the related bit operations.
>
> Tested-by: Thomas Niederprüm <dubito@online.de>
> Tested-by: Simon Wright <simon@symple.nz>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c | 30 +++++++++++++++--------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-07-20 14:31 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 23:45 [PATCH v4 0/8] phy: rockchip: samsung-hdptx: Clock fixes and API transition cleanups Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` [PATCH v4 1/8] phy: rockchip: samsung-hdptx: Fix rate recalculation for high bpc Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-07-16 12:27 ` Andy Yan
2026-07-16 12:27 ` Andy Yan
2026-07-16 12:27 ` Andy Yan
2026-07-20 13:24 ` Dmitry Baryshkov
2026-07-20 13:24 ` Dmitry Baryshkov
2026-07-20 13:24 ` Dmitry Baryshkov
2026-06-11 23:45 ` [PATCH v4 2/8] phy: rockchip: samsung-hdptx: Prevent divide-by-zero when computing clk rate Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:57 ` sashiko-bot
2026-06-12 0:18 ` Cristian Ciocaltea
2026-07-20 14:10 ` Dmitry Baryshkov
2026-07-20 18:36 ` Cristian Ciocaltea
2026-06-11 23:45 ` [PATCH v4 3/8] phy: rockchip: samsung-hdptx: Fix rate recalculation for 3.2GHz FRL Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-07-20 14:12 ` Dmitry Baryshkov
2026-07-20 14:12 ` Dmitry Baryshkov
2026-07-20 14:12 ` Dmitry Baryshkov
2026-06-11 23:45 ` [PATCH v4 4/8] phy: rockchip: samsung-hdptx: Handle uncommitted PHY config changes Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:59 ` sashiko-bot
2026-06-12 0:23 ` Cristian Ciocaltea
2026-07-20 14:17 ` Dmitry Baryshkov
2026-07-20 14:17 ` Dmitry Baryshkov
2026-07-20 14:17 ` Dmitry Baryshkov
2026-07-20 19:22 ` Cristian Ciocaltea
2026-07-20 19:22 ` Cristian Ciocaltea
2026-07-20 19:22 ` Cristian Ciocaltea
2026-06-11 23:45 ` [PATCH v4 5/8] phy: rockchip: samsung-hdptx: Drop TMDS rate setup workaround Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-07-20 14:19 ` Dmitry Baryshkov
2026-07-20 14:19 ` Dmitry Baryshkov
2026-07-20 14:19 ` Dmitry Baryshkov
2026-07-20 19:24 ` Cristian Ciocaltea
2026-07-20 19:24 ` Cristian Ciocaltea
2026-07-20 19:24 ` Cristian Ciocaltea
2026-06-11 23:45 ` [PATCH v4 6/8] phy: rockchip: samsung-hdptx: Drop restrict_rate_change handling Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-07-20 14:26 ` Dmitry Baryshkov
2026-07-20 14:26 ` Dmitry Baryshkov
2026-07-20 14:26 ` Dmitry Baryshkov
2026-06-11 23:45 ` [PATCH v4 7/8] phy: rockchip: samsung-hdptx: Simplify GRF access with FIELD_PREP_WM16() Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-07-20 14:30 ` Dmitry Baryshkov
2026-07-20 14:30 ` Dmitry Baryshkov
2026-07-20 14:30 ` Dmitry Baryshkov
2026-06-11 23:45 ` [PATCH v4 8/8] phy: rockchip: samsung-hdptx: Consistently use bitfield macros Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-06-11 23:45 ` Cristian Ciocaltea
2026-07-20 14:31 ` Dmitry Baryshkov [this message]
2026-07-20 14:31 ` Dmitry Baryshkov
2026-07-20 14:31 ` Dmitry Baryshkov
2026-07-01 18:50 ` [PATCH v4 0/8] phy: rockchip: samsung-hdptx: Clock fixes and API transition cleanups Diederik de Haas
2026-07-01 18:50 ` Diederik de Haas
2026-07-01 18:50 ` Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al4xVeMXTmjQeMlp@umbar.lan \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=algea.cao@rock-chips.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=dubito@online.de \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simon@symple.nz \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.