* [PATCH] iotests: increase timeouts for tests to 5 minutes
@ 2026-06-23 16:03 Daniel P. Berrangé
2026-07-16 10:15 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrangé @ 2026-06-23 16:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Hanna Reitz, Kevin Wolf, qemu-block, Daniel P. Berrangé
Currently we have tests timeout set to 3 minutes, on the basis
that they're generally done in less than a minute. I've hit a
couple of random failures suggesting that's not sufficiently
pessimistic. Increase the timeout to 5 minutes to have a greater
safety net in high load scenarios.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qemu-iotests/meson.build | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index bc6132a0f7..8857f25f29 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -52,16 +52,17 @@ foreach driver, speed: qemu_iotests_drivers
'-tap', '-' + driver, item,
'--source-dir', meson.current_source_dir(),
'--build-dir', meson.current_build_dir()]
- # Some individual tests take as long as 45 seconds
- # Bump the timeout to 3 minutes for some headroom
- # on slow machines to minimize spurious failures
+ # Some individual tests take as long as 3 minutes
+ # in high load scenarios. Bump the timeout to 5
+ # minutes for some headroom on slow / loaded
+ # machines to minimize spurious failures
test('io-' + driver + '-' + item,
python,
args: args,
depends: qemu_iotests_binaries,
env: qemu_iotests_env,
protocol: 'tap',
- timeout: 180,
+ timeout: 300,
suite: suites)
endforeach
endif
@@ -94,16 +95,14 @@ foreach driver, speed: qemu_iotests_drivers
'-tap', '-' + driver, item,
'--source-dir', meson.current_source_dir(),
'--build-dir', meson.current_build_dir()]
- # Some individual tests take as long as 45 seconds
- # Bump the timeout to 3 minutes for some headroom
- # on slow machines to minimize spurious failures
+ # See earlier note about timeouts
test('io-' + driver + '-' + item,
python,
args: args,
depends: qemu_iotests_binaries,
env: qemu_iotests_env,
protocol: 'tap',
- timeout: 180,
+ timeout: 300,
suite: suites)
endforeach
endforeach
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iotests: increase timeouts for tests to 5 minutes
2026-06-23 16:03 [PATCH] iotests: increase timeouts for tests to 5 minutes Daniel P. Berrangé
@ 2026-07-16 10:15 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2026-07-16 10:15 UTC (permalink / raw)
To: qemu-devel; +Cc: Hanna Reitz, Kevin Wolf, qemu-block
Ping: any reviewers for this simple robustness fix.
On Tue, Jun 23, 2026 at 05:03:26PM +0100, Daniel P. Berrangé wrote:
> Currently we have tests timeout set to 3 minutes, on the basis
> that they're generally done in less than a minute. I've hit a
> couple of random failures suggesting that's not sufficiently
> pessimistic. Increase the timeout to 5 minutes to have a greater
> safety net in high load scenarios.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qemu-iotests/meson.build | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
> index bc6132a0f7..8857f25f29 100644
> --- a/tests/qemu-iotests/meson.build
> +++ b/tests/qemu-iotests/meson.build
> @@ -52,16 +52,17 @@ foreach driver, speed: qemu_iotests_drivers
> '-tap', '-' + driver, item,
> '--source-dir', meson.current_source_dir(),
> '--build-dir', meson.current_build_dir()]
> - # Some individual tests take as long as 45 seconds
> - # Bump the timeout to 3 minutes for some headroom
> - # on slow machines to minimize spurious failures
> + # Some individual tests take as long as 3 minutes
> + # in high load scenarios. Bump the timeout to 5
> + # minutes for some headroom on slow / loaded
> + # machines to minimize spurious failures
> test('io-' + driver + '-' + item,
> python,
> args: args,
> depends: qemu_iotests_binaries,
> env: qemu_iotests_env,
> protocol: 'tap',
> - timeout: 180,
> + timeout: 300,
> suite: suites)
> endforeach
> endif
> @@ -94,16 +95,14 @@ foreach driver, speed: qemu_iotests_drivers
> '-tap', '-' + driver, item,
> '--source-dir', meson.current_source_dir(),
> '--build-dir', meson.current_build_dir()]
> - # Some individual tests take as long as 45 seconds
> - # Bump the timeout to 3 minutes for some headroom
> - # on slow machines to minimize spurious failures
> + # See earlier note about timeouts
> test('io-' + driver + '-' + item,
> python,
> args: args,
> depends: qemu_iotests_binaries,
> env: qemu_iotests_env,
> protocol: 'tap',
> - timeout: 180,
> + timeout: 300,
> suite: suites)
> endforeach
> endforeach
> --
> 2.54.0
>
>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-16 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-23 16:03 [PATCH] iotests: increase timeouts for tests to 5 minutes Daniel P. Berrangé
2026-07-16 10:15 ` Daniel P. Berrangé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.