All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Kees Cook <keescook@chromium.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Alex Shi <alex.shi@intel.com>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	Julien Tinnes <jln@google.com>, Will Drewry <wad@chromium.org>,
	Eric Northup <digitaleric@google.com>
Subject: [kernel-hardening] Re: [PATCH] x86: make IDT read-only
Date: Tue, 9 Apr 2013 00:42:49 +0100 (BST)	[thread overview]
Message-ID: <alpine.LFD.2.03.1304090042220.25182@linux-mips.org> (raw)
In-Reply-To: <CAGXu5j+fWeinnBr3JLkLt-M4N8uSXzP9MiRF20h37_WABQ1Rrw@mail.gmail.com>

On Mon, 8 Apr 2013, Kees Cook wrote:

> >  FWIW the change looks reasonable to me, however given that that it makes
> > the arrangement unconditional and there is no longer a workaround to
> > enable I think it would make sense to remove the conditional block quoted
> > above altogether, along with the f00f_workaround_enabled variable itself
> > (alternatively "Intel Pentium with F0 0F bug" alone could be printed
> > instead and the name of the variable adjusted to make sense with the new
> > meaning -- up to you to decide).
> 
> Actually, I take it back. The other portion of the workaround is still
> active (in mm/fault.c), and this chunk announces it, so I'm going to
> leave it as-is.

 Ah, OK then.  Thanks for double-checking.

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Kees Cook <keescook@chromium.org>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
	Alex Shi <alex.shi@intel.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Will Drewry <wad@chromium.org>, Julien Tinnes <jln@google.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	"x86@kernel.org" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] x86: make IDT read-only
Date: Tue, 9 Apr 2013 00:42:49 +0100 (BST)	[thread overview]
Message-ID: <alpine.LFD.2.03.1304090042220.25182@linux-mips.org> (raw)
In-Reply-To: <CAGXu5j+fWeinnBr3JLkLt-M4N8uSXzP9MiRF20h37_WABQ1Rrw@mail.gmail.com>

On Mon, 8 Apr 2013, Kees Cook wrote:

> >  FWIW the change looks reasonable to me, however given that that it makes
> > the arrangement unconditional and there is no longer a workaround to
> > enable I think it would make sense to remove the conditional block quoted
> > above altogether, along with the f00f_workaround_enabled variable itself
> > (alternatively "Intel Pentium with F0 0F bug" alone could be printed
> > instead and the name of the variable adjusted to make sense with the new
> > meaning -- up to you to decide).
> 
> Actually, I take it back. The other portion of the workaround is still
> active (in mm/fault.c), and this chunk announces it, so I'm going to
> leave it as-is.

 Ah, OK then.  Thanks for double-checking.

  Maciej

WARNING: multiple messages have this Message-ID (diff)
From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Kees Cook <keescook@chromium.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jeremy Fitzhardinge <jeremy@goop.org>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Alex Shi <alex.shi@intel.com>,
	Borislav Petkov <borislav.petkov@amd.com>,
	Alexander Duyck <alexander.h.duyck@intel.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"kernel-hardening@lists.openwall.com" 
	<kernel-hardening@lists.openwall.com>,
	Dan Rosenberg <drosenberg@vsecurity.com>,
	Julien Tinnes <jln@google.com>, Will Drewry <wad@chromium.org>,
	Eric Northup <digitaleric@google.com>
Subject: Re: [PATCH] x86: make IDT read-only
Date: Tue, 9 Apr 2013 00:42:49 +0100 (BST)	[thread overview]
Message-ID: <alpine.LFD.2.03.1304090042220.25182@linux-mips.org> (raw)
In-Reply-To: <CAGXu5j+fWeinnBr3JLkLt-M4N8uSXzP9MiRF20h37_WABQ1Rrw@mail.gmail.com>

On Mon, 8 Apr 2013, Kees Cook wrote:

> >  FWIW the change looks reasonable to me, however given that that it makes
> > the arrangement unconditional and there is no longer a workaround to
> > enable I think it would make sense to remove the conditional block quoted
> > above altogether, along with the f00f_workaround_enabled variable itself
> > (alternatively "Intel Pentium with F0 0F bug" alone could be printed
> > instead and the name of the variable adjusted to make sense with the new
> > meaning -- up to you to decide).
> 
> Actually, I take it back. The other portion of the workaround is still
> active (in mm/fault.c), and this chunk announces it, so I'm going to
> leave it as-is.

 Ah, OK then.  Thanks for double-checking.

  Maciej

  reply	other threads:[~2013-04-08 23:42 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 22:43 [kernel-hardening] [PATCH] x86: make IDT read-only Kees Cook
2013-04-08 22:43 ` Kees Cook
2013-04-08 22:43 ` Kees Cook
2013-04-08 22:47 ` [kernel-hardening] " H. Peter Anvin
2013-04-08 22:47   ` H. Peter Anvin
2013-04-08 22:47   ` H. Peter Anvin
2013-04-08 22:55   ` [kernel-hardening] " Kees Cook
2013-04-08 22:55     ` Kees Cook
2013-04-08 22:55     ` Kees Cook
2013-04-08 22:48 ` [kernel-hardening] " H. Peter Anvin
2013-04-08 22:48   ` H. Peter Anvin
2013-04-08 22:48   ` H. Peter Anvin
2013-04-09  9:23   ` [kernel-hardening] " Thomas Gleixner
2013-04-09  9:23     ` Thomas Gleixner
2013-04-09 18:22     ` [kernel-hardening] " Kees Cook
2013-04-09 18:22       ` Kees Cook
2013-04-09 18:26       ` H. Peter Anvin
2013-04-09 18:26         ` H. Peter Anvin
2013-04-09 18:31         ` Kees Cook
2013-04-09 18:31           ` Kees Cook
2013-04-09 18:39           ` H. Peter Anvin
2013-04-09 18:39             ` H. Peter Anvin
2013-04-09 18:46             ` Kees Cook
2013-04-09 18:46               ` Kees Cook
2013-04-09 18:50               ` H. Peter Anvin
2013-04-09 18:50                 ` H. Peter Anvin
2013-04-09 18:53                 ` Kees Cook
2013-04-09 18:53                   ` Kees Cook
2013-04-09 18:54               ` Eric Northup
2013-04-09 18:54                 ` Eric Northup
2013-04-09 18:59                 ` H. Peter Anvin
2013-04-09 18:59                   ` H. Peter Anvin
2013-04-10  0:43                 ` [kernel-hardening] Readonly GDT H. Peter Anvin
2013-04-10  0:43                   ` H. Peter Anvin
2013-04-10  0:43                   ` H. Peter Anvin
2013-04-10  0:53                   ` [kernel-hardening] " Steven Rostedt
2013-04-10  0:53                     ` Steven Rostedt
2013-04-10  0:53                     ` Steven Rostedt
2013-04-10  0:58                     ` [kernel-hardening] " H. Peter Anvin
2013-04-10  0:58                       ` H. Peter Anvin
2013-04-10  0:58                       ` H. Peter Anvin
2013-04-10  9:42                   ` [kernel-hardening] Re: [Xen-devel] " Jan Beulich
2013-04-10  9:42                     ` Jan Beulich
2013-04-10  9:42                     ` Jan Beulich
2013-04-10 14:16                     ` [kernel-hardening] " H. Peter Anvin
2013-04-10 14:16                       ` H. Peter Anvin
2013-04-10 14:16                       ` H. Peter Anvin
2013-04-10 18:28                     ` [kernel-hardening] " H. Peter Anvin
2013-04-10 18:28                       ` H. Peter Anvin
2013-04-10  9:41               ` [kernel-hardening] Re: [PATCH] x86: make IDT read-only Ingo Molnar
2013-04-10  9:41                 ` Ingo Molnar
2013-04-10  0:03       ` H. Peter Anvin
2013-04-10  0:03         ` H. Peter Anvin
2013-04-10  9:52         ` Ingo Molnar
2013-04-10  9:52           ` Ingo Molnar
2013-04-09  9:23   ` Thomas Gleixner
2013-04-09  9:45   ` [kernel-hardening] " Eric W. Biederman
2013-04-09  9:45     ` Eric W. Biederman
2013-04-09  9:45     ` Eric W. Biederman
2013-04-10  9:57     ` [kernel-hardening] " Ingo Molnar
2013-04-10  9:57       ` Ingo Molnar
2013-04-10  9:57       ` Ingo Molnar
2013-04-10 10:40       ` [kernel-hardening] " Eric W. Biederman
2013-04-10 10:40         ` Eric W. Biederman
2013-04-10 10:40         ` Eric W. Biederman
2013-04-10 16:31         ` [kernel-hardening] " Eric Northup
2013-04-10 16:31           ` Eric Northup
2013-04-10 16:31           ` Eric Northup
2013-04-10 16:48           ` [kernel-hardening] " H. Peter Anvin
2013-04-10 16:48             ` H. Peter Anvin
2013-04-10 16:48             ` H. Peter Anvin
2013-04-08 22:56 ` Maciej W. Rozycki
2013-04-08 22:56 ` [kernel-hardening] " Maciej W. Rozycki
2013-04-08 22:56   ` Maciej W. Rozycki
2013-04-08 23:00   ` [kernel-hardening] " Kees Cook
2013-04-08 23:00     ` Kees Cook
2013-04-08 23:00     ` Kees Cook
2013-04-08 23:05   ` [kernel-hardening] " Kees Cook
2013-04-08 23:05     ` Kees Cook
2013-04-08 23:05     ` Kees Cook
2013-04-08 23:42     ` Maciej W. Rozycki [this message]
2013-04-08 23:42       ` Maciej W. Rozycki
2013-04-08 23:42       ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.03.1304090042220.25182@linux-mips.org \
    --to=macro@linux-mips.org \
    --cc=alex.shi@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=borislav.petkov@amd.com \
    --cc=digitaleric@google.com \
    --cc=drosenberg@vsecurity.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=jln@google.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wad@chromium.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.