From: Hugh Dickins <hughd@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Filipe Brandenburger <filbranden@google.com>,
Li Zefan <lizefan@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>,
Michel Lespinasse <walken@google.com>,
Markus Blank-Burian <burian@muenster.de>,
Shawn Bohrer <shawn.bohrer@gmail.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] cgroup: bring back kill_cnt to order css destruction
Date: Wed, 12 Feb 2014 16:38:25 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.1402121636290.5728@eggly.anvils> (raw)
In-Reply-To: <20140213002853.GC2916@htj.dyndns.org>
On Wed, 12 Feb 2014, Tejun Heo wrote:
>
> Not that your implementation is bad or anything but the patch itself
> somehow makes me cringe a bit. It's probably just because it has to
> add to the already overly complicated offline path. Guaranteeing
> strict offline ordering might be a good idea but at least for the
> immediate bug fix, I agree that the memcg specific fix seems better
> suited. Let's apply that one and reconsider this one if it turns out
> we do need strict offline reordering.
Yes, I agree completely - thanks.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Hugh Dickins <hughd@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Filipe Brandenburger <filbranden@google.com>,
Li Zefan <lizefan@huawei.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Thelen <gthelen@google.com>,
Michel Lespinasse <walken@google.com>,
Markus Blank-Burian <burian@muenster.de>,
Shawn Bohrer <shawn.bohrer@gmail.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] cgroup: bring back kill_cnt to order css destruction
Date: Wed, 12 Feb 2014 16:38:25 -0800 (PST) [thread overview]
Message-ID: <alpine.LSU.2.11.1402121636290.5728@eggly.anvils> (raw)
In-Reply-To: <20140213002853.GC2916@htj.dyndns.org>
On Wed, 12 Feb 2014, Tejun Heo wrote:
>
> Not that your implementation is bad or anything but the patch itself
> somehow makes me cringe a bit. It's probably just because it has to
> add to the already overly complicated offline path. Guaranteeing
> strict offline ordering might be a good idea but at least for the
> immediate bug fix, I agree that the memcg specific fix seems better
> suited. Let's apply that one and reconsider this one if it turns out
> we do need strict offline reordering.
Yes, I agree completely - thanks.
Hugh
next prev parent reply other threads:[~2014-02-13 0:38 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 23:56 [PATCH] cgroup: use an ordered workqueue for cgroup destruction Hugh Dickins
2014-02-06 23:56 ` Hugh Dickins
2014-02-06 23:56 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.1402061541560.31342-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2014-02-07 13:45 ` Michal Hocko
2014-02-07 13:45 ` Michal Hocko
2014-02-07 13:45 ` Michal Hocko
2014-02-07 16:43 ` Johannes Weiner
2014-02-07 16:43 ` Johannes Weiner
2014-02-07 16:43 ` Johannes Weiner
[not found] ` <20140207164321.GE6963-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2014-02-10 15:46 ` Michal Hocko
2014-02-10 15:46 ` Michal Hocko
2014-02-10 15:46 ` Michal Hocko
2014-02-12 22:59 ` Hugh Dickins
2014-02-12 22:59 ` Hugh Dickins
2014-02-12 22:59 ` Hugh Dickins
[not found] ` <alpine.LSU.2.11.1402121417230.5029-fupSdm12i1nKWymIFiNcPA@public.gmane.org>
2014-02-12 23:06 ` [PATCH 2/2] cgroup: bring back kill_cnt to order css destruction Hugh Dickins
2014-02-12 23:06 ` Hugh Dickins
2014-02-12 23:06 ` Hugh Dickins
2014-02-13 0:28 ` Tejun Heo
2014-02-13 0:28 ` Tejun Heo
2014-02-13 0:38 ` Hugh Dickins [this message]
2014-02-13 0:38 ` Hugh Dickins
2014-02-13 0:09 ` [PATCH] Revert "cgroup: use an ordered workqueue for cgroup destruction" Tejun Heo
2014-02-13 0:09 ` Tejun Heo
2014-02-13 0:09 ` Tejun Heo
2014-02-07 14:04 ` [PATCH] cgroup: use an ordered workqueue for cgroup destruction Tejun Heo
2014-02-07 14:04 ` Tejun Heo
2014-02-07 14:37 ` Michal Hocko
2014-02-07 14:37 ` Michal Hocko
[not found] ` <20140207143740.GD5121-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2014-02-07 15:13 ` Tejun Heo
2014-02-07 15:13 ` Tejun Heo
2014-02-07 15:13 ` Tejun Heo
2014-02-07 15:28 ` Michal Hocko
2014-02-07 15:28 ` Michal Hocko
[not found] ` <20140207140402.GA3304-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-02-07 20:20 ` Hugh Dickins
2014-02-07 20:20 ` Hugh Dickins
2014-02-07 20:20 ` Hugh Dickins
2014-02-07 20:35 ` Tejun Heo
2014-02-07 20:35 ` Tejun Heo
2014-02-07 21:06 ` Hugh Dickins
2014-02-07 21:06 ` Hugh Dickins
2014-02-07 15:21 ` Tejun Heo
2014-02-07 15:21 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.11.1402121636290.5728@eggly.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=burian@muenster.de \
--cc=cgroups@vger.kernel.org \
--cc=filbranden@google.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=shawn.bohrer@gmail.com \
--cc=tj@kernel.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.