All of lore.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: sashiko-reviews@lists.linux.dev, vkoul@kernel.org,
	conor+dt@kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com,
	neil.armstrong@linaro.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY
Date: Tue, 28 Jul 2026 16:38:09 -0700	[thread overview]
Message-ID: <amk9YYzI+LqCHhcy@x1> (raw)
In-Reply-To: <8ccf1a36179881b1f9662e70d728322c62c88f78.camel@iscas.ac.cn>

On Thu, Jul 23, 2026 at 10:05:24PM +0800, Icenowy Zheng wrote: > 在 2026-07-23四的 08:47 +0000，sashiko-bot@kernel.org写道：
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider:
> > - [Medium] The 'reg' property is omitted from the 'required' list for
> > a memory-mapped PHY.
> > - [Medium] The 'avdd33-usb3-supply' is omitted from the 'required'
> > list based on software limitations rather than hardware description.
> 
> Well this is also to workaround the problem raised by Sashiko yourself
> at [1].
> 
> I didn't mention it in the log because I am not sure whether this is a
> real problem.
> 
> [1]
> https://sashiko.dev/#/patchset/20260507081710.4090814-1-zhengxingda%40iscas.ac.cn?part=6

I think Sashiko's comment on v1 was incorrect, and avdd33-usb3-supply
should be required.

Sashiko claimed that making avdd33-usb3-supply required would break
dtbs_check for boards that include th1520.dtsi but do not provide the
regulator. However, dtschema does not warn about missing properties if
the node is disabled [1]. Therefore, only boards that enable the usb phy
node would need to provide avdd33-usb3-supply.

Thanks,
Drew

[1] https://github.com/devicetree-org/dt-schema/blob/eb0e53d1c5b071865abbf7d251721431e8e6bd71/dtschema/dtb_validate.py#L256

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: sashiko-reviews@lists.linux.dev, vkoul@kernel.org,
	conor+dt@kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com,
	neil.armstrong@linaro.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY
Date: Tue, 28 Jul 2026 16:38:09 -0700	[thread overview]
Message-ID: <amk9YYzI+LqCHhcy@x1> (raw)
In-Reply-To: <8ccf1a36179881b1f9662e70d728322c62c88f78.camel@iscas.ac.cn>

On Thu, Jul 23, 2026 at 10:05:24PM +0800, Icenowy Zheng wrote: > 在 2026-07-23四的 08:47 +0000，sashiko-bot@kernel.org写道：
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider:
> > - [Medium] The 'reg' property is omitted from the 'required' list for
> > a memory-mapped PHY.
> > - [Medium] The 'avdd33-usb3-supply' is omitted from the 'required'
> > list based on software limitations rather than hardware description.
> 
> Well this is also to workaround the problem raised by Sashiko yourself
> at [1].
> 
> I didn't mention it in the log because I am not sure whether this is a
> real problem.
> 
> [1]
> https://sashiko.dev/#/patchset/20260507081710.4090814-1-zhengxingda%40iscas.ac.cn?part=6

I think Sashiko's comment on v1 was incorrect, and avdd33-usb3-supply
should be required.

Sashiko claimed that making avdd33-usb3-supply required would break
dtbs_check for boards that include th1520.dtsi but do not provide the
regulator. However, dtschema does not warn about missing properties if
the node is disabled [1]. Therefore, only boards that enable the usb phy
node would need to provide avdd33-usb3-supply.

Thanks,
Drew

[1] https://github.com/devicetree-org/dt-schema/blob/eb0e53d1c5b071865abbf7d251721431e8e6bd71/dtschema/dtb_validate.py#L256

  reply	other threads:[~2026-07-28 23:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  8:43 [PATCH v2 0/2] phy: add support for TH1520 USB PHY Icenowy Zheng
2026-07-23  8:43 ` Icenowy Zheng
2026-07-23  8:43 ` [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head " Icenowy Zheng
2026-07-23  8:43   ` Icenowy Zheng
2026-07-23  8:47   ` sashiko-bot
2026-07-23  8:47     ` sashiko-bot
2026-07-23 14:05     ` Icenowy Zheng
2026-07-23 14:05       ` Icenowy Zheng
2026-07-28 23:38       ` Drew Fustini [this message]
2026-07-28 23:38         ` Drew Fustini
2026-07-23 14:09     ` Icenowy Zheng
2026-07-23 14:09       ` Icenowy Zheng
2026-07-28 21:08       ` Drew Fustini
2026-07-28 21:08         ` Drew Fustini
2026-07-23  8:43 ` [PATCH v2 2/2] phy: add a driver " Icenowy Zheng
2026-07-23  8:43   ` Icenowy Zheng
2026-07-23  8:55   ` sashiko-bot
2026-07-23  8:55     ` sashiko-bot
2026-07-28 21:44   ` Drew Fustini
2026-07-28 21:44     ` Drew Fustini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amk9YYzI+LqCHhcy@x1 \
    --to=fustini@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    --cc=zhengxingda@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.