All of lore.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Wei Fu <wefu@redhat.com>,
	Drew Fustini <dfustini@tenstorrent.com>,
	Jisheng Zhang <jszhang@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Han Gao <rabenda.cn@gmail.com>,
	Yao Zi <ziyao@disroot.org>, Icenowy Zheng <uwu@icenowy.me>
Subject: Re: [PATCH v2 2/2] phy: add a driver for T-Head TH1520 USB PHY
Date: Tue, 28 Jul 2026 14:44:46 -0700	[thread overview]
Message-ID: <amkizlBd6lUUG08g@x1> (raw)
In-Reply-To: <20260723084316.3573714-3-zhengxingda@iscas.ac.cn>

On Thu, Jul 23, 2026 at 04:43:16PM +0800, Icenowy Zheng wrote:
> The USB PHY on T-Head TH1520 SoC is a Synopsys USB 3.0 FemtoPHY, with
> some PHY parameters exported as another system controller along with it.
> 
> As a few PHY parameters' default value isn't ready to work, add a driver
> configuring them before letting the PHY run, in addition to
> clock/reset/regulator management.

The second paragragh might read better as:

"A few PHY parameters have unusable defaults. Add a driver that programs
them before releasing the PHY from reset. [..]"

Thanks,
Drew

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Wei Fu <wefu@redhat.com>,
	Drew Fustini <dfustini@tenstorrent.com>,
	Jisheng Zhang <jszhang@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Han Gao <rabenda.cn@gmail.com>,
	Yao Zi <ziyao@disroot.org>, Icenowy Zheng <uwu@icenowy.me>
Subject: Re: [PATCH v2 2/2] phy: add a driver for T-Head TH1520 USB PHY
Date: Tue, 28 Jul 2026 14:44:46 -0700	[thread overview]
Message-ID: <amkizlBd6lUUG08g@x1> (raw)
In-Reply-To: <20260723084316.3573714-3-zhengxingda@iscas.ac.cn>

On Thu, Jul 23, 2026 at 04:43:16PM +0800, Icenowy Zheng wrote:
> The USB PHY on T-Head TH1520 SoC is a Synopsys USB 3.0 FemtoPHY, with
> some PHY parameters exported as another system controller along with it.
> 
> As a few PHY parameters' default value isn't ready to work, add a driver
> configuring them before letting the PHY run, in addition to
> clock/reset/regulator management.

The second paragragh might read better as:

"A few PHY parameters have unusable defaults. Add a driver that programs
them before releasing the PHY from reset. [..]"

Thanks,
Drew

  parent reply	other threads:[~2026-07-28 21:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  8:43 [PATCH v2 0/2] phy: add support for TH1520 USB PHY Icenowy Zheng
2026-07-23  8:43 ` Icenowy Zheng
2026-07-23  8:43 ` [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head " Icenowy Zheng
2026-07-23  8:43   ` Icenowy Zheng
2026-07-23  8:47   ` sashiko-bot
2026-07-23  8:47     ` sashiko-bot
2026-07-23 14:05     ` Icenowy Zheng
2026-07-23 14:05       ` Icenowy Zheng
2026-07-28 23:38       ` Drew Fustini
2026-07-28 23:38         ` Drew Fustini
2026-07-23 14:09     ` Icenowy Zheng
2026-07-23 14:09       ` Icenowy Zheng
2026-07-28 21:08       ` Drew Fustini
2026-07-28 21:08         ` Drew Fustini
2026-07-23  8:43 ` [PATCH v2 2/2] phy: add a driver " Icenowy Zheng
2026-07-23  8:43   ` Icenowy Zheng
2026-07-23  8:55   ` sashiko-bot
2026-07-23  8:55     ` sashiko-bot
2026-07-28 21:44   ` Drew Fustini [this message]
2026-07-28 21:44     ` Drew Fustini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amkizlBd6lUUG08g@x1 \
    --to=fustini@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dfustini@tenstorrent.com \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rabenda.cn@gmail.com \
    --cc=robh@kernel.org \
    --cc=uwu@icenowy.me \
    --cc=vkoul@kernel.org \
    --cc=wefu@redhat.com \
    --cc=zhengxingda@iscas.ac.cn \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.