All of lore.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: sashiko-reviews@lists.linux.dev, vkoul@kernel.org,
	conor+dt@kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com,
	neil.armstrong@linaro.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY
Date: Tue, 28 Jul 2026 14:08:10 -0700	[thread overview]
Message-ID: <amkaOo9mkjJfDNsf@x1> (raw)
In-Reply-To: <8c2d675115b25107bf463cbbb6a377f80c46e592.camel@iscas.ac.cn>

On Thu, Jul 23, 2026 at 10:09:48PM +0800, Icenowy Zheng wrote:
> 在 2026-07-23四的 08:47 +0000，sashiko-bot@kernel.org写道：
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider:
> > - [Medium] The 'reg' property is omitted from the 'required' list for
> > a memory-mapped PHY.
> > - [Medium] The 'avdd33-usb3-supply' is omitted from the 'required'
> > list based on software limitations rather than hardware description.
> 
> BTW the power rail is expected to be always on at least according to
> the schematics of multiple boards, as mentioned in the next patch.
> 
> Thanks,
> Icenowy

That makes sense for the supply. However, I think the earlier point
about 'reg' property is probably valid. Woudln't all users of this
compatible need the base address?

Thanks,
Drew

WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <fustini@kernel.org>
To: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Cc: sashiko-reviews@lists.linux.dev, vkoul@kernel.org,
	conor+dt@kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, robh@kernel.org, olteanv@gmail.com,
	neil.armstrong@linaro.org
Subject: Re: [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head TH1520 USB PHY
Date: Tue, 28 Jul 2026 14:08:10 -0700	[thread overview]
Message-ID: <amkaOo9mkjJfDNsf@x1> (raw)
In-Reply-To: <8c2d675115b25107bf463cbbb6a377f80c46e592.camel@iscas.ac.cn>

On Thu, Jul 23, 2026 at 10:09:48PM +0800, Icenowy Zheng wrote:
> 在 2026-07-23四的 08:47 +0000，sashiko-bot@kernel.org写道：
> > Thank you for your contribution! Sashiko AI review found 2 potential
> > issue(s) to consider:
> > - [Medium] The 'reg' property is omitted from the 'required' list for
> > a memory-mapped PHY.
> > - [Medium] The 'avdd33-usb3-supply' is omitted from the 'required'
> > list based on software limitations rather than hardware description.
> 
> BTW the power rail is expected to be always on at least according to
> the schematics of multiple boards, as mentioned in the next patch.
> 
> Thanks,
> Icenowy

That makes sense for the supply. However, I think the earlier point
about 'reg' property is probably valid. Woudln't all users of this
compatible need the base address?

Thanks,
Drew

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-07-28 21:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23  8:43 [PATCH v2 0/2] phy: add support for TH1520 USB PHY Icenowy Zheng
2026-07-23  8:43 ` Icenowy Zheng
2026-07-23  8:43 ` [PATCH v2 1/2] dt-bindings: phy: add binding for T-Head " Icenowy Zheng
2026-07-23  8:43   ` Icenowy Zheng
2026-07-23  8:47   ` sashiko-bot
2026-07-23  8:47     ` sashiko-bot
2026-07-23 14:05     ` Icenowy Zheng
2026-07-23 14:05       ` Icenowy Zheng
2026-07-28 23:38       ` Drew Fustini
2026-07-28 23:38         ` Drew Fustini
2026-07-23 14:09     ` Icenowy Zheng
2026-07-23 14:09       ` Icenowy Zheng
2026-07-28 21:08       ` Drew Fustini [this message]
2026-07-28 21:08         ` Drew Fustini
2026-07-23  8:43 ` [PATCH v2 2/2] phy: add a driver " Icenowy Zheng
2026-07-23  8:43   ` Icenowy Zheng
2026-07-23  8:55   ` sashiko-bot
2026-07-23  8:55     ` sashiko-bot
2026-07-29 15:51     ` Drew Fustini
2026-07-29 15:51       ` Drew Fustini
2026-07-28 21:44   ` Drew Fustini
2026-07-28 21:44     ` Drew Fustini
2026-08-15  0:07 ` [PATCH v2 0/2] phy: add support for " Drew Fustini
2026-08-15  0:07   ` Drew Fustini
2026-08-15  4:20   ` Icenowy Zheng
2026-08-15  4:20     ` Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=amkaOo9mkjJfDNsf@x1 \
    --to=fustini@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    --cc=zhengxingda@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.