From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, qiwenjie@xiaomi.com,
linux-kernel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while it's unlinked
Date: Tue, 25 Aug 2026 15:29:18 +0000 [thread overview]
Message-ID: <ao20zq7Qy8hUnM_g@google.com> (raw)
In-Reply-To: <20260825023925.230986-1-qiwenjie@xiaomi.com>
On 08/25, Wenjie Qi wrote:
> Hi Jaegeuk,
>
> Thanks, v3 addresses the two error propagation issues I reported.
>
> I have one question about successful rollback in a DIRSYNC directory.
> f2fs_unlink() runs f2fs_sync_fs() after __do_unlink() succeeds, but
> f2fs_symlink() calls __do_unlink() directly and returns without a
> checkpoint.
DIRSYNC is reachable only when there was no error until then?
>
> Since f2fs_add_link() has already completed before symlink construction
> fails, could a checkpoint between the addition and rollback make the
> addition durable while the deletion remains dirty? Should the successful
> rollback run f2fs_sync_fs() when IS_DIRSYNC(dir), while keeping the
> original construction error as the return value?
>
> Regards,
> Wenjie
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Wenjie Qi <qwjhust@gmail.com>
Cc: chao@kernel.org, qiwenjie@xiaomi.com,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: don't leave the hashed inode while it's unlinked
Date: Tue, 25 Aug 2026 15:29:18 +0000 [thread overview]
Message-ID: <ao20zq7Qy8hUnM_g@google.com> (raw)
In-Reply-To: <20260825023925.230986-1-qiwenjie@xiaomi.com>
On 08/25, Wenjie Qi wrote:
> Hi Jaegeuk,
>
> Thanks, v3 addresses the two error propagation issues I reported.
>
> I have one question about successful rollback in a DIRSYNC directory.
> f2fs_unlink() runs f2fs_sync_fs() after __do_unlink() succeeds, but
> f2fs_symlink() calls __do_unlink() directly and returns without a
> checkpoint.
DIRSYNC is reachable only when there was no error until then?
>
> Since f2fs_add_link() has already completed before symlink construction
> fails, could a checkpoint between the addition and rollback make the
> addition durable while the deletion remains dirty? Should the successful
> rollback run f2fs_sync_fs() when IS_DIRSYNC(dir), while keeping the
> original construction error as the return value?
>
> Regards,
> Wenjie
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-08-25 15:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 20:01 [PATCH] f2fs: don't leave the hashed inode while it's unlinked Jaegeuk Kim
2026-08-18 20:01 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-19 2:56 ` Chao Yu via Linux-f2fs-devel
2026-08-19 2:56 ` Chao Yu
2026-08-21 15:23 ` [f2fs-dev] [PATCH v2] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-21 15:23 ` Jaegeuk Kim
2026-08-22 7:37 ` Chao Yu via Linux-f2fs-devel
2026-08-22 7:37 ` Chao Yu
2026-08-23 9:56 ` Wenjie Qi
2026-08-23 9:56 ` Wenjie Qi
2026-08-24 15:12 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-08-24 15:12 ` Jaegeuk Kim
2026-08-24 13:16 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-08-24 13:16 ` Chao Yu
2026-08-24 20:12 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim
2026-08-24 20:12 ` Jaegeuk Kim via Linux-f2fs-devel
2026-08-25 2:15 ` Chao Yu
2026-08-25 2:15 ` Chao Yu via Linux-f2fs-devel
2026-08-25 2:39 ` Wenjie Qi
2026-08-25 2:39 ` Wenjie Qi
2026-08-25 15:29 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2026-08-25 15:29 ` [f2fs-dev] " Jaegeuk Kim
2026-08-25 17:31 ` Wenjie Qi
2026-08-25 17:31 ` Wenjie Qi
2026-08-26 0:11 ` [f2fs-dev] " Jaegeuk Kim
2026-08-26 0:11 ` Jaegeuk Kim via Linux-f2fs-devel
2026-08-26 3:41 ` Wenjie Qi
2026-08-26 3:41 ` [f2fs-dev] " Wenjie Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao20zq7Qy8hUnM_g@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwenjie@xiaomi.com \
--cc=qwjhust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.