All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Wang Yang <yang.wang@deepcomputing.io>
Cc: Yixun Lan <dlan@kernel.org>, Benson Leung <bleung@chromium.org>,
	Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Guenter Roeck <groeck@chromium.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Sandie Cao <sandie.cao@deepcomputing.io>,
	devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] bus: Add SpacemiT K3 eSPI controller support
Date: Wed, 18 Nov 2026 22:10:43 +0100	[thread overview]
Message-ID: <av4UUyCtDBJNU0h5@aurel32.net> (raw)
In-Reply-To: <20261118085742.1817536-4-yang.wang@deepcomputing.io>

Hi,

On 2026-11-18 16:57, Wang Yang wrote:
> Initialize and recover the K3 eSPI peripheral channel before populating
> its children. Keep controller register programming, clock and reset
> handling in the controller driver rather than in the EC transport.
> 
> Port the existing vendor-derived implementation separately from the EC
> client. The controller logic comes from the vendor BSP at revision
> 29b78afb484b, authored by goumin <min.gou@spacemit.com>. Preserve its
> register programming and link-recovery behavior.
> 
> No matching SpacemiT eSPI submission was found in the archived SPI,
> RISC-V and Chrome platform searches used for this port.

While this is correct, please note that there was a try from AMD to 
define a eSPI bus framework back in August [1]. However I haven't 
spotted any further progress.

Anyway thanks for your work, I guess this can also be useful for the EC 
controller on the K3 Pico-ITX boards, which drives among other things 
the fan PWM.

Regards
Aurelien

[1] https://lore.kernel.org/all/20260804115259.4065638-1-krishnamoorthi.m@amd.com/

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

WARNING: multiple messages have this Message-ID (diff)
From: Aurelien Jarno <aurelien@aurel32.net>
To: Wang Yang <yang.wang@deepcomputing.io>
Cc: Yixun Lan <dlan@kernel.org>, Benson Leung <bleung@chromium.org>,
	Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	Guenter Roeck <groeck@chromium.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Sandie Cao <sandie.cao@deepcomputing.io>,
	devicetree@vger.kernel.org, chrome-platform@lists.linux.dev,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/9] bus: Add SpacemiT K3 eSPI controller support
Date: Wed, 18 Nov 2026 22:10:43 +0100	[thread overview]
Message-ID: <av4UUyCtDBJNU0h5@aurel32.net> (raw)
In-Reply-To: <20261118085742.1817536-4-yang.wang@deepcomputing.io>

Hi,

On 2026-11-18 16:57, Wang Yang wrote:
> Initialize and recover the K3 eSPI peripheral channel before populating
> its children. Keep controller register programming, clock and reset
> handling in the controller driver rather than in the EC transport.
> 
> Port the existing vendor-derived implementation separately from the EC
> client. The controller logic comes from the vendor BSP at revision
> 29b78afb484b, authored by goumin <min.gou@spacemit.com>. Preserve its
> register programming and link-recovery behavior.
> 
> No matching SpacemiT eSPI submission was found in the archived SPI,
> RISC-V and Chrome platform searches used for this port.

While this is correct, please note that there was a try from AMD to 
define a eSPI bus framework back in August [1]. However I haven't 
spotted any further progress.

Anyway thanks for your work, I guess this can also be useful for the EC 
controller on the K3 Pico-ITX boards, which drives among other things 
the fan PWM.

Regards
Aurelien

[1] https://lore.kernel.org/all/20260804115259.4065638-1-krishnamoorthi.m@amd.com/

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2026-11-18 21:10 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:57 [PATCH 0/9] Add SpacemiT K3 FML13V05 EC keyboard support Wang Yang
2026-11-18  8:57 ` Wang Yang
2026-11-18  8:57 ` [PATCH 1/9] dt-bindings: bus: Add SpacemiT K3 eSPI controller Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  9:18   ` sashiko-bot
2026-11-18 17:51   ` Conor Dooley
2026-11-18 17:51     ` Conor Dooley
2026-11-18 22:10     ` Aurelien Jarno
2026-11-18 22:10       ` Aurelien Jarno
2026-11-19  9:05       ` Wang Yang
2026-11-19  9:05         ` Wang Yang
2026-11-19 11:02         ` Conor Dooley
2026-11-19 11:02           ` Conor Dooley
2026-11-19 11:10           ` Conor Dooley
2026-11-19 11:10             ` Conor Dooley
2026-11-18  8:57 ` [PATCH 2/9] dt-bindings: embedded-controller: Add SpacemiT K3 EC window Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  8:57 ` [PATCH 3/9] bus: Add SpacemiT K3 eSPI controller support Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  9:23   ` sashiko-bot
2026-11-18 21:10   ` Aurelien Jarno [this message]
2026-11-18 21:10     ` Aurelien Jarno
2026-11-19  9:40     ` Wang Yang
2026-11-19  9:40       ` Wang Yang
2026-11-18  8:57 ` [PATCH 4/9] platform/chrome: Allow ChromeOS platform support on RISC-V Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  8:57 ` [PATCH 5/9] platform/chrome: Add SpacemiT K3 eSPI EC transport Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  9:33   ` sashiko-bot
2026-11-18  8:57 ` [PATCH 6/9] riscv: dts: spacemit: Add K3 eSPI pin group Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  9:08   ` sashiko-bot
2026-11-18  8:57 ` [PATCH 7/9] riscv: dts: spacemit: Describe the K3 eSPI controller Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  9:25   ` sashiko-bot
2026-11-18  8:57 ` [PATCH 8/9] riscv: dts: spacemit: Enable the FML13V05 EC keyboard Wang Yang
2026-11-18  8:57   ` Wang Yang
2026-11-18  9:20   ` sashiko-bot
2026-11-18  8:57 ` [PATCH 9/9] riscv: defconfig: Enable the FML13V05 EC keyboard modules Wang Yang
2026-11-18  8:57   ` Wang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av4UUyCtDBJNU0h5@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@kernel.org \
    --cc=groeck@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sandie.cao@deepcomputing.io \
    --cc=spacemit@lists.linux.dev \
    --cc=troy.mitchell@linux.spacemit.com \
    --cc=tzungbi@kernel.org \
    --cc=yang.wang@deepcomputing.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.