All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx+linux-hardening@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Alejandro Colomar <alx@kernel.org>,
	linux-hardening@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 18/19] treewide: s/\<strends\>/strsuffix/g
Date: Sun, 15 Nov 2026 17:23:36 +0100	[thread overview]
Message-ID: <avnb5iabDyCnXxpZ@devuan> (raw)
In-Reply-To: <43c991a975d649c11706714e05ab9bd438e0d7d5.camel@perches.com>

[-- Attachment #1: Type: text/plain, Size: 1125 bytes --]

Hi Joe,

> Date: 2026-11-15 08:15:52-0800
> From: Joe Perches <joe@perches.com>
>
> On Sat, 2026-11-14 at 16:24 +0100, Alejandro Colomar wrote:
> > Except for the changes to "lib/tests/string_kunit.c", this was
> > a scripted change:
> > 
> > 	$ git ls-files \
> > 	| grep '\.[ch]$' \
> > 	| grep -v -e ^tools/ -e ^scripts/ -e ^include/ \
> > 	| xargs grep -l strends \
> > 	| xargs sed -i 's/strends/strsuffix/g';
> 
> You should really use coccinelle (spatch)

For less trivial stuff, I'd go for a semantic patch, but given this is
a simple textual replacement, sed(1) seems simpler, and good enough.
Do you expect any differences between them?

> and this should probably be 2 patches.

Ok; I'll split them.  I'll first adapt the tests, and then the script
will work fully automated.

> 
> https://coccinelle.gitlabpages.inria.fr/website/docs/main_grammar016.html
> 
> something like:
> 
> @@
> expression a1;
> expression a2;
> @@
> 
> -	strends(a1, a2)
> +	strsuffix(a1, a2)

Thanks for the semantic patch!


Have a lovely day!
Alex

-- 
<https://www.alejandro-colomar.es>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2026-11-15 16:23 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 15:21 [PATCH v6 00/19] Add strprefix() and fix a bug with it Alejandro Colomar
2026-11-14 15:21 ` [PATCH v6 01/19] string: Add streq() Alejandro Colomar
2026-11-14 15:22 ` [PATCH v6 02/19] string: Add strprefix() Alejandro Colomar
2026-11-14 15:28   ` Joe Perches
2026-11-14 17:03     ` Alejandro Colomar
2026-11-14 18:35       ` Alejandro Colomar
2026-11-14 15:53   ` Joe Perches
2026-11-14 16:59     ` Alejandro Colomar
2026-11-14 18:24       ` Joe Perches
2026-11-14 19:00         ` Alejandro Colomar
2026-11-14 19:49     ` Off-by-one in arch/mips/bcm47xx/time.c (was: [PATCH v6 02/19] string: Add strprefix()) Alejandro Colomar
2026-11-16 11:00       ` Andy Shevchenko
2026-11-16 11:04         ` Alejandro Colomar
2026-11-16 11:53         ` David Laight
2026-11-14 15:22 ` [PATCH v6 03/19] string: Document corner-case misbehavior in str_has_prefix() for empty prefix Alejandro Colomar
2026-11-14 15:22 ` [PATCH v6 04/19] device property: Fix fwnode_name_eq() for empty node names Alejandro Colomar
2026-11-16  9:52   ` Sakari Ailus
2026-11-14 15:22 ` [PATCH v6 05/19] stddef: Add const_cast() Alejandro Colomar
2026-11-14 15:22 ` [PATCH v6 06/19] string: Add [C]QChar_of() and QVoid_of() Alejandro Colomar
2026-11-14 15:22 ` [PATCH v6 07/19] string: Make strprefix() const-qualifier-generic Alejandro Colomar
2026-11-14 15:22 ` [PATCH v6 08/19] perf map: Use bool for return type instead of int Alejandro Colomar
2026-11-14 15:22 ` [PATCH v6 09/19] string: Make strstarts() a legacy alias for strprefix() Alejandro Colomar
2026-11-14 15:33   ` sashiko-bot
2026-11-14 15:51     ` Alejandro Colomar
2026-11-14 17:52       ` Alejandro Colomar
2026-11-14 15:23 ` [PATCH v6 10/19] platform/x86: hp-bioscfg: Rename local variable Alejandro Colomar
2026-11-14 16:04   ` Joe Perches
2026-11-14 17:08     ` Alejandro Colomar
2026-11-14 15:23 ` [PATCH v6 11/19] treewide: s/strstarts/strprefix/g Alejandro Colomar
2026-11-14 15:23 ` [PATCH v6 12/19] string: Remove strstarts() Alejandro Colomar
2026-11-14 15:29   ` sashiko-bot
2026-11-14 15:45     ` Alejandro Colomar
2026-11-14 15:23 ` [PATCH v6 13/19] s390/test_unwind: Use bool for booleans Alejandro Colomar
2026-11-14 15:23 ` [PATCH v6 14/19] treewide: Replace boolean uses of str_has_prefix() by strprefix() Alejandro Colomar
2026-11-14 15:23 ` [PATCH v6 15/19] treewide: Replace some " Alejandro Colomar
2026-11-14 15:34   ` sashiko-bot
2026-11-14 15:47     ` Alejandro Colomar
2026-11-14 15:23 ` [PATCH v6 16/19] string: Add strsuffix() Alejandro Colomar
2026-11-14 15:24 ` [PATCH v6 17/19] string: Make strends() a legacy alias for strsuffix() Alejandro Colomar
2026-11-14 15:24 ` [PATCH v6 18/19] treewide: s/\<strends\>/strsuffix/g Alejandro Colomar
2026-11-15 16:15   ` Joe Perches
2026-11-15 16:23     ` Alejandro Colomar [this message]
2026-11-14 15:24 ` [PATCH v6 19/19] string: Remove strends() Alejandro Colomar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=avnb5iabDyCnXxpZ@devuan \
    --to=alx+linux-hardening@kernel.org \
    --cc=alx@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.