All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Gavin Shan <gshan@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	shan gavin <shan.gavin@gmail.com>,
	kvm@vger.kernel.org, maz@kernel.org,
	linux-kernel@vger.kernel.org,
	andrew jones <andrew.jones@linux.dev>,
	yihyu@redhat.com, linux-kselftest@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35
Date: Wed, 10 Aug 2022 11:14:21 +0200	[thread overview]
Message-ID: <bb97efaf-4f58-c192-a489-e71ebbebce8c@redhat.com> (raw)
In-Reply-To: <797306043.114963.1660047714774.JavaMail.zimbra@efficios.com>

On 8/9/22 14:21, Mathieu Desnoyers wrote:
>> For kvm/selftests, there are 3 architectures involved actually. So we
>> just need consider 4 cases: aarch64, x86, s390 and other. For other
>> case, we just use __builtin_thread_pointer() to maintain code's
>> integrity, but it's not called at all.
>>
>> I think kvm/selftest is always relying on glibc if I'm correct.
> All those are handled in the rseq selftests and in librseq. Why duplicate all that logic again?

Yeah, rseq_test should reuse librseq code.  The simplest way,
if slightly hackish, is to do something like

diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
index 690b499c3471..6c192b0ec304 100644
--- a/tools/testing/selftests/kvm/Makefile
+++ b/tools/testing/selftests/kvm/Makefile
@@ -37,6 +37,7 @@ ifeq ($(ARCH),riscv)
  	UNAME_M := riscv
  endif
  
  LIBKVM += lib/assert.c
  LIBKVM += lib/elf.c
  LIBKVM += lib/guest_modes.c
@@ -198,7 +199,7 @@ endif
  CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \
  	-fno-stack-protector -fno-PIE -I$(LINUX_TOOL_INCLUDE) \
  	-I$(LINUX_TOOL_ARCH_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude \
-	-I$(<D) -Iinclude/$(UNAME_M) -I.. $(EXTRA_CFLAGS) $(KHDR_INCLUDES)
+	-I$(<D) -Iinclude/$(UNAME_M) -I.. $(EXTRA_CFLAGS) $(KHDR_INCLUDES) -I../rseq
  
  no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
          $(CC) -Werror -no-pie -x c - -o "$$TMP", -no-pie)


and just #include "../rseq/rseq.c" in rseq_test.c.

Thanks,

Paolo

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Gavin Shan <gshan@redhat.com>
Cc: Florian Weimer <fweimer@redhat.com>,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	maz@kernel.org, oliver upton <oliver.upton@linux.dev>,
	andrew jones <andrew.jones@linux.dev>,
	seanjc@google.com, yihyu@redhat.com,
	shan gavin <shan.gavin@gmail.com>
Subject: Re: [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35
Date: Wed, 10 Aug 2022 11:14:21 +0200	[thread overview]
Message-ID: <bb97efaf-4f58-c192-a489-e71ebbebce8c@redhat.com> (raw)
In-Reply-To: <797306043.114963.1660047714774.JavaMail.zimbra@efficios.com>

On 8/9/22 14:21, Mathieu Desnoyers wrote:
>> For kvm/selftests, there are 3 architectures involved actually. So we
>> just need consider 4 cases: aarch64, x86, s390 and other. For other
>> case, we just use __builtin_thread_pointer() to maintain code's
>> integrity, but it's not called at all.
>>
>> I think kvm/selftest is always relying on glibc if I'm correct.
> All those are handled in the rseq selftests and in librseq. Why duplicate all that logic again?

Yeah, rseq_test should reuse librseq code.  The simplest way,
if slightly hackish, is to do something like

diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
index 690b499c3471..6c192b0ec304 100644
--- a/tools/testing/selftests/kvm/Makefile
+++ b/tools/testing/selftests/kvm/Makefile
@@ -37,6 +37,7 @@ ifeq ($(ARCH),riscv)
  	UNAME_M := riscv
  endif
  
  LIBKVM += lib/assert.c
  LIBKVM += lib/elf.c
  LIBKVM += lib/guest_modes.c
@@ -198,7 +199,7 @@ endif
  CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \
  	-fno-stack-protector -fno-PIE -I$(LINUX_TOOL_INCLUDE) \
  	-I$(LINUX_TOOL_ARCH_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude \
-	-I$(<D) -Iinclude/$(UNAME_M) -I.. $(EXTRA_CFLAGS) $(KHDR_INCLUDES)
+	-I$(<D) -Iinclude/$(UNAME_M) -I.. $(EXTRA_CFLAGS) $(KHDR_INCLUDES) -I../rseq
  
  no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \
          $(CC) -Werror -no-pie -x c - -o "$$TMP", -no-pie)


and just #include "../rseq/rseq.c" in rseq_test.c.

Thanks,

Paolo


  parent reply	other threads:[~2022-08-10  9:14 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09  6:06 [PATCH 0/2] kvm/selftests: Two rseq_test fixes Gavin Shan
2022-08-09  6:06 ` Gavin Shan
2022-08-09  6:06 ` [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35 Gavin Shan
2022-08-09  6:06   ` Gavin Shan
2022-08-09  6:33   ` Florian Weimer
2022-08-09  6:33     ` Florian Weimer
2022-08-09  8:45     ` Gavin Shan
2022-08-09  8:45       ` Gavin Shan
2022-08-09  7:16       ` Florian Weimer
2022-08-09  7:16         ` Florian Weimer
2022-08-09  9:27         ` Gavin Shan
2022-08-09  9:27           ` Gavin Shan
2022-08-09 12:21           ` Mathieu Desnoyers
2022-08-09 12:21             ` Mathieu Desnoyers
2022-08-09 13:44             ` Mathieu Desnoyers
2022-08-09 13:44               ` Mathieu Desnoyers
2022-08-09 21:38               ` Sean Christopherson
2022-08-09 21:38                 ` Sean Christopherson
2022-08-10  0:37                 ` Gavin Shan
2022-08-10  0:37                   ` Gavin Shan
2022-08-10 12:29                   ` Mathieu Desnoyers
2022-08-10 12:29                     ` Mathieu Desnoyers
2022-08-10 12:35                     ` Paolo Bonzini
2022-08-10 12:35                       ` Paolo Bonzini
2022-08-10 12:13                 ` Mathieu Desnoyers
2022-08-10 12:13                   ` Mathieu Desnoyers
2022-08-10 23:52                   ` Gavin Shan
2022-08-10 23:52                     ` Gavin Shan
2022-08-10  9:14             ` Paolo Bonzini [this message]
2022-08-10  9:14               ` Paolo Bonzini
2022-08-10  9:59               ` Gavin Shan
2022-08-10  9:59                 ` Gavin Shan
2022-08-10 12:17               ` Mathieu Desnoyers
2022-08-10 12:17                 ` Mathieu Desnoyers
2022-08-10 12:19                 ` Paolo Bonzini
2022-08-10 12:19                   ` Paolo Bonzini
2022-08-10 23:34                   ` Gavin Shan
2022-08-10 23:34                     ` Gavin Shan
2022-08-09  6:06 ` [PATCH 2/2] KVM: selftests: Use getcpu() instead of sched_getcpu() in rseq_test Gavin Shan
2022-08-09  6:06   ` Gavin Shan
2022-08-09  6:35   ` Florian Weimer
2022-08-09  6:35     ` Florian Weimer
2022-08-09  7:17     ` Florian Weimer
2022-08-09  7:17       ` Florian Weimer
2022-08-09  8:46       ` Gavin Shan
2022-08-09  8:46         ` Gavin Shan
2022-08-09 20:53         ` Sean Christopherson
2022-08-09 20:53           ` Sean Christopherson
2022-08-10  0:45           ` Gavin Shan
2022-08-10  0:45             ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb97efaf-4f58-c192-a489-e71ebbebce8c@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=andrew.jones@linux.dev \
    --cc=fweimer@redhat.com \
    --cc=gshan@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=maz@kernel.org \
    --cc=shan.gavin@gmail.com \
    --cc=yihyu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.