[Bug 85696] New: [regression] r600g+nine: Bioshock shader failure after recent changes

[Bug 85696] New: [regression] r600g+nine: Bioshock shader failure after recent changes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1762 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

            Bug ID: 85696
           Summary: [regression] r600g+nine: Bioshock shader failure after
                    recent changes
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r600
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: david@ixit.cz

HW: HD6550D

I tested Bioshock against mesa-git (+nine) about 10 days ago (I'd say maybe 6
days, but 10 for sure). It worked.

Now after gallium-nine rebase I get this error. I did research, tested old
kernel (3.16.2, now I'm with 3.16.6), tried older wine (1.7.28, now I'm at
1.7.29), but no change. Nine shader code should be also untouched.

I got report, that Bioshock on radeonsi (HD7950 I think) works with Nine
correctly.

Does anyone has idea, what can cause this issue?

error at : VFETCH     __, __, __, t153||FP@R5.w,       R20.x||@R5.y, __, __, __
  : operand value R20.x||@R5.y was not previously written to its gpr
error at : VFETCH     t150||FP@R6.x, t151||FP@R6.y, t152||FP@R6.z, __,      
R20.x||@R5.y, __, __, __
  : operand value R20.x||@R5.y was not previously written to its gpr
error at : VFETCH     __, __, __, t144||FP@R2.z,       R20.x||@R5.y, __, __, __
  : operand value R20.x||@R5.y was not previously written to its gpr
error at : VFETCH     __, __, __, t117||FP@R0.w,       R20.x||@R5.y, __, __, __
  : operand value R20.x||@R5.y was not previously written to its gpr
sb/sb_ra_checker.cpp:46:run: Assertion `sh.errors.empty()' failed.

Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3245 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] [regression] r600g+nine: Bioshock shader failure after recent changes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 326 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

--- Comment #1 from David Heidelberg (okias) <david@ixit.cz> ---
I realized it may be:

7b1c0cbc90d456384b0950ad21faa3c61a6b43ff
r600g: Implement sm5 UBO/sampler indexing

Reverted and recompiling.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1137 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] [regression] r600g+nine: Bioshock shader failure after recent changes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 610 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

David Heidelberg (okias) <david@ixit.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glenn.kennard@gmail.com

--- Comment #2 from David Heidelberg (okias) <david@ixit.cz> ---
http://cgit.freedesktop.org/mesa/mesa/commit/?id=7b1c0cbc90d456384b0950ad21faa3c61a6b43ff

Verified, this commit broke it on r600g. Adding Glenn Kennard to CC.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2084 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] [regression] r600g+nine: Bioshock shader failure after recent changes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 381 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

David Heidelberg (okias) <david@ixit.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bisected, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1099 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] [regression] r600g+nine: Bioshock shader failure after 7b1c0cbc90d456384b0950ad21faa3c61a6b43ff

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 653 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

David Heidelberg (okias) <david@ixit.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[regression] r600g+nine:    |[regression] r600g+nine:
                   |Bioshock shader failure     |Bioshock shader failure
                   |after recent changes        |after
                   |                            |7b1c0cbc90d456384b0950ad21f
                   |                            |aa3c61a6b43ff

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1246 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] [regression] r600g+nine: Bioshock shader failure after 7b1c0cbc90d456384b0950ad21faa3c61a6b43ff

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 313 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

--- Comment #3 from David Heidelberg (okias) <david@ixit.cz> ---
Created attachment 108777
  --> https://bugs.freedesktop.org/attachment.cgi?id=108777&action=edit
debug_vs_ps_sbdry.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1311 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] r600g+nine: Bioshock shader failure after 7b1c0cbc90d456384b0950ad21faa3c61a6b43ff

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1399 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

David Heidelberg (okias) <david@ixit.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|bisected, regression        |
            Summary|[regression] r600g+nine:    |r600g+nine: Bioshock shader
                   |Bioshock shader failure     |failure after
                   |after                       |7b1c0cbc90d456384b0950ad21f
                   |7b1c0cbc90d456384b0950ad21f |aa3c61a6b43ff
                   |aa3c61a6b43ff               |

--- Comment #4 from David Heidelberg (okias) <david@ixit.cz> ---
It's bug in Nine.

Instead of one available ADDR[0], we try use DCL ADDR[0..1].

ADDR[0] is allocated by LOOP (for counter purposes) and then later is allocated
ADDR[1].

0 is the address register (already allocated by LOOP, but in this case unused)
1 is UBO index register (misused by location for MOVA (coverted)-> ARR)
2 is sampler index register (not used, correctly).

Axel had idea we could do something like:

. if wants to use rL to index constant register
. . if a0 is used somewhere in the shader
. . then copy the content to temp. load rL to a0. do the op. restore a0
. . else copy rL to a0 and use it
. else do nothing particular

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2830 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] r600g+nine: Bioshock shader failure after 7b1c0cbc90d456384b0950ad21faa3c61a6b43ff

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1006 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

--- Comment #5 from Ilia Mirkin <imirkin@alum.mit.edu> ---
(In reply to David Heidelberg (okias) from comment #4)
> It's bug in Nine.
> 
> Instead of one available ADDR[0], we try use DCL ADDR[0..1].
> 
> ADDR[0] is allocated by LOOP (for counter purposes) and then later is
> allocated ADDR[1].
> 
> 0 is the address register (already allocated by LOOP, but in this case
> unused)
> 1 is UBO index register (misused by location for MOVA (coverted)-> ARR)
> 2 is sampler index register (not used, correctly).

While the opengl state tracker uses ADDR in this way, it is not in any way
required by TGSI or gallium that this be the case. ADDR registers can be used
however you want, they're just registers like any other, except that they can
be used for indirect indexing into TEMP and CONST registers (perhaps IN and OUT
as well, not sure), and with ARB_gs5, into SAMP as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1940 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] r600g+nine: Bioshock shader failure after 7b1c0cbc90d456384b0950ad21faa3c61a6b43ff

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 410 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

--- Comment #6 from David Heidelberg (okias) <david@ixit.cz> ---
In testing repository [1] fixed by commit:

st/nine: Rewrite LOOP implementation, and a0 aL handling

Now it also passes wine tests without killing driver (r600g).


[1] https://github.com/iXit/Mesa-3D/commits/master

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1308 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 85696] r600g+nine: Bioshock shader failure after 7b1c0cbc90d456384b0950ad21faa3c61a6b43ff

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 577 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=85696

David Heidelberg (okias) <david@ixit.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from David Heidelberg (okias) <david@ixit.cz> ---
Fixed in mesa repository by commit 6a8e5e48be0bad4606b2d5d7ba736a3d2a277c55 .
Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2151 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel