[Bug 98239] saints row 3: performance is limited by flushes

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1248 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

            Bug ID: 98239
           Summary: saints row 3: performance is limited by flushes
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: aaalmosss@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 127280
  --> https://bugs.freedesktop.org/attachment.cgi?id=127280&action=edit
sr3 flush.png

Performance is quite poor, while the gpu load is very low. The attached
screenshot shows that gpu load is proportional to fps, and their pattern is the
opposite of the amount of flushes. In typical scenes fps can barely reach 30
while gpu load is around 40% and cpu load is at 60% all the time. I turned off
all special effects for this screenshot to show that this only depends on the
scene complexity. In fact turning on all the effects don't affect performance
much, because the gpu and the cpu are barely loaded.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2738 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 226 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #1 from Marek Olšák <maraeo@gmail.com> ---
What's your GPU and kernel driver?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1001 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 399 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #2 from almos <aaalmosss@gmail.com> ---
(In reply to Marek Olšák from comment #1)
> What's your GPU and kernel driver?

I have an R9 270x (Curaçao XT), the kernel driver is radeon. BTW the game runs
noticeably smoother with Mesa 13 than with 12.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1239 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
Things to try:

1) You can try increasing the IB size in radeon_drm_cs.h:
struct radeon_cs_context {
    uint32_t                    buf[16 * 1024]; // HERE

2) Add buffer-wait-time to the HUD and see if it corresponds with the flushes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1209 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1919 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #4 from almos <aaalmosss@gmail.com> ---
(In reply to Marek Olšák from comment #3)
> Things to try:
> 
> 1) You can try increasing the IB size in radeon_drm_cs.h:
> struct radeon_cs_context {
>     uint32_t                    buf[16 * 1024]; // HERE
> 
> 2) Add buffer-wait-time to the HUD and see if it corresponds with the
> flushes.

I tried it with 4x larger buf. The flushes are reduced to 4-5 instead of around
15, but the performance and gpu-load remained mostly the same. It feels a bit
smoother, and the fps seems more consistent, but I didn't compare it
thoroughly. It seems the flush count is not a cause, but a symptom.

With 8x larger buf all textures are missing.

I also tried to monitor other data sources (e.g. dma), but nothing seems to be
as correlated with the fps as the gpu-load is. The buffer-wait-time somewhat
resembles, but not always.

BTW sr3 produces other interesting things, for example when starting up I get
15fps in the main menu, but after loading a game, and exiting to the main menu
I get 120fps.

I also checked other games for gpu-load, and here are the results (none of them
are cpu-bound):
- furmark: 100% load, fps 105-115 sinusoid (its period is different from the
rotation of the doughnut, might be worth checking this out)
- amnesia: solid 60fps regardless of the vsync setting, load is 20-30%
- heaven 4: the load is 80-100% perfectly correlated to fps
- quake wars: base fps is 30, jumping to higher numbers with high frequency (on
windows I get rock solid 60fps), load is 20-30%
- doom 3: fps is usually 55-60, in some areas it drops to 40 (should be rock
solid 60), while the load is 8-11% uncorrelated to fps
- tf2: fps has huge variance between 40-140, load is 30-60% correlated to fps

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2780 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 449 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #5 from Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> ---
With 15 flushes/frame, I think it is very unlikely you are flush limited. The
flushes probably just correlate with number of draw commands (because we need
more buffers to store more draws) and the draws themselves probably are the
bottleneck.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1235 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 439 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #6 from Marek Olšák <maraeo@gmail.com> ---
Doom 3 is limited by the CPU. OpenGL multithreading should help with that. With
stock Mesa, there is no way make Doom 3 faster.

When the GPU load is low, it means the app is CPU-bound. Multithreading is the
only thing that can help with that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1214 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 767 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #7 from almos <aaalmosss@gmail.com> ---
(In reply to Marek Olšák from comment #6)
> Doom 3 is limited by the CPU. OpenGL multithreading should help with that.
> With stock Mesa, there is no way make Doom 3 faster.
> 
> When the GPU load is low, it means the app is CPU-bound. Multithreading is
> the only thing that can help with that.

Hmm, you're right. By default all cores are used 30%, but if I start doom3 with
taskset -c 0, it uses 100% of core 0, and I get 35-50fps at 6-8% gpu load. I
didn't know tasks were being moved between CPU cores this much. And it seems
that my CPU is slower than I thought.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1619 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 507 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

Vedran Miletić <vedran@miletic.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |77449


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=77449
[Bug 77449] Tracker bug for all bugs related to Steam titles
-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1560 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 453 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

--- Comment #8 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
After playing SR3 a bit on RX480 with mesa 17.1.5 and LLVM 4.0.1, it appears to
perform quite well. I have 70-80 FPS almost everywhere in ultra and it's
GPU-bound there. Okay it's a different configuration but I think this ticket
should be closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1239 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 98239] saints row 3: performance is limited by flushes

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 733 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=98239

almos <aaalmosss@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #9 from almos <aaalmosss@gmail.com> ---
Right, I forgot to close this.

The game is CPU-bound on my machine, because it's an eON wrapped version of a
terrible PC port. I've read reports that it has weird performance problems on
windows too.

I've also tried glthread, but didn't help.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2224 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel